- CommandLine="$(QTDIR)\bin\moc.exe -DUNICODE -DWIN32 -DQT_LARGEFILE_SUPPORT -Dqh_QHpointer -DQT_DLL -DQT_GUI_LIB -DQT_CORE_LIB -DQT_HAVE_MMX -DQT_HAVE_3DNOW -DQT_HAVE_SSE -DQT_HAVE_MMXEXT -DQT_HAVE_SSE2 -DQT_THREAD_SUPPORT -DQT_NO_DYNAMIC_CAST -I"$(QTDIR)\include\QtCore" -I"$(QTDIR)\include\QtGui" -I"$(QTDIR)\include" -I"$(QTDIR)\include\QtTest" -I"..\src\libqhullcpp" -I"..\src" -I"..\src" -I"$(QTDIR)\include\ActiveQt" -I"moc" -I"..\src\qhulltest" -I"." -I$(QTDIR)\mkspecs\win32-msvc2005 -D_MSC_VER=1400 -DWIN32 ..\src\qhulltest\RoadTest.h -o moc\moc_RoadTest.cpp && echo /*-------------------------------------------------------------------- >..\src\qhulltest\RoadTest.h.cpp && echo * Precompiled header source file used by Visual Studio.NET to generate>>..\src\qhulltest\RoadTest.h.cpp && echo * the .pch file.>>..\src\qhulltest\RoadTest.h.cpp && echo *>>..\src\qhulltest\RoadTest.h.cpp && echo * Due to issues with the dependencies checker within the IDE, it>>..\src\qhulltest\RoadTest.h.cpp && echo * sometimes fails to recompile the PCH file, if we force the IDE to>>..\src\qhulltest\RoadTest.h.cpp && echo * create the PCH file directly from the header file.>>..\src\qhulltest\RoadTest.h.cpp && echo *>>..\src\qhulltest\RoadTest.h.cpp && echo * This file is auto-generated by qmake since no PRECOMPILED_SOURCE was>>..\src\qhulltest\RoadTest.h.cpp && echo * specified, and is used as the common stdafx.cpp. The file is only>>..\src\qhulltest\RoadTest.h.cpp && echo * generated when creating .vcproj project files, and is not used for>>..\src\qhulltest\RoadTest.h.cpp && echo * command line compilations by nmake.>>..\src\qhulltest\RoadTest.h.cpp && echo *>>..\src\qhulltest\RoadTest.h.cpp && echo * WARNING: All changes made in this file will be lost.>>..\src\qhulltest\RoadTest.h.cpp && echo --------------------------------------------------------------------*/>>..\src\qhulltest\RoadTest.h.cpp && echo #include "RoadTest.h">>..\src\qhulltest\RoadTest.h.cpp
"
- CommandLine="$(QTDIR)\bin\moc.exe -DUNICODE -DWIN32 -DQT_LARGEFILE_SUPPORT -Dqh_QHpointer -DQT_DLL -DQT_NO_DEBUG -DQT_GUI_LIB -DQT_CORE_LIB -DQT_HAVE_MMX -DQT_HAVE_3DNOW -DQT_HAVE_SSE -DQT_HAVE_MMXEXT -DQT_HAVE_SSE2 -DQT_THREAD_SUPPORT -DQT_NO_DYNAMIC_CAST -I"$(QTDIR)\include\QtCore" -I"$(QTDIR)\include\QtGui" -I"$(QTDIR)\include" -I"$(QTDIR)\include\QtTest" -I"..\src\libqhullcpp" -I"..\src" -I"..\src" -I"$(QTDIR)\include\ActiveQt" -I"moc" -I"..\src\qhulltest" -I"." -I$(QTDIR)\mkspecs\win32-msvc2005 -D_MSC_VER=1400 -DWIN32 ..\src\qhulltest\RoadTest.h -o moc\moc_RoadTest.cpp && echo /*-------------------------------------------------------------------- >..\src\qhulltest\RoadTest.h.cpp && echo * Precompiled header source file used by Visual Studio.NET to generate>>..\src\qhulltest\RoadTest.h.cpp && echo * the .pch file.>>..\src\qhulltest\RoadTest.h.cpp && echo *>>..\src\qhulltest\RoadTest.h.cpp && echo * Due to issues with the dependencies checker within the IDE, it>>..\src\qhulltest\RoadTest.h.cpp && echo * sometimes fails to recompile the PCH file, if we force the IDE to>>..\src\qhulltest\RoadTest.h.cpp && echo * create the PCH file directly from the header file.>>..\src\qhulltest\RoadTest.h.cpp && echo *>>..\src\qhulltest\RoadTest.h.cpp && echo * This file is auto-generated by qmake since no PRECOMPILED_SOURCE was>>..\src\qhulltest\RoadTest.h.cpp && echo * specified, and is used as the common stdafx.cpp. The file is only>>..\src\qhulltest\RoadTest.h.cpp && echo * generated when creating .vcproj project files, and is not used for>>..\src\qhulltest\RoadTest.h.cpp && echo * command line compilations by nmake.>>..\src\qhulltest\RoadTest.h.cpp && echo *>>..\src\qhulltest\RoadTest.h.cpp && echo * WARNING: All changes made in this file will be lost.>>..\src\qhulltest\RoadTest.h.cpp && echo --------------------------------------------------------------------*/>>..\src\qhulltest\RoadTest.h.cpp && echo #include "RoadTest.h">>..\src\qhulltest\RoadTest.h.cpp
"
exit_if_err $HERE "Error while checking $zip_file"
}
function check_tgz_file #tgz_file
{
local tgz_file=$1
local HERE=$(ro_here)
log_note $HERE "Check $tgz_file"
ls -l $tgz_file >>$err_log
exit_if_err $HERE "Did not create $tgz_file"
tar -tzf $tgz_file >/dev/null 2>>$err_log
exit_if_err $HERE "Can not extract -- tar -tzf $tgz_file"
}
function convert_to_unix #dir $qhull_2ufiles -- convert files to Unix, preserving modtime from $root_dir
{
local temp_dir=$1
local HERE=$(ro_here)
log_note $HERE "Convert files to unix format in $1"
for f in $(find $temp_dir -type f | grep -E '^([^.]*|.*\.(ac|am|bashrc|c|cfg|cpp|css|d|dpatch|h|htm|html|man|pl|pri|pro|profile|sh|sql|termcap|txt|xml|xsd|xsl))$'); do
-<li>How to avoid copy constructor while logging, maybeThrowQhullMessage()
-<li>How to configure Qhull output. Trace and results should go to stdout/stderr
-<li>Qhull and RboxPoints messaging. e.g., ~Qhull, hasQhullMessage(). Rename them as QhullErrorMessage?
-<li>How to add additional output to an error message, e.g., qh_setprint
-<li>Is idx the best name for an index? It's rather cryptic, but BSD strings.h defines index().
-<li>Qhull::feasiblePoint Qhull::useOutputStream as field or getter?
-<li>Define virtual functions for user customization of Qhull (e.g., qh_fprintf, qh_memfree,etc.)
-<li>Figure out RoadError::global_log. clearQhullMessage currently clearGlobalLog
-<li>Should the false QhullFacet be NULL or empty? e.g., QhullFacet::tricoplanarOwner() and QhullFacetSet::end()
-<li>Should output format for floats be predefined (qh_REAL_1, 2.2g, 10.7g) or as currently set for stream
-<li>Should cout << !point.defined() be blank or 'undefined'
-<li>Interface for UsingLibQhull::globalAngleEpsilon(), globalDistanceEpsilon, etc.
-<li>Interface for UsingLibQhull::globalDimension
-<li>Set up globals for thread-private storage (redefine macros qh, qhstat, etc)
-<li>Is Q_GLOBAL_STATIC non-threaded/threaded, needed for Qhull?
-<li>Infinite point as !defined()
-<li>qlist and qlinkedlist define pointer, reference, size_type, difference_type, const_pointer, const_reference for the class but not for iterator and const_iterator
A QhullFacetSet is a <a href="#set-cpp">QhullSet</a> of <a href="#facet-cpp">QhullFacet</a>. QhullFacetSet may be ordered or unordered. The neighboring facets of a QhullFacet is a QhullFacetSet.
The neighbors of a <a href="#facet-cpp">QhullFacet</a> is a QhullFacetSet.
The neighbors are ordered for simplicial facets, matching the opposite vertex of the facet.
A QhullPointSet is a <a href="#set-cpp">QhullSet</a> of <a href="#point-cpp">QhullPoint</a>. The QhullPointSet of a <a href="#facet-cpp">QhullFacet</a> is its coplanar points.
A QhullRidgeSet is a <a href="#set-cpp">QhullSet</a> of <a href="#ridge-cpp">QhullRidge</a>. Each <a href="#facet-cpp">QhullFacet</a> contains a QhullRidgeSet.
A QhullVertex is a vertex of the convex hull. A simplicial <a href="#facet-cpp">QhullFacet</a> has qh.hull_dim-1 vertices. A QhullVertex contains a <a href="#point-cpp">QhullPoint</a>.
It may list its neighboring <a href="#facet-cpp">QhullFacet</a>'s.
RboxPoints is a std::vector of point coordinates (<a href="#point-cpp">QhullPoint</a>).
It's iterator is <a href="#coordinate-cpp">CoordinateIterator</a>.
</p>
<p>
<code>RboxPoints.appendRandomPoints()</code> appends points from a variety of distributions such as uniformly distributed within a cube and random points on a sphere.
It can also append a cube's vertices or specific points.
+<li>How to avoid copy constructor while logging, maybeThrowQhullMessage()
+<li>How to configure Qhull output. Trace and results should go to stdout/stderr
+<li>Qhull and RboxPoints messaging. e.g., ~Qhull, hasQhullMessage(). Rename them as QhullErrorMessage?
+<li>How to add additional output to an error message, e.g., qh_setprint
+<li>Is idx the best name for an index? It's rather cryptic, but BSD strings.h defines index().
+<li>Qhull::feasiblePoint Qhull::useOutputStream as field or getter?
+<li>Define virtual functions for user customization of Qhull (e.g., qh_fprintf, qh_memfree,etc.)
+<li>Figure out RoadError::global_log. clearQhullMessage currently clearGlobalLog
+<li>Should the false QhullFacet be NULL or empty? e.g., QhullFacet::tricoplanarOwner() and QhullFacetSet::end()
+<li>Should output format for floats be predefined (qh_REAL_1, 2.2g, 10.7g) or as currently set for stream
+<li>Should cout << !point.defined() be blank or 'undefined'
+<li>Infinite point as !defined()
+<li>qlist and qlinkedlist define pointer, reference, size_type, difference_type, const_pointer, const_reference for the class but not for iterator and const_iterator
Qhull computes the convex hull, Delaunay triangulation, Voronoi diagram,
halfspace intersection about a point, furthest-site Delaunay
triangulation, and furthest-site Voronoi diagram. The source code runs in
2-d, 3-d, 4-d, and higher dimensions. Qhull implements the Quickhull
algorithm for computing the convex hull. It handles roundoff
errors from floating point arithmetic. It computes volumes,
surface areas, and approximations to the convex hull.</p>
<!-- duplicated in index.htm and html/index.htm -->
<p>Qhull does <i>not</i> support triangulation of non-convex surfaces, mesh
generation of non-convex objects, medium-sized inputs in 9-D
and higher, alpha shapes, weighted Voronoi diagrams, Voronoi volumes, or
constrained Delaunay triangulations, </p>
-<p>Qhull 2012.1 fixes qhull-go for Windows 64-bit. If you use Qhull 2003.1. please upgrade to 2012.1 or apply <a href="http://www.qhull.org/download/poly.c-qh_gethash.patch">poly.c-qh_gethash.patch</a>.</p>
+<p>Qhull 2015.1 introduces reentrant Qhull. It allows concurrent Qhull runs and simplifies the C++ interface to Qhull.
+If you call Qhull from your program, you should use reentrant Qhull (libqhull_r) instead of qh_QHpointer (libqhull).
+If you use Qhull 2003.1. please upgrade or apply <a href="http://www. qhull.org/download/poly.c-qh_gethash.patch">poly.c-qh_gethash.patch</a>.
<li><a href=http://www.voronoi.com>Voronoi Web Site</a> for all things Voronoi
<li>Young's <a href="http://homepage.usask.ca/~ijm451/finite/fe_resources/">Internet Finite Element Resources</a>
<li><a href="http://www.uic.nnov.ru/~zny/skeleton/">Zolotykh's Skeleton</a> generates all extreme rays of a polyhedral cone using the Double Description Method</li>
+ Coordinates.indexOf assumes countT is signed (from end)
+ Coordinates.lastIndexOf assumes countT is signed (from end)
+ All error messages with countT are wrong, convert to int?
+ RboxPoints.qh_fprintf_rbox, etc. message 9393 assumes countT but may be int, va_arg(args, countT); Need to split
+
+------------
+To do for a furture version of the C++ interface
+ - Document C++ using Doxygen conventions (//! and //!<)
+ - Create a shared library for libqhullcpp. It must include all uses of QH_TRY and setjmp().
+ - Should Qhull manage the output formats for doubles? QH11010 user_r.h defines qh_REAL_1 as %6.8g
+ - Allocate memory for QhullSet using Qhull.qhmem. Create default constructors for QhullVertexSet etc. Also mid() etc.
+ - Add interior point for automatic translation?
+ - Add hasNext() to all next() iterators (e.g., QhullVertex)
- Add defineAs to each object
+ - Write a program with concurrent Qhull
+ - Write QhullStat and QhullStat_test
- Add QList and vector instance of facetT*, etc.
- Generalize QhullPointSetIterator
- - Review all tests
- Add QhullStat_test
- Add printIdentifiers to Set tests
- Add QhullVertexSet_test
- Add Qhull* to constructors
- Test QhullQh* constructors
- Test QhullFacetList.operator=
- Test QhullLinkedList.operator=
- Test QhullFacetSet.operator=
- Test QhullFacetSet.print("message")
- Test QhullPoints.operator=
- Test QhullPointSet.operator=
- Test QhullSet.operator=
- Test qh_NOmem, etc.
- - Reviewed
- QhullPoint_test
- - Update LASTerror for qhullpcpp.QhullError.h
- - Check that QtCreator can load and build with CMakefile
- - Incremental addition of input points to existing tesselation
- - Add reference (compares to cgal, http://www.mcs.anl.gov/papers/P5154-0614.pdf, 4x more memory, cgal much faster)
- Y. Liu and J. Snoeyink, A Comparison of Five Implementations of 3D Delaunay Tessellation, Combinatorial and Computational Geometry, vol. 52, pp. 439458, 2005.
- - Fix no-more facets error
- - Fix interface to Qhull. Shouldn't do all the work in the constructor
- void runQhull(const char *qhullCommand2);
------------
-Dec'14 notes
-
-make-vcproj.sh -- Renames build/ to build-prev. Creates build, build-vc and build-qt (needs editing)
-Renamed build to build-new
-Copied build-prev to build and renamed as build-mar14
-Devenv loaded build/qhullr.sln with qhullmini
- build/qhulltest-mini/qhullmini.vcproj
- build/libqhullcpp/libqhullcpp.vcproj
- build/libqhullstaticr/libqhullstaticr.vcproj
-Includes
- build/libqhullr/libqhullr.vcproj
-
-Load Qt Creator (Oct'14) with src/qhull-all.pro -- The project is odd due to the include files
-Successfully compiled and ran qhullmini with QhullPoint_test
-Updated Perforce
-Added user_eg3
+Qhull 2015.0.2
+
+ Source code changes
+ - Increased size of vertexT.id and ridgeT.id to 2^32
+ Reworded the warning message for ridgeT.id overflow. It does not affect Qhull output
+ - Add qh_lib_check to check for a compatible Qhull library.
+ Programs should call QHULL_LIB_CHECK before calling Qhull.
+ - Include headers prefixed with libqhull/, libqhull_r/, or libqhullcpp/
+ - Renamed debugging routines dfacet/dvertex to qh_dfacet/qh_dvertex
+ - Rewrote user_eg, user_eg2, and user_eg3 as reentrant code
+ - Renamed 'qh_rand_seed' to 'qh_last_random'. Declare it as DATA
+ - qh_initqhull_start2 sets qh->NOerrexit on initialization
+ User must clear NOerrexit after setjmp()
-------------
-Qhull
- - Fixed documentation for 'include' path in qh-code.htm. It should be include/libqhull [fe rew]
- - Fixed documentation for 'i' in qconvex.htm. It triangulates in 4-d and higher [
- - Clarified qhalf space documentation for the interior point [J. Santos]
- - Rename debugging routines dfacet/dvertex to qh_dfacet/qh_dvertex
+ Other source code changes
+ - Define ptr_intT as 'long long' for __MINGW64__ [A. Voskov]
+ - Removed vertexT.dim and MAX_vdim. It is not used by reentrant Qhull.
+ - Removed qhull_inuse. Not used by C++
+ - Removed old __MWERKS__/__POWERPC__ code that speed up SIOUX I/O
+ - Moved #include libqhull/... before system includes (e.g., <stdio.h>
+ - Check that qh.NOerrexit is cleared before call to qh_initflags
+
+Qhull documentation
+ - README.txt: Added references to qh-code.htm
+ - README.txt: Added section 'Calling Qhull from C programs'
+ - qh-code.htm: Moved Performance after C++ and C interface
+ - qh-code.htm: Moved Cpp Questions to end of the C++ section
+ - qh-code.htm: Fixed documentation for 'include' path. It should be include/libqhull
+ - qconvex.htm: Fixed documentation for 'i'. It triangulates in 4-d and higher [ref]
+ - Clarified qhalf space documentation for the interior point [J. Santos]
+ - rbox.c: Version is same date as qh_version in global.c
+ - gobal_r.c: Version includes a '.r' suffix to indicate 'reentrant'
+
+Qhull builds
+ - Exchanged make targets for testing.
+ 'make test' is a quick test of qhull programs.
+ 'make testall' is a thorough test
+ - Added 'make help' and 'make test' to libqhull and libqhull_r Makefiles
+ - CMakeLists.txt: Remove libqhull, libqhull_r, and libqhullcpp from include_directories
+ - CMakeLists.txt: Add qhull_SHAREDR for qhull_r
+ - CMakeLists.txt: Retain qhull_SHARED and qhull_SHAREDP (qh_QHpointer)
+ - CMakeLists.txt: Move qhull_SHARED and qhull_SHAREDP (qh_QHpointer) to qhull_TARGETS_OLD
+ Drop qhull_STATICP (use qhull_SHAREDP or qhull_STATIC)
+ Set SOVERSION and VERSION for shared libraries
+ - Move qhull_p-exports.def back to libqhull
+ - Switched to mingw-w64-install for gcc
+ - Improved prompts for 'make'
+ - qhull-all.pro: Remove user_eg3.cpp from OTHER_FILES
+ - libqhull.pro: Ordered object files by frequency of execution, as done before
+ - Add the folder name to C++ includes and remove libqhullcpp from INCLUDEPATH
+ - Changed CONFIG+=qtestlib to QT+=testlib
+ - Changed Makefile to gcc -O3 (was -O2)
+ - Changed libqhull/libqhull_r Makefiles to both produce rbox, qhull, ..., user_eg, and user_eg2
+ - Removed Debian 'config/...'. It was needed for Qhull 2012.
+
+libqhull_r (reentrant Qhull)
+ - Replaced qh_qh with a parameter to each procedure
+ No more globally defined data structures in Qhull
+ Simplified multithreading and C++ user interface
All functions are reentrant (Qt: "A reentrant function can ... be called simultaneously from multiple threads, but only if each invocation uses its own data.")
- This replaces qh_QHpointer.
+ No more qh_QHpointer.
+ See user_eg3 and qhulltest
New libraries
- libqhullr -- Shared library with reentrant sources (e.g., poly_r.h and poly_r.c which replace libqhull's poly.h and poly.c)
- libqhullstaticr -- Static library with the same sources as libqhullr
- libqhullcpp -- The C++ interface using libqhullr (further notes below)
+ libqhull_r -- Shared library with reentrant sources (e.g., poly_r.h and poly_r.c which replace libqhull's poly.h and poly.c)
+ libqhullstatic_r -- Static library with the same sources as libqhull_r
+ libqhullcpp -- The C++ interface using libqhullstatic_r (further notes below)
New executables
- qhulltest -- Test the C++ interface using Qt
- testqsetr -- Test qset_r.c (the reentrant version of qset.c
- Renamed libraries and executables
- libqhullpcpp -- The old C++ interface using qh_QHpointer and libqhullp (previously called libqhullcpp)
- qhullptest -- The old test program for the C++ interface (previously called qhulltest)
+ testqset_r -- Test qset_r.c (the reentrant version of qset.c
- Source code changes for libqhullr
+ Source code changes for libqhull_r
+ - Add qh_zero() to initialize and zero memory for qh_new_qhull
- Remove qh_save_qhull(), qh_restore_qhull(), and qh.old_qhstat from global_r.c
- Remove qh_freeqhull2() (global_r.c)
- Remove qh_freestatistics() (stat_r.c)
- Remove qh_compare_vertexpoint (qhT is not available, unused code)
- Remove conditional code for __POWERPC__ from unix_r.c and rbox_r.c
- Move qh_last_random into qh->last_random (random_r.c)
- Rename sources files with a '_r' suffix. qhull_a.h becomes qhull_ra.h
- Replace 'qh' macro with 'qh->'
- Replace global qhT with parameter-0
- Add qhmemT to beginning of qhT. It may not be used standalone.
- Add qhstatT to end of qhT
- Remove qhull_inuse
- Change qhmem.zzz to qh->qhmem.zzz
- Replace qh_qhstat with qh->qhstat
- Remove qh_freestatistics
- Replace qh_last_random with qh->last_random
- Replace rboxT with qh->rbox_errexit, rbox_isinteger, rbox_out_offset
- Replace rbox.ferr/fout with qh->ferr/fout
- No qh for qh_exit, qh_free, qh_malloc, qh_strtod, qh_strtol, qh_stddev
- New qmake include files qhull-app-c_r.pri, qhull-app-shared_r.pri, qhull-libqhull-src_r.pri
- Replace 'int' with 'countT' and 'COUNTmax' for large counts and identifiers
- qhset converted to countT
- Removed vertexT.dim -- No longer needed by cpp
Removed MAX_vdim
- Guarantee that qh->run_id!=0. Old code assumed that qh_RANDOMint was 31 bits
-C++ interface
- - Reimplement C++ interface on reentrant libqhullr instead of libqhull
- - Renamed libqhullcpp to libqhullpcpp
- - Renamed qhulltest to qhullptest
- - Renamed qhull-app-cpp.pri to qhull-app-cpp_p.pri
+Changes to libqhullcpp
+ - Removed qhull_interface.cpp -- better to use Qhull.cpp.
+ If math.h breaks '#include qhull_a.h', preceed it with '#include math.h'
- Added QhullVertexSet.h to libqhullcpp.pro and libqhullpcpp.pro
+ - QhullVertexSet: error if qhsettemp_defined at copy constructor/assignment (otherwise double free)
+ - Enable QhullSet.operator=. Copy constructor and assignment only copies pointers
+ - Changed QhullPoint.operator==() to sqrt(distanceEpsilon)
+ - Added assignment of base class QhullPoints to PointCoordinates.operator=
+ - Enable QhullPoints.operator=
+ - Rename PointCoordinates.point_comment to describe_points
+ - Add 'typename T' to definition of QhullSet<T>::value()
+
+C++ interface
+ - Reimplemented C++ interface on reentrant libqhull_r instead of libqhull
+ - Prepend include files with libqhullcpp/
- Replaced UsingLibQhull with QhullQh and macro QH_TRY
Removed UsingLibQhull.currentAngleEpsilon and related routines
+ Removed UsingLibQhull_test.cpp
Replaced globalDistanceEpsilon with QhullQh.distanceEpsilon
Replaced globalAngleEpsilon with QhullQh.angleEpsilon
+ Moved UsingQhullLib.checkQhullMemoryEmpty to QhullQh.checkAndFreeQhullMemory
Replaced FACTORepsilon=10 with QhullQh.factor_epsilon=1.0
- - Fixed double free by QhullVertexSet's copy constructor if qhsettemp_defined
+ - To avoid -Wshadow for QhullQh*, use 'qqh' for parameters and 'qh()' for methods
- Moved messaging from Qhull to QhullQh
- - RboxPoints(rboxCommand).comment() includes the command with its
- Add check of RboxPoints* in qh_fprintf_rbox
- Renamed Qhull.initializeQhull to Qhull.allocateQhullQh
- - Renamed UsingQhullLib.checkQhullMemoryEmpty to QhullQh.checkAndFreeQhullMemory
Added qh_freeqhull(!qh_ALL) as done by unix.c and other programs
- Moved QhullPoints.extraCoordinatesCount into QhullPoints.cpp
- - Changed QhullPoint.operator== to sqrt(distanceEpsilon)
- Replaced section tags with '#//!\name ...'
- - PointCoordinates.operator=: initialize QhullPoints, otherwise does not copy point_dimension
+ - Removed qhRunId from print() to ostream.
+ - Removed print() to ostream. Use '<< qhullPoint' or '<< qhullPoint.print("message")'
C++ interface for most classes
- Remove qhRunId
- Add QhullQh *qh_qh to all types
Pointer comparisons of facetT,etc. do not test corresponding qh_qh
Added to end of type for debugging information, unless wasteful alignment
- Add QhullQh * to all constructors
- All constructors may use Qhull & instead of QhullQh *
- For inherited QhullQh types, change to 'protected'
- Renamed 'o' to 'other' except where used extensively in iterators
- Except for conditional code, merged the Conversion section into GetSet
- Removed empty(). Use isEmpty() instead
- Add operator= instead of keeping it private
- print_message=0 not allowed. Use "" instead.
+ - Rename isDefined() to isValid() to match Qt conventions
C++ interface by class
- Coordinates
Removed empty(). Use isEmpty() instead
+ Added append(dim, coordT*)
Reformated the iterators
Convert to countT
- PointCoordinates
- Constructor requires Qhull or QhullQh* pointer
+ Added constructors for Qhull or QhullQh* (provides access to QhullPoint.operator==)
+ Removed PointCoordinates(int pointDimension) since PointCoordinates should have a comment. Also, it is ambiguous with PointCoordinates(QhullQh*)
Renamed point_comment to describe_points
Convert to countT
- Qhull
Remove qhull_run_i
Remove qh_active
+ Replace property feasiblePoint with field feasible_point and methods setFeasiblePoint/feasiblePoint
+ Returns qh.feasible_point if defined
+ Moved useOutputStream to QhullQh use_output_stream
+ Renamed useOutputStream() to hasOutputStream()
Replaced qhull_dimension with qh->input_dim //! Dimension of result (qh.hull_dim or one less for Delaunay/Voronoi)
- Remove globals s_qhull_output= 0;
+ Removed global s_qhull_output= 0;
+ Move qhull_status, qhull_message, error_stream, output_stream to QhullQh
Renamed qhullQh() to qh()
Added check of base address to allocateQhullQh(), Was not needed for qhullpcpp
- QhullFacet
Constructor requires Qhull or QhullQh* pointer
Convert to countT
Dropped implicit conversion from facetT
Dropped runId
+ Add print("message") to replace print()
- QhullFacetList
Constructor requires Qhull or QhullQh* pointer
Convert to countT
Dropped runId
- QhullFacetSet
Removed empty(). Use isEmpty() instead
Constructor requires Qhull or QhullQh* pointer
Convert to countT
Dropped runId
Add operator=
Implement print("message")
- QhullHyperplane
- Constructor requires Qhull or QhullQh* pointer
- Reorganized
+ Add hyperplaneAngle() method
+ Rewrite operator== to use hyperplaneAngle()
+ Reorganize fields to keep pointers aligned
+ Except for default constructor requires Qhull or QhullQh* pointer
+ Enable copy assignment
+ Reorganized header
- QhullLinkedList
Add operator=
Removed empty(). Use isEmpty() instead
Convert to countT
+ iterator(T) made iterator(const T &)
+ const_iterator(T) made const_iterator(const T &)
+ const_iterator(iterator) made const_iterator(const iterator &)
- QhullPoint
- Constructor requires Qhull or QhullQh* pointer
- An empty QhullPoint sets point_dimension to hull_dim
- Added checks for point_coordinates==0, i.e., QhullPoint(q)
- Removed QhullPoint::id, use QhullPoint.id() instead
+ Add constructors for Qhull or QhullQh* pointer (for id() and operator==)
+ Add defineAs(coordT*)
+ Add getBaseT() and base_type for QhullSet<QhullPoint>
+ Added checks for point_coordinates==0
+ Removed static QhullPoint::id(), use QhullPoint.id() instead
distance() throws an error if dimension doesn't agree or if a point is undefined
Convert to countT
- Removed test of qh_qh from operator==
+ If !qh_qh, operator==() requires equal coordinates
Use cout<<p instead of cout<<p.print()
Reorganized
- QhullPoints
+ Add constructors for Qhull and QhullQh* (for qh.hull_dim, QhullPoint::operator==)
+ Remove QhullPoints(int pointDimension) since it is ambiguous with QhullPoints(QhullQh *qqh)
Add operator=
Removed empty(). Use isEmpty() instead
- Constructor requires Qhull or QhullQh* pointer
Convert to countT
- operator==() if pointers are the same
- Remove test of qh_qh from operator==
+ operator==() tests if pointers are the same. Ituses distanceEpsilon if qh_qh is defined
Reorganized
+ - QhullPoints::Iterator and ConstIterator
+ Removed default constructors
+ Add constructors for Qhull and QhullQh* (for qh.hull_dim, QhullPoint::operator==)
+ Moved test of dimension from QHULL_ASSERT to operator==
+ Added QHULL_ASSERT of qh_qh
+ Convert to countT
- QhullPointSet
Constructor requires Qhull or QhullQh* instead of dimension()
Add operator=
Removed empty(). Use isEmpty() instead
Convert to countT
Always print print_message
Drop print(). Replace with print("")
+ - QhullQh
+ Added methods hasOutputStream(), disableOutputStream(), and enableOutputStream() (was Qhull UseOutputStream)
+ Add test of qh.NOerrexit to maybeThrowQhullMessage()
+ Add qhull_status, qhull_message, error_stream, output_stream from Qhull
+ Add factor_epsilon
- QhullRidge
Constructor requires Qhull or QhullQh* pointer
Dropped implicit conversion from ridgeT
Converted otherFacet() to 'const &'
Converted nextRidge3d() to 'const &'
+ Message for '<< QhullRidge' replaces " - " instead of preceeding it
- QhullSet
Removed empty(). Use isEmpty() instead
Constructor requires Qhull or QhullQh* pointer
Convert to countT
Add operator=
- QhullVertex
Constructor requires Qhull or QhullQh* pointer
Convert to countT
Dropped implicit conversion from vertexT
+ Add message to '<< QhullVertex'
- QhullVertexSet
Removed empty(). Use isEmpty() instead
Constructor requires Qhull or QhullQh* pointer
Convert to countT
- UsingQhullLib
Removed
Replace setGlobalDistanceEpsilon with setFactorEpsilon
Replace globalDistanceEpsilon with distanceEpsilon
-
+------------
Qhull 2012.1 2012/02/18 6.3.1.1494
- Fix CMakeLists for libqhull with MATCHES [P. Gajdos]
------------
Qhull 2012.1 2012/02/18 6.3.1.1490
Code changes
- Require option 'Qz' for Delaunay triangulation/Voronoi diagram
of cocircular/cospherical points [D. Sheehy]
- qh_errexit: Do not call qh_printsummary or qh_printstats on qh_ERRinput
- Change error QH6227 (all degenerate) from qh_ERRinput to qh_ERRprec
- Change error QH6159 (ID overflow) from qh_ERRinput to qh_ERRqhull
- eg/q_eg, q_egtest, q_test: Run if qconvex is in $PATH [M. Atzeri]
Build changes [M. Atzeri]
- Install to share/doc/qhull instead of share/doc/packages/qhull
- On Unix systems, install to share/man/man1 instead of man/man1
- CMakeLists: Remove the installation of user_eg* and testqset
- CMakeLists: Remove VERSION from qhull executables and libraries
- CMakeLists: Define qhull_SOVERSION instead of qhull_MAJOR
- CMakeLists: Set SOVERSION for shared libraries
- Rename libraries to qhull, qhull_d, qhull_p, and qhull_pd
libqhull6_p.vcproj is now libqhull_p.vcproj
mingw builds as libqhull.dll
cygwin builds as cygqhull-6.dll
linux builds as libqhull.so.6.3.1 with symbolic link as libqhull.so
- Developers using qhull 2011:
libqhull6.so is now libqhull_p.so. Do not use libqhull.so.
qhull6.dll is now qhull_p.dll. Do not use qhull.dll.
- Merged road/ into libqhullcpp/ and qhulltest/
Moved RoadLogEvent.* and RoadError.* to libqhullcpp
Moved RoadTest.* to qhulltest (requires Qt)
Installed RoadTest.h in libqhullcpp
Doc changes
- index.htm: Mathworks uses qhull for n-d
- qhull.htm: Fix qhull for qconvex
- qdelaun.htm/qvoronoi.htm: Use option 'Qz' for circular/cospherical inputs
- make help: Display targets
- Makefile: Better messaging
------------
Qhull 2012.1 2012/02/02 6.3.0.1483
Bug fixes
- Fixed qset.c for -fno-strict-aliasing. This gcc option is no longer needed
(disallow two pointers of differing types to the same memory location)
- Fixed error in qh_setappend_set if first set full and second set empty
- qh_setdelnth, qh_setdelnth_sorted: fixed wording of error message
- qh_setcheck: error message listed size and max backwards.
- qh_setequal: Allow NULL set as documented
- qh_setindex: Allow NULL set as documented
- qh_settemppush: report error if NULL
Code changes
- Add testqset: low level test of qset.c with mem.c
- qh_setendpointer: Implements QSet::endPointer()
- Assigned unique error code for qh_gethash
Build changes
- Added qhull.dll(.so) for Octave and other Debian builds
The global data structure qh_qh is statically defined (no qh_QHpointer)
Linked user_eg2 with qhull.dll (libqhull.so) instead of qhullstatic
Added qh_dllimport to libqhull.h for qhull.dll with MSVC
Changed qhull-app-shared.pri to use libqhull (without qh_QHpointer)
- Renamed libqhull6.so to libqhull6_p.so
Renamed qhull6.dll to qhull6_p.dll
The _p libraries (e.g., libqhull6_p.so) require -Dqh_QHpointer
Renamed qhull6.vcproj to libqhull6_p.vcproj
Added libqhullp/libqhullp.pro for shared library (libqhull6_p.so)
Added qhull-app-sharedp.pri for shared libraries with qh_QHpointer
- Install libqhull/*.htm files into include/libqhull
- Removed libqhull/qhull.h-deprecated [J. Eaton]
- Other changes to Makefile builds
Added 'make qtestall' as a smoketest of each qhull program
src/libqhull/Makefile: Use 'ar -rs ...' instead of ranlib
qh_fprintf(qh ferr, 7039, "qhull warning: real epsilon, %2.2g, is probably too large for joggle('QJn')\nRecompile with double precision reals(see user.h).\n",
REALepsilon);
#ifdef qh_NOmerge
if (qh MERGING) {
qh_fprintf(qh ferr, 6045, "qhull input error: merging not installed(qh_NOmerge + 'Qx', 'Cn' or 'An')\n");
qh_errexit(qh_ERRinput, NULL, NULL);
}
#endif
if (qh DELAUNAY && qh KEEPcoplanar && !qh KEEPinside) {
qh KEEPinside= True;
qh_option("Qinterior-keep", NULL, NULL);
}
if (qh DELAUNAY && qh HALFspace) {
qh_fprintf(qh ferr, 6046, "qhull input error: can not use Delaunay('d') or Voronoi('v') with halfspace intersection('H')\n");
qh_errexit(qh_ERRinput, NULL, NULL);
}
if (!qh DELAUNAY && (qh UPPERdelaunay || qh ATinfinity)) {
qh_fprintf(qh ferr, 6047, "qhull input error: use upper-Delaunay('Qu') or infinity-point('Qz') with Delaunay('d') or Voronoi('v')\n");
qh_errexit(qh_ERRinput, NULL, NULL);
}
if (qh UPPERdelaunay && qh ATinfinity) {
qh_fprintf(qh ferr, 6048, "qhull input error: can not use infinity-point('Qz') with upper-Delaunay('Qu')\n");
qh_errexit(qh_ERRinput, NULL, NULL);
}
if (qh SCALElast && !qh DELAUNAY && qh PRINTprecision)
qh_fprintf(qh ferr, 7040, "qhull input warning: option 'Qbb' (scale-last-coordinate) is normally used with 'd' or 'v'\n");
qh_fprintf(qh ferr, 6056, "qhull input error: Mathematica and Maple output is only available for 2-d and 3-d convex hulls and 2-d Delaunay triangulations\n");
qh_errexit(qh_ERRinput, NULL, NULL);
}
if (printgeom) {
if (qh hull_dim > 4) {
qh_fprintf(qh ferr, 6057, "qhull input error: Geomview output is only available for 2-d, 3-d and 4-d\n");
qh_errexit(qh_ERRinput, NULL, NULL);
}
if (qh PRINTnoplanes && !(qh PRINTcoplanar + qh PRINTcentrums
+ Report error if library does not agree with caller
+
+ notes:
+ NOerrors -- qh_lib_check can not call qh_errexit()
+*/
+void qh_lib_check(int libraryType, int qhTsize, int vertexTsize, int ridgeTsize, int facetTsize, int setTsize, int qhmemTsize) {
+ boolT iserror= False;
+
+ if (libraryType==0 && qh_QHpointer) {
+ qh_fprintf(stderr, 6246, "qh_lib_check: Incorrect qhull library called. Caller uses a static qhT while library uses a dynamic qhT via qh_QHpointer. Both caller and library are non-reentrant.\n");
+ iserror= True;
+ }else if (libraryType==1 && !qh_QHpointer) {
+ qh_fprintf(stderr, 6247, "qh_lib_check: Incorrect qhull library called. Caller uses a dynamic qhT via qh_QHpointer while library uses a static qhT. Both caller and library are non-reentrant.\n");
+ iserror= True;
+ }else if (libraryType==2) {
+ qh_fprintf(stderr, 6248, "qh_lib_check: Incorrect qhull library called. Caller uses reentrant Qhull while library is non-reentrant.");
+ iserror= True;
+ }
+ if (qhTsize != sizeof(qhT)) {
+ qh_fprintf(stderr, 6249, "qh_lib_check: Incorrect qhull library called. Size of qhT for caller is %d, but for library is %d.\n", qhTsize, sizeof(qhT));
+ iserror= True;
+ }
+ if (vertexTsize != sizeof(vertexT)) {
+ qh_fprintf(stderr, 6250, "qh_lib_check: Incorrect qhull library called. Size of vertexT for caller is %d, but for library is %d.\n", vertexTsize, sizeof(vertexT));
+ iserror= True;
+ }
+ if (ridgeTsize != sizeof(ridgeT)) {
+ qh_fprintf(stderr, 6251, "qh_lib_check: Incorrect qhull library called. Size of ridgeT for caller is %d, but for library is %d.\n", ridgeTsize, sizeof(ridgeT));
+ iserror= True;
+ }
+ if (facetTsize != sizeof(facetT)) {
+ qh_fprintf(stderr, 6252, "qh_lib_check: Incorrect qhull library called. Size of facetT for caller is %d, but for library is %d.\n", facetTsize, sizeof(facetT));
+ iserror= True;
+ }
+ if (setTsize && setTsize != sizeof(setT)) {
+ qh_fprintf(stderr, 6253, "qh_lib_check: Incorrect qhull library called. Size of setT for caller is %d, but for library is %d.\n", setTsize, sizeof(setT));
+ iserror= True;
+ }
+ if (qhmemTsize && qhmemTsize != sizeof(qhmemT)) {
+ qh_fprintf(stderr, 6254, "qh_lib_check: Incorrect qhull library called. Size of qhmemT for caller is %d, but for library is %d.\n", qhmemTsize, sizeof(qhmemT));
+ iserror= True;
+ }
+ if (iserror) {
+ if(qh_QHpointer){
+ qh_fprintf(stderr, 6255, "qh_lib_check: Cannot continue. Library '%s' uses a dynamic qhT via qh_QHpointer (e.g., qhull_p.so)\n", qh_version);
qh_fprintf(qh ferr, 6069, "qhull internal error (qh_printend): number of ridges %d != number printed %d and at end %d\n", qh ridgeoutnum, qh printoutvar, num);
+ qh_fprintf(stderr, 6244, "qh_memcheck: either qhmem is overwritten or qhmem is not initialized. Call qh_meminit() or qh_new_qhull() before calling qh_mem routines. ferr 0x%x IsTracing %d ALIGNmask 0x%x", qhmem.ferr, qhmem.IStracing, qhmem.ALIGNmask);
+ qh_exit(qhmem_ERRqhull); /* can not use qh_errexit() */
+ }
+ if (qhmem.IStracing != 0)
+ qh_fprintf(qhmem.ferr, 8143, "qh_memcheck: check size of freelists on qhmem\nqh_memcheck: A segmentation fault indicates an overwrite of qhmem\n");
+ for (i=0; i < qhmem.TABLEsize; i++) {
+ count=0;
+ for (object= qhmem.freelists[i]; object; object= *((void **)object))
+ count++;
+ totfree += qhmem.sizetable[i] * count;
+ }
+ if (totfree != qhmem.totfree) {
+ qh_fprintf(qhmem.ferr, 6211, "Qhull internal error (qh_memcheck): totfree %d not equal to freelist total %d\n", qhmem.totfree, totfree);
+ qh_errexit(qhmem_ERRqhull, NULL, NULL);
+ }
+ if (qhmem.IStracing != 0)
+ qh_fprintf(qhmem.ferr, 8144, "qh_memcheck: total size of freelists totfree is the same as qhmem.totfree\n", totfree);
qh_fprintf(qh ferr, 6096, "qhull internal error (qh_forcedmerges): f%d and f%d had a duplicate ridge but as f%d and f%d they are no longer neighbors\n",
qh_fprintf(qh ferr, 6109, "qhull precision error: point p%d is outside facet f%d, distance= %6.8g maxoutside= %6.8g\n",
facet_i, bestfacet->id, dist, maxoutside);
if (errfacet1 != bestfacet) {
errfacet2= errfacet1;
errfacet1= bestfacet;
}
}
}else if (unassigned && dist < -qh MAXcoplanar)
notverified++;
}
qh_settempfree(&facets);
if (notverified && !qh DELAUNAY && !qh_QUICKhelp && qh PRINTprecision)
qh_fprintf(qh ferr, 8092, "\n%d points were well inside the hull. If the hull contains\n\
a lens-shaped component, these points were not verified. Use\n\
options 'Qci Tv' to verify all points.\n", notverified);
if (maxdist > qh outside_err) {
qh_fprintf(qh ferr, 6110, "qhull precision error (qh_check_bestdist): a coplanar point is %6.2g from convex hull. The maximum value(qh.outside_err) is %6.2g\n",
maxdist, qh outside_err);
qh_errexit2(qh_ERRprec, errfacet1, errfacet2);
}else if (waserror && qh outside_err > REALmax/2)
qh_errexit2(qh_ERRprec, errfacet1, errfacet2);
/* else if waserror, the error was logged to qh.ferr but does not effect the output */
trace0((qh ferr, 20, "qh_check_bestdist: max distance outside %2.2g\n", maxdist));
qh_fprintf(qh ferr, 6112, "qhull precision error (qh_check_points): a coplanar point is %6.2g from convex hull. The maximum value(qh.outside_err) is %6.2g\n",
maxdist, qh outside_err );
qh_errexit2( qh_ERRprec, errfacet1, errfacet2 );
}else if (errfacet1 && qh outside_err > REALmax/2)
qh_errexit2( qh_ERRprec, errfacet1, errfacet2 );
/* else if errfacet1, the error was logged to qh.ferr but does not effect the output */
trace0((qh ferr, 21, "qh_check_points: max distance outside %2.2g\n", maxdist));
qh_fprintf(qh ferr, 6151, "qhull input error: 'Qg QVn' (only good vertex) does not work with merging.\nUse 'QJ' to joggle the input or 'Q0' to turn off merging.\n");
if (!qh_checkflipped(facet, NULL, qh_ALL)) {/* due to axis-parallel facet */
trace1((qh ferr, 1031, "qh_initialhull: initial orientation incorrect. Correct all facets\n"));
facet->flipped= False;
FORALLfacets {
facet->toporient ^= (unsigned char)True;
qh_orientoutside(facet);
}
break;
}
}
FORALLfacets {
if (!qh_checkflipped(facet, NULL, !qh_ALL)) { /* can happen with 'R0.1' */
if (qh DELAUNAY && ! qh ATinfinity) {
if (qh UPPERdelaunay)
qh_fprintf(qh ferr, 6240, "Qhull input error: Can not compute the upper Delaunay triangulation or upper Voronoi diagram of cocircular/cospherical points.\n");
else
qh_fprintf(qh ferr, 6239, "Qhull input error: Use option 'Qz' for the Delaunay triangulation or Voronoi diagram of cocircular/cospherical points. Option 'Qz' adds a point \"at infinity\" (above the corresponding paraboloid).\n");
qh_errexit(qh_ERRinput, NULL, NULL);
}
qh_precision("initial facet is coplanar with interior point");
qh_fprintf(qh ferr, 6154, "qhull precision error: initial facet %d is coplanar with the interior point\n",
returns size of qh.hash_table of at least newsize slots
notes:
assumes qh.hash_table is NULL
qh_HASHfactor determines the number of extra slots
size is not divisible by 2, 3, or 5
*/
int qh_newhashtable(int newsize) {
int size;
size= ((newsize+1)*qh_HASHfactor) | 0x1; /* odd number */
while (True) {
if (newsize<0 || size<0) {
qh_fprintf(qhmem.ferr, 6236, "qhull error (qh_newhashtable): negative request (%d) or size (%d). Did int overflow due to high-D?\n", newsize, size); /* WARN64 */
qh_errexit(qhmem_ERRmem, NULL, NULL);
}
if ((size%3) && (size%5))
break;
size += 2;
/* loop terminates because there is an infinite number of primes */
if (qh->build_cnt > 1 && qh->JOGGLEmax > fmax_(qh->MAXwidth/4, 0.1)) {
qh_fprintf(qh, qh->ferr, 6010, "qhull error: the current joggle for 'QJn', %.2g, is too large for the width\nof the input. If possible, recompile Qhull with higher-precision reals.\n",
qh->JOGGLEmax);
qh_errexit(qh, qh_ERRqhull, NULL, NULL);
}
/* for some reason, using qh->ROTATErandom and qh_RANDOMseed does not repeat the run. Use 'TRn' instead */
seed= qh_RANDOMint;
qh_option(qh, "_joggle-seed", &seed, NULL);
trace0((qh, qh->ferr, 6, "qh_joggleinput: joggle input by %2.2g with seed %d\n",
scale last coordinate to [0,m] for Delaunay triangulations
input points given by points, numpoints, dim
returns:
changes scale of last coordinate from [low, high] to [0, newhigh]
overwrites last coordinate of each point
saves low/high/newhigh in qh.last_low, etc. for qh_setdelaunay()
notes:
when called by qh_setdelaunay, low/high may not match actual data
design:
compute scale and shift factors
apply to last coordinate of each point
*/
void qh_scalelast(qhT *qh, coordT *points, int numpoints, int dim, coordT low,
coordT high, coordT newhigh) {
realT scale, shift;
coordT *coord;
int i;
boolT nearzero= False;
trace4((qh, qh->ferr, 4013, "qh_scalelast: scale last coordinate from [%2.2g, %2.2g] to [0,%2.2g]\n",
low, high, newhigh));
qh->last_low= low;
qh->last_high= high;
qh->last_newhigh= newhigh;
- scale= qh_divzero(qh, newhigh, high - low,
+ scale= qh_divzero(newhigh, high - low,
qh->MINdenom_1, &nearzero);
if (nearzero) {
if (qh->DELAUNAY)
qh_fprintf(qh, qh->ferr, 6019, "qhull input error: can not scale last coordinate. Input is cocircular\n or cospherical. Use option 'Qz' to add a point at infinity.\n");
else
qh_fprintf(qh, qh->ferr, 6020, "qhull input error: can not scale last coordinate. New bounds [0, %2.2g] are too wide for\nexisting bounds [%2.2g, %2.2g] (width %2.2g)\n",
if (qh->MERGING && !qh->POSTmerge && qh->premerge_cos > REALmax/2
&& qh->premerge_centrum == 0) {
qh->ZEROcentrum= True;
qh->ZEROall_ok= True;
qh_option(qh, "_zero-centrum", NULL, NULL);
}
if (qh->JOGGLEmax < REALmax/2 && REALepsilon > 2e-8 && qh->PRINTprecision)
qh_fprintf(qh, qh->ferr, 7039, "qhull warning: real epsilon, %2.2g, is probably too large for joggle('QJn')\nRecompile with double precision reals(see user.h).\n",
REALepsilon);
#ifdef qh_NOmerge
if (qh->MERGING) {
qh_fprintf(qh, qh->ferr, 6045, "qhull input error: merging not installed(qh_NOmerge + 'Qx', 'Cn' or 'An')\n");
qh_errexit(qh, qh_ERRinput, NULL, NULL);
}
#endif
if (qh->DELAUNAY && qh->KEEPcoplanar && !qh->KEEPinside) {
qh->KEEPinside= True;
qh_option(qh, "Qinterior-keep", NULL, NULL);
}
if (qh->DELAUNAY && qh->HALFspace) {
qh_fprintf(qh, qh->ferr, 6046, "qhull input error: can not use Delaunay('d') or Voronoi('v') with halfspace intersection('H')\n");
qh_errexit(qh, qh_ERRinput, NULL, NULL);
}
if (!qh->DELAUNAY && (qh->UPPERdelaunay || qh->ATinfinity)) {
qh_fprintf(qh, qh->ferr, 6047, "qhull input error: use upper-Delaunay('Qu') or infinity-point('Qz') with Delaunay('d') or Voronoi('v')\n");
qh_errexit(qh, qh_ERRinput, NULL, NULL);
}
if (qh->UPPERdelaunay && qh->ATinfinity) {
qh_fprintf(qh, qh->ferr, 6048, "qhull input error: can not use infinity-point('Qz') with upper-Delaunay('Qu')\n");
qh_errexit(qh, qh_ERRinput, NULL, NULL);
}
if (qh->SCALElast && !qh->DELAUNAY && qh->PRINTprecision)
qh_fprintf(qh, qh->ferr, 7040, "qhull input warning: option 'Qbb' (scale-last-coordinate) is normally used with 'd' or 'v'\n");
else if (qh->PRINTout[i] == qh_PRINTmathematica || qh->PRINTout[i] == qh_PRINTmaple)
printmath= True;
else if (qh->PRINTout[i] == qh_PRINTcoplanars)
printcoplanar= True;
else if (qh->PRINTout[i] == qh_PRINTpointnearest)
printcoplanar= True;
else if (qh->PRINTout[i] == qh_PRINTpointintersect && !qh->HALFspace) {
qh_fprintf(qh, qh->ferr, 6053, "qhull input error: option 'Fp' is only used for \nhalfspace intersection('Hn,n,n').\n");
qh_errexit(qh, qh_ERRinput, NULL, NULL);
}else if (qh->PRINTout[i] == qh_PRINTtriangles && (qh->HALFspace || qh->VORONOI)) {
qh_fprintf(qh, qh->ferr, 6054, "qhull input error: option 'Ft' is not available for Voronoi vertices or halfspace intersection\n");
qh_errexit(qh, qh_ERRinput, NULL, NULL);
}else if (qh->PRINTout[i] == qh_PRINTcentrums && qh->VORONOI) {
qh_fprintf(qh, qh->ferr, 6055, "qhull input error: option 'FC' is not available for Voronoi vertices('v')\n");
qh_errexit(qh, qh_ERRinput, NULL, NULL);
}else if (qh->PRINTout[i] == qh_PRINTvertices) {
if (qh->VORONOI)
qh_option(qh, "Fvoronoi", NULL, NULL);
else
qh_option(qh, "Fvertices", NULL, NULL);
}
}
if (printcoplanar && qh->DELAUNAY && qh->JOGGLEmax < REALmax/2) {
if (qh->PRINTprecision)
qh_fprintf(qh, qh->ferr, 7041, "qhull input warning: 'QJ' (joggle) will usually prevent coincident input sites for options 'Fc' and 'FP'\n");
}
if (printmath && (qh->hull_dim > 3 || qh->VORONOI)) {
qh_fprintf(qh, qh->ferr, 6056, "qhull input error: Mathematica and Maple output is only available for 2-d and 3-d convex hulls and 2-d Delaunay triangulations\n");
qh_errexit(qh, qh_ERRinput, NULL, NULL);
}
if (printgeom) {
if (qh->hull_dim > 4) {
qh_fprintf(qh, qh->ferr, 6057, "qhull input error: Geomview output is only available for 2-d, 3-d and 4-d\n");
qh_errexit(qh, qh_ERRinput, NULL, NULL);
}
if (qh->PRINTnoplanes && !(qh->PRINTcoplanar + qh->PRINTcentrums
+ Report error if library does not agree with caller
+
+ notes:
+ NOerrors -- qh_lib_check can not call qh_errexit()
+*/
+void qh_lib_check(int libraryType, int qhTsize, int vertexTsize, int ridgeTsize, int facetTsize, int setTsize, int qhmemTsize) {
+ boolT iserror= False;
+
+ if (libraryType==0) {
+ qh_fprintf(NULL, stderr, 6257, "qh_lib_check: Incorrect qhull library called. Caller uses non-reentrant Qhull with a static qhT. Library is reentrant.\n");
+ iserror= True;
+ }else if (libraryType==1) {
+ qh_fprintf(NULL, stderr, 6258, "qh_lib_check: Incorrect qhull library called. Caller uses non-reentrant Qhull with a dynamic qhT via qh_QHpointer. Library is reentrant.\n");
+ iserror= True;
+ }
+ if (qhTsize != sizeof(qhT)) {
+ qh_fprintf(NULL, stderr, 6249, "qh_lib_check: Incorrect qhull library called. Size of qhT for caller is %d, but for library is %d.\n", qhTsize, sizeof(qhT));
+ iserror= True;
+ }
+ if (vertexTsize != sizeof(vertexT)) {
+ qh_fprintf(NULL, stderr, 6250, "qh_lib_check: Incorrect qhull library called. Size of vertexT for caller is %d, but for library is %d.\n", vertexTsize, sizeof(vertexT));
+ iserror= True;
+ }
+ if (ridgeTsize != sizeof(ridgeT)) {
+ qh_fprintf(NULL, stderr, 6251, "qh_lib_check: Incorrect qhull library called. Size of ridgeT for caller is %d, but for library is %d.\n", ridgeTsize, sizeof(ridgeT));
+ iserror= True;
+ }
+ if (facetTsize != sizeof(facetT)) {
+ qh_fprintf(NULL, stderr, 6252, "qh_lib_check: Incorrect qhull library called. Size of facetT for caller is %d, but for library is %d.\n", facetTsize, sizeof(facetT));
+ iserror= True;
+ }
+ if (setTsize && setTsize != sizeof(setT)) {
+ qh_fprintf(NULL, stderr, 6253, "qh_lib_check: Incorrect qhull library called. Size of setT for caller is %d, but for library is %d.\n", setTsize, sizeof(setT));
+ iserror= True;
+ }
+ if (qhmemTsize && qhmemTsize != sizeof(qhmemT)) {
+ qh_fprintf(NULL, stderr, 6254, "qh_lib_check: Incorrect qhull library called. Size of qhmemT for caller is %d, but for library is %d.\n", qhmemTsize, sizeof(qhmemT));
if (num != qh->ridgeoutnum || qh->printoutvar != qh->ridgeoutnum) {
qh_fprintf(qh, qh->ferr, 6069, "qhull internal error (qh_printend): number of ridges %d != number printed %d and at end %d\n", qh->ridgeoutnum, qh->printoutvar, num);
qh_fprintf(qh, qh->ferr, 8120, "qh_addpoint: add p%d(v%d) to hull of %d facets(%2.2g above f%d) and %d outside at %4.4g CPU secs. Previous was p%d.\n",
+ qh_fprintf(qh, stderr, 6244, "qh_memcheck: either qh->qhmem is overwritten or qh->qhmem is not initialized. Call qh_mem_new() or qh_new_qhull() before calling qh_mem routines. ferr 0x%x IsTracing %d ALIGNmask 0x%x", qh->qhmem.ferr, qh->qhmem.IStracing, qh->qhmem.ALIGNmask);
+ qh_exit(qhmem_ERRqhull); /* can not use qh_errexit() */
+ }
+ if (qh->qhmem.IStracing != 0)
+ qh_fprintf(qh, qh->qhmem.ferr, 8143, "qh_memcheck: check size of freelists on qh->qhmem\nqh_memcheck: A segmentation fault indicates an overwrite of qh->qhmem\n");
+ for (i=0; i < qh->qhmem.TABLEsize; i++) {
+ count=0;
+ for (object= qh->qhmem.freelists[i]; object; object= *((void **)object))
+ count++;
+ totfree += qh->qhmem.sizetable[i] * count;
+ }
+ if (totfree != qh->qhmem.totfree) {
+ qh_fprintf(qh, qh->qhmem.ferr, 6211, "Qhull internal error (qh_memcheck): totfree %d not equal to freelist total %d\n", qh->qhmem.totfree, totfree);
+ qh_errexit(qh, qhmem_ERRqhull, NULL, NULL);
+ }
+ if (qh->qhmem.IStracing != 0)
+ qh_fprintf(qh, qh->qhmem.ferr, 8144, "qh_memcheck: total size of freelists totfree is the same as qh->qhmem.totfree\n", totfree);
qh_fprintf(qh, qh->ferr, 6096, "qhull internal error (qh_forcedmerges): f%d and f%d had a duplicate ridge but as f%d and f%d they are no longer neighbors\n",
if (facet2 == qh->tracefacet || (qh->tracevertex && qh->tracevertex->newlist)) {
qh_fprintf(qh, qh->ferr, 8085, "qh_tracemerge: trace facet and vertex after merge of f%d and f%d, furthest p%d\n", facet1->id, facet2->id, qh->furthest_id);
FOREACHfacet_i_(qh, facets) { /* for each point with facet assignment */
if (facet)
unassigned= False;
else {
unassigned= True;
facet= qh->facet_list;
}
point= qh_point(qh, facet_i);
if (point == qh->GOODpointp)
continue;
qh_distplane(qh, point, facet, &dist);
numpart++;
bestfacet= qh_findbesthorizon(qh, !qh_IScheckmax, point, facet, qh_NOupper, &dist, &numpart);
/* occurs after statistics reported */
maximize_(maxdist, dist);
if (dist > maxoutside) {
if (qh->ONLYgood && !bestfacet->good
&& !((bestfacet= qh_findgooddist(qh, point, bestfacet, &dist, &facetlist))
&& dist > maxoutside))
notgood++;
else {
waserror= True;
qh_fprintf(qh, qh->ferr, 6109, "qhull precision error: point p%d is outside facet f%d, distance= %6.8g maxoutside= %6.8g\n",
facet_i, bestfacet->id, dist, maxoutside);
if (errfacet1 != bestfacet) {
errfacet2= errfacet1;
errfacet1= bestfacet;
}
}
}else if (unassigned && dist < -qh->MAXcoplanar)
notverified++;
}
qh_settempfree(qh, &facets);
if (notverified && !qh->DELAUNAY && !qh_QUICKhelp && qh->PRINTprecision)
qh_fprintf(qh, qh->ferr, 8092, "\n%d points were well inside the hull. If the hull contains\n\
a lens-shaped component, these points were not verified. Use\n\
options 'Qci Tv' to verify all points.\n", notverified);
if (maxdist > qh->outside_err) {
qh_fprintf(qh, qh->ferr, 6110, "qhull precision error (qh_check_bestdist): a coplanar point is %6.2g from convex hull. The maximum value(qh.outside_err) is %6.2g\n",
qh_fprintf(qh, qh->ferr, 7061, "qhull warning (qh_check_points): missing normal for facet f%d\n", facet->id);
continue;
}
if (testouter) {
#if qh_MAXoutside
maxoutside= facet->maxoutside + 2* qh->DISTround;
/* one DISTround to actual point and another to computed point */
#endif
}
FORALLpoints {
if (point != qh->GOODpointp)
qh_check_point(qh, point, facet, &maxoutside, &maxdist, &errfacet1, &errfacet2);
}
FOREACHpoint_(qh->other_points) {
if (point != qh->GOODpointp)
qh_check_point(qh, point, facet, &maxoutside, &maxdist, &errfacet1, &errfacet2);
}
}
if (maxdist > qh->outside_err) {
qh_fprintf(qh, qh->ferr, 6112, "qhull precision error (qh_check_points): a coplanar point is %6.2g from convex hull. The maximum value(qh.outside_err) is %6.2g\n",
qh_fprintf(qh, qh->ferr, 6122, "qhull internal error (qh_checkfacet): vertices of f%d are not in descending id order at v%d\n", facet->id, vertex->id);
+ if (qh_pointid(qh, vertex->point) == qh_IDunknown) {
qh_fprintf(qh, qh->ferr, 6139, "qhull internal error (qh_checkpolygon): unknown point %p for vertex v%d first_point %p\n",
vertex->point, vertex->id, qh->first_point);
waserror= True;
}
}
}
}
qh->vertex_visit += (unsigned int)numfacets;
if (facetlist == qh->facet_list) {
if (numfacets != qh->num_facets - qh->num_visible) {
qh_fprintf(qh, qh->ferr, 6140, "qhull internal error (qh_checkpolygon): actual number of facets is %d, cumulative facet count is %d - %d visible facets\n",
numfacets, qh->num_facets, qh->num_visible);
waserror= True;
}
qh->vertex_visit++;
if (qh->VERTEXneighbors) {
FORALLvertices {
qh_setcheck(qh, vertex->neighbors, "neighbors for v", vertex->id);
qh_fprintf(qh, qh->ferr, 6151, "qhull input error: 'Qg QVn' (only good vertex) does not work with merging.\nUse 'QJ' to joggle the input or 'Q0' to turn off merging.\n");
if (!qh_checkflipped(qh, facet, NULL, qh_ALL)) {/* due to axis-parallel facet */
trace1((qh, qh->ferr, 1031, "qh_initialhull: initial orientation incorrect. Correct all facets\n"));
facet->flipped= False;
FORALLfacets {
facet->toporient ^= (unsigned char)True;
qh_orientoutside(qh, facet);
}
break;
}
}
FORALLfacets {
if (!qh_checkflipped(qh, facet, NULL, !qh_ALL)) { /* can happen with 'R0.1' */
if (qh->DELAUNAY && ! qh->ATinfinity) {
if (qh->UPPERdelaunay)
qh_fprintf(qh, qh->ferr, 6240, "Qhull input error: Can not compute the upper Delaunay triangulation or upper Voronoi diagram of cocircular/cospherical points.\n");
else
qh_fprintf(qh, qh->ferr, 6239, "Qhull input error: Use option 'Qz' for the Delaunay triangulation or Voronoi diagram of cocircular/cospherical points. Option 'Qz' adds a point \"at infinity\" (above the corresponding paraboloid).\n");
qh_errexit(qh, qh_ERRinput, NULL, NULL);
}
qh_precision(qh, "initial facet is coplanar with interior point");
qh_fprintf(qh, qh->ferr, 6154, "qhull precision error: initial facet %d is coplanar with the interior point\n",
returns size of qh.hash_table of at least newsize slots
notes:
assumes qh.hash_table is NULL
qh_HASHfactor determines the number of extra slots
size is not divisible by 2, 3, or 5
*/
int qh_newhashtable(qhT *qh, int newsize) {
int size;
size= ((newsize+1)*qh_HASHfactor) | 0x1; /* odd number */
while (True) {
if (newsize<0 || size<0) {
qh_fprintf(qh, qh->qhmem.ferr, 6236, "qhull error (qh_newhashtable): negative request (%d) or size (%d). Did int overflow due to high-D?\n", newsize, size); /* WARN64 */
qh_errexit(qh, qhmem_ERRmem, NULL, NULL);
}
if ((size%3) && (size%5))
break;
size += 2;
/* loop terminates because there is an infinite number of primes */
trace4((qh, qh->ferr, 4049, "qh_makenew_simplicial: create facet f%d top %d from v%d and horizon f%d skip %d top %d and visible f%d skip %d, flip? %d\n",
use 'T2' to find source and then find mis-matching qh_settemp
design:
check top of qh->qhmem.tempstack
free it
*/
void qh_settempfree(qhT *qh, setT **set) {
setT *stackedset;
if (!*set)
return;
stackedset= qh_settemppop(qh);
if (stackedset != *set) {
qh_settemppush(qh, stackedset);
qh_fprintf(qh, qh->qhmem.ferr, 6179, "qhull internal error (qh_settempfree): set %p(size %d) was not last temporary allocated(depth %d, set %p, size %d)\n",
throw QhullError(10060, "Qhull error: first point (%x) is not PointCoordinates.data() or count (%d) is not PointCoordinates.count (%d)", coordinateCount(), getCoordinates().count(), 0.0, data());
}
}//checkValid
void PointCoordinates::
setDimension(int i)
{
if(i<0){
throw QhullError(10062, "Qhull error: can not set PointCoordinates dimension to %d", i);
}
int currentDimension=QhullPoints::dimension();
if(currentDimension!=0 && i!=currentDimension){
throw QhullError(10063, "Qhull error: can not change PointCoordinates dimension (from %d to %d)", currentDimension, i);
throw QhullError(10065, "Qhull error: can not append a subset of PointCoordinates to itself. The coordinates for point %d may move.", indexOf(c, QhullError::NOthrow));
-#//! Compile libqhull and Qhull together due to use of setjmp/longjmp()
+#//! Compile libqhull_r and Qhull together due to use of setjmp/longjmp()
#include "QhullError.h"
#include "RboxPoints.h"
#include "QhullQh.h"
#include "QhullFacet.h"
#include "QhullFacetList.h"
#include "Qhull.h"
extern "C" {
- #include "libqhullr/qhull_ra.h"
+ #include "libqhull_r/qhull_ra.h"
}
#include <iostream>
using std::cerr;
using std::string;
using std::vector;
using std::ostream;
#ifdef _MSC_VER // Microsoft Visual C++ -- warning level 4
#pragma warning( disable : 4611) // interaction between '_setjmp' and C++ object destruction is non-portable
#pragma warning( disable : 4996) // function was declared deprecated(strcpy, localtime, etc.)
#endif
namespace orgQhull {
-#//Global variables
+#//!\name Global variables
const char s_unsupported_options[]=" Fd TI ";
const char s_not_output_options[]= " Fd TI A C d E H P Qb QbB Qbb Qc Qf Qg Qi Qm QJ Qr QR Qs Qt Qv Qx Qz Q0 Q1 Q2 Q3 Q4 Q5 Q6 Q7 Q8 Q9 Q10 Q11 R Tc TC TM TP TR Tv TV TW U v V W ";
-#//Constructor, destructor, etc.
+#//!\name Constructor, destructor, etc.
Qhull::
Qhull()
: qh_qh(0)
, origin_point()
, run_called(false)
-, feasiblePoint()
+, feasible_point()
{
allocateQhullQh();
}//Qhull
-//! Invokes Qhull on rboxPoints
+//! Invokes Qhull on rboxPoints
//! Same as runQhull()
//! For rbox commands, see http://www.qhull.org/html/rbox.htm or html/rbox.htm
//! For qhull commands, see http://www.qhull.org/html/qhull.htm or html/qhull.htm
- throw QhullError(10074, "Qhull error: QhullQh at a different address than base type QhT (%d bytes). Please report compiler to qhull.org", (int)(static_cast<qhT *>(qh_qh)-qh_qh));
+ void *p= qh_qh;
+ void *p2= static_cast<qhT *>(qh_qh);
+ char *s= static_cast<char *>(p);
+ char *s2= static_cast<char *>(p2);
+ if(s!=s2){
+ throw QhullError(10074, "Qhull error: QhullQh at a different address than base type QhT (%d bytes). Please report compiler to qhull.org", int(s2-s));
}
}//allocateQhullQh
Qhull::
~Qhull() throw()
{
// Except for cerr, does not throw errors
if(qh_qh->hasQhullMessage()){
cerr<< "\nQhull output at end\n"; //FIXUP QH11005: where should error and log messages go on ~Qhull?
cerr<< qh_qh->qhullMessage();
qh_qh->clearQhullMessage();
}
delete qh_qh;
qh_qh= 0;
}//~Qhull
#//!\name GetSet
void Qhull::
checkIfQhullInitialized()
{
if(!initialized()){ // qh_initqhull_buffers() not called
for(int k= qh_qh->hull_dim; k--; ){ // Do not move into QH_TRY block. It may throw an error
origin_point << 0.0;
}
qh_qh->maybeThrowQhullMessage(QH_TRY_status);
}//runQhull
-#//Helpers -- be careful of allocating C++ objects due to setjmp/longjmp() error handling by qh_... routines
+#//!\name Helpers -- be careful of allocating C++ objects due to setjmp/longjmp() error handling by qh_... routines
+//! initialize qh.feasible_point for half-space intersection
+//! Sets from qh.feasible_string if available, otherwise from Qhull::feasible_point
+//! called only once from runQhull(), otherwise it leaks memory (the same as qh_setFeasible)
void Qhull::
initializeFeasiblePoint(int hulldim)
{
if(qh_qh->feasible_string){
qh_setfeasible(qh_qh, hulldim);
}else{
- if(feasiblePoint.isEmpty()){
- qh_fprintf(qh_qh, qh_qh->ferr, 6209, "qhull error: missing feasible point for halfspace intersection. Use option 'Hn,n' or set qh_qh.feasiblePoint\n");
+ if(feasible_point.isEmpty()){
+ qh_fprintf(qh_qh, qh_qh->ferr, 6209, "qhull error: missing feasible point for halfspace intersection. Use option 'Hn,n' or Qhull::setFeasiblePoint before runQhull()\n");
qh_errexit(qh_qh, qh_ERRmem, NULL, NULL);
}
- if(feasiblePoint.size()!=(size_t)hulldim){
- qh_fprintf(qh_qh, qh_qh->ferr, 6210, "qhull error: dimension of feasiblePoint should be %d. It is %u", hulldim, feasiblePoint.size());
+ if(feasible_point.size()!=(size_t)hulldim){
+ qh_fprintf(qh_qh, qh_qh->ferr, 6210, "qhull error: dimension of feasiblePoint should be %d. It is %u", hulldim, feasible_point.size());
qh_errexit(qh_qh, qh_ERRmem, NULL, NULL);
}
if (!(qh_qh->feasible_point= (coordT*)qh_malloc(hulldim * sizeof(coordT)))) {
qh_fprintf(qh_qh, qh_qh->ferr, 6202, "qhull error: insufficient memory for feasible point\n");
qh_errexit(qh_qh, qh_ERRmem, NULL, NULL);
}
coordT *t= qh_qh->feasible_point;
// No qh_... routines after here -- longjmp() ignores destructor
#ifdef _MSC_VER // Microsoft Visual C++ -- warning level 4
#pragma warning( disable : 4611) /* interaction between '_setjmp' and C++ object destruction is non-portable */
/* setjmp should not be implemented with 'catch' */
#endif
-//! QH_TRY_(qh_qh){ // no object creation -- destructors skipped on longjmp()
-//! }
-//! qh->maybeThrowQhullMessage(QH_TRY_status);
+//! Use QH_TRY_ or QH_TRY_NOTHROW_ to call a libqhull_r routine that may invoke qh_errexit()
+//! QH_TRY_(qh){...} qh->NOerrexit=true;
+//! No object creation -- longjmp() skips object destructors
+//! To test for error when done -- qh->maybeThrowQhullMessage(QH_TRY_status);
+//! Use the same compiler for QH_TRY_, libqhullcpp, and libqhull_r. setjmp() is not portable between compilers.
#define QH_TRY_ERROR 10071
#define QH_TRY_(qh) \
int QH_TRY_status; \
if(qh->NOerrexit){ \
qh->NOerrexit= False; \
QH_TRY_status= setjmp(qh->errexit); \
}else{ \
- throw QhullError(QH_TRY_ERROR, "Already inside a QH_TRY_(). qh.NOerrexit is false"); \
+ throw QhullError(QH_TRY_ERROR, "Cannot invoke QH_TRY_() from inside a QH_TRY_. Or missing 'qh->NOerrexit=true' after previously called QH_TRY_(qh){...}"); \
} \
- if(!QH_TRY_status)
+ if(!QH_TRY_status)
#define QH_TRY_NO_THROW_(qh) \
int QH_TRY_status; \
if(qh->NOerrexit){ \
qh->NOerrexit= False; \
QH_TRY_status= setjmp(qh->errexit); \
}else{ \
QH_TRY_status= QH_TRY_ERROR; \
} \
- if(!QH_TRY_status)
+ if(!QH_TRY_status)
namespace orgQhull {
#//!\name Defined here
//! QhullQh -- Qhull's global data structure, qhT, as a C++ class
class QhullQh;
//! POD type equivalent to qhT. No virtual members
class QhullQh : public qhT {
#//!\name Constants
-#//!\name Fields
+#//!\name Fields
private:
- int qhull_status; //! qh_ERRnone if valid
- std::string qhull_message; //! Returned messages from libqhull_r
- std::ostream * error_stream; //! overrides errorMessage, use appendQhullMessage()
- std::ostream * output_stream; //! send output to stream
+ int qhull_status; //!< qh_ERRnone if valid
+ std::string qhull_message; //!< Returned messages from libqhull_r
+ std::ostream * error_stream; //!< overrides errorMessage, use appendQhullMessage()
+ std::ostream * output_stream; //!< send output to stream
double factor_epsilon; //!< Factor to increase ANGLEround and DISTround for hyperplane equality
+ bool use_output_stream; //!< True if using output_stream
static bool isEmpty(const setT *s) { return SETempty_(s); }
};//QhullSetBase
//! QhullSet<T> -- A read-only wrapper to Qhull's collection class, setT.
//! QhullSet is similar to STL's <vector> and Qt's QVector.
//! QhullSet is unrelated to STL and Qt's set and map types (e.g., QSet and QMap)
//! T is a Qhull type that defines 'base_type' and getBaseT() (e.g., QhullFacet with base_type 'facetT *'
//! A QhullSet does not own its contents -- erase(), clear(), removeFirst(), removeLast(), pop_back(), pop_front(), fromStdList() not defined
//! QhullSetIterator is faster than STL-style iterator/const_iterator
//! Qhull's FOREACHelement_() [qset_r.h] maybe more efficient than QhullSet. It uses a NULL terminator instead of an end pointer. STL requires an end pointer.
//! Derived from QhullLinkedList.h and Qt/core/tools/qvector.h
template <typename T>
class QhullSet : public QhullSetBase {
private:
#//!\name Fields -- see QhullSetBase
#//!\name Class objects
static setT s_empty_set; //! Workaround for no setT allocator. Used if setT* is NULL
#//! QhullVertexSet -- Qhull's linked Vertexs, as a C++ class
#include "QhullVertex.h"
#include "QhullVertexSet.h"
#include "QhullPoint.h"
#include "QhullRidge.h"
#include "QhullVertex.h"
#include "Qhull.h"
-#include "UsingLibQhull.h"
-
using std::string;
using std::vector;
#ifdef _MSC_VER // Microsoft Visual C++ -- warning level 4
#pragma warning( disable : 4611) /* interaction between '_setjmp' and C++ object destruction is non-portable */
/* setjmp should not be implemented with 'catch' */
#endif
namespace orgQhull {
QhullVertexSet::
QhullVertexSet(const Qhull &q, facetT *facetlist, setT *facetset, bool allfacets)
: QhullSet<QhullVertex>(q.qh(), 0)
, qhsettemp_defined(false)
{
QH_TRY_(q.qh()){ // no object creation -- destructors skipped on longjmp()
setT *vertices= qh_facetvertices(q.qh(), facetlist, facetset, allfacets);
defineAs(vertices);
qhsettemp_defined= true;
}
+ q.qh()->NOerrexit= true;
q.qh()->maybeThrowQhullMessage(QH_TRY_status);
}//QhullVertexSet facetlist facetset
+//! Return tempory QhullVertexSet of vertices for a list and/or a set of facets
+//! Sets qhsettemp_defined (disallows copy constructor and assignment to prevent double-free)
QhullVertexSet::
-QhullVertexSet(QhullQh *qh, facetT *facetlist, setT *facetset, bool allfacets)
-: QhullSet<QhullVertex>(qh, 0)
+QhullVertexSet(QhullQh *qqh, facetT *facetlist, setT *facetset, bool allfacets)
+: QhullSet<QhullVertex>(qqh, 0)
, qhsettemp_defined(false)
{
- QH_TRY_(qh){ // no object creation -- destructors skipped on longjmp()
- setT *vertices= qh_facetvertices(qh, facetlist, facetset, allfacets);
+ QH_TRY_(qh()){ // no object creation -- destructors skipped on longjmp()
+ setT *vertices= qh_facetvertices(qh(), facetlist, facetset, allfacets);
defineAs(vertices);
qhsettemp_defined= true;
}
- qh->maybeThrowQhullMessage(QH_TRY_status);
+ qh()->NOerrexit= true;
+ qh()->maybeThrowQhullMessage(QH_TRY_status);
}//QhullVertexSet facetlist facetset
//! Copy constructor for argument passing and returning a result
//! Only copies a pointer to the set.
-//! If qhsettemp_defined, transfers ownership to destination, otherwise the set will be freed twice
-//! If qhsettemp_defined and passed by value, the set will be empty on return to caller
+//! Throws an error if qhsettemp_defined, otherwise have a double-free
+//!\todo Convert QhullVertexSet to a shared pointer with reference counting
QhullVertexSet::
-QhullVertexSet(QhullVertexSet &other)
+QhullVertexSet(const QhullVertexSet &other)
: QhullSet<QhullVertex>(other)
-, qhsettemp_defined(other.qhsettemp_defined)
+, qhsettemp_defined(false)
{
- other.qhsettemp_defined= false;
- other.forceEmpty();
+ if(other.qhsettemp_defined){
+ throw QhullError(10077, "QhullVertexSet: Cannot use copy constructor since qhsettemp_defined (e.g., QhullVertexSet for a set and/or list of QhFacet). Contains %d vertices", other.count());
+ }
}//copy constructor
//! Copy assignment only copies a pointer to the set.
-//! If qhsettemp_defined, transfers ownership to destination, otherwise the set will be freed twice
-//! If qhsettemp_defined and passed by value, the set will be empty on return to caller
-//! 'other' is not 'const' due to ownership transfer
+//! Throws an error if qhsettemp_defined, otherwise have a double-free
QhullVertexSet & QhullVertexSet::
-operator=(QhullVertexSet &other)
+operator=(const QhullVertexSet &other)
{
QhullSet<QhullVertex>::operator=(other);
- qhsettemp_defined= other.qhsettemp_defined;
- other.qhsettemp_defined= false;
- other.forceEmpty();
+ qhsettemp_defined= false;
+ if(other.qhsettemp_defined){
+ throw QhullError(10078, "QhullVertexSet: Cannot use copy constructor since qhsettemp_defined (e.g., QhullVertexSet for a set and/or list of QhFacet). Contains %d vertices", other.count());
+ }
return *this;
}//copy constructor
void QhullVertexSet::
freeQhSetTemp()
{
if(qhsettemp_defined){
qhsettemp_defined= false;
QH_TRY_(qh()){ // no object creation -- destructors skipped on longjmp()
qh_settempfree(qh(), referenceSetT()); // errors if not top of tempstack or if qhmem corrupted
//! See discussion in Saylan, G., "Practical C++ error handling in hybrid environments," Dr. Dobb's Journal, p. 50-55, March 2007.
//! He uses an auto_ptr to track a stringstream. It constructs a string on the fly. RoadError uses the copy constructor to transform RoadLogEvent into a string
class RoadError;
class RoadError : public std::exception {
private:
#//!\name Fields
int error_code; //! Non-zero code (not logged), maybe returned as program status
RoadLogEvent log_event; //! Format string w/ arguments
mutable std::string error_message; //! Formated error message. Must be after log_event.
#//!\name Class fields
static const char * ROADtag;
- static std::ostringstream global_log; //! May be replaced with any ostream object
+ static std::ostringstream global_log; //!< May be replaced with any ostream object
+ //!< Not reentrant -- only used by RoadError::logErrorLastResort()
public:
#//!\name Constants
#//!\name Constructors
RoadError();
RoadError(const RoadError &other); //! Called on throw, generates error_message
RoadError(int code, const std::string &message);
RoadError(int code, const char *fmt);
RoadError(int code, const char *fmt, int d);
RoadError(int code, const char *fmt, int d, int d2);
RoadError(int code, const char *fmt, int d, int d2, float f);
RoadError(int code, const char *fmt, int d, int d2, float f, const char *s);
RoadError(int code, const char *fmt, int d, int d2, float f, const void *x);
RoadError(int code, const char *fmt, int d, int d2, float f, int i);
RoadError(int code, const char *fmt, int d, int d2, float f, long long i);
RoadError(int code, const char *fmt, int d, int d2, float f, double e);
- throw QhullError(10060, "Qhull error: first point (%x) is not PointCoordinates.data() or count (%d) is not PointCoordinates.count (%d)", coordinateCount(), getCoordinates().count(), 0.0, data());
- }
-}//checkValid
-
-void PointCoordinates::
-setDimension(int i)
-{
- if(i<0){
- throw QhullError(10062, "Qhull error: can not set PointCoordinates dimension to %d", i);
- }
- int currentDimension=QhullPoints::dimension();
- if(currentDimension!=0 && i!=currentDimension){
- throw QhullError(10063, "Qhull error: can not change PointCoordinates dimension (from %d to %d)", currentDimension, i);
- throw QhullError(10065, "Qhull error: can not append a subset of PointCoordinates to itself. The coordinates for point %d may move.", indexOf(c, QhullError::NOthrow));
-#//! Compile libqhull and Qhull together due to use of setjmp/longjmp()
-
-#include "QhullError.h"
-#include "UsingLibQhull.h"
-#include "RboxPoints.h"
-#include "QhullQh.h"
-#include "QhullFacet.h"
-#include "QhullFacetList.h"
-#include "Qhull.h"
-extern "C" {
- #include "libqhull/qhull_a.h"
-}
-
-#include <iostream>
-
-using std::cerr;
-using std::string;
-using std::vector;
-using std::ostream;
-
-#ifdef _MSC_VER // Microsoft Visual C++ -- warning level 4
-#pragma warning( disable : 4611) // interaction between '_setjmp' and C++ object destruction is non-portable
-#pragma warning( disable : 4996) // function was declared deprecated(strcpy, localtime, etc.)
-#endif
-
-namespace orgQhull {
-
-#//Global variables
-
-char s_unsupported_options[]=" Fd TI ";
-char s_not_output_options[]= " Fd TI A C d E H P Qb QbB Qbb Qc Qf Qg Qi Qm QJ Qr QR Qs Qt Qv Qx Qz Q0 Q1 Q2 Q3 Q4 Q5 Q6 Q7 Q8 Q9 Q10 Q11 R Tc TC TM TP TR Tv TV TW U v V W ";
-std::ostream &operator<<(std::ostream &os, const orgQhull::QhullPoint &p); // FIXUP QH11017 OK in c program but not inline { os << p.print(orgQhull::UsingLibQhull::NOqhRunId, ""); return os; }
- class QhullSetBase; //! Base class for QhullSet<T>
- //! QhullSet<T> -- A read-only wrapper to Qhull's collection class, setT.
- //! QhullSet is similar to STL's <vector> and Qt's QVector.
- //! QhullSet is unrelated to STL and Qt's set and map types (e.g., QSet and QMap)
- //! For STL efficiency, QhullSet caches endPointer()
- //! T must be a pointer type
- //! A QhullSet does not own its contents -- erase(), clear(), removeFirst(), removeLast(), pop_back(), pop_front(), fromStdList() not defined
- //! Qhull's FOREACHelement_() [qset.h] is more efficient than QhullSet. It uses a NULL terminator instead of an end pointer. STL requires an end pointer.
- //! Derived from QhullLinkedList.h and Qt/core/tools/qvector.h
-
- //! QhullSetIterator<T> defined below
- //See: QhullPointSet, QhullLinkedList<T>
-
-class QhullSetBase {
-
-private:
-#//!\name Fields --
- setT * qh_set;
-
-#//!\name Class objects
- static setT s_empty_set; //! Workaround for no setT allocator. Used if setT* is NULL
-
-public:
-#//!\name Class methods
- static int count(const setT *set);
- //s may be null
- static bool isEmpty(const setT *s) { return SETempty_(s); }
-
-
-#//!\name Constructors
- //! Copy constructor copies the pointer but not the set. Needed for return by value and parameter passing.
-#ifdef _MSC_VER // Microsoft Visual C++ -- warning level 4
-#pragma warning( disable : 4996) // function was declared deprecated(strcpy, localtime, etc.)
-#endif
-
-namespace orgQhull {
-
-#//! RboxPoints -- generate random PointCoordinates for qhull (rbox)
-
-#//Global
-
-//! pointer to RboxPoints for qh_fprintf callback
-RboxPoints *rbox_output= 0;
-
-#//Construct
-RboxPoints::
-RboxPoints()
-: PointCoordinates("rbox")
-, rbox_new_count(0)
-, rbox_status(qh_ERRnone)
-, rbox_message()
-{}
-
-RboxPoints::
-RboxPoints(const char *rboxCommand)
-: PointCoordinates("rbox ")
-, rbox_new_count(0)
-, rbox_status(qh_ERRnone)
-, rbox_message()
-{
- std::string s= comment() + rboxCommand;
- setComment(s);
- appendPoints(rboxCommand);
-}
-
-RboxPoints::
-RboxPoints(const RboxPoints &other)
-: PointCoordinates(other)
-, rbox_new_count(0)
-, rbox_status(other.rbox_status)
-, rbox_message(other.rbox_message)
-{}
-
-RboxPoints & RboxPoints::
-operator=(const RboxPoints &other)
-{
- PointCoordinates::operator=(other);
- rbox_new_count= other.rbox_new_count;
- rbox_status= other.rbox_status;
- rbox_message= other.rbox_message;
- return *this;
-}//operator=
-
-
-RboxPoints::
-~RboxPoints()
-{}
-
-#//Error
-
-void RboxPoints::
-clearRboxMessage()
-{
- rbox_status= qh_ERRnone;
- rbox_message.clear();
-}//clearRboxMessage
-
-std::string RboxPoints::
-rboxMessage() const
-{
- if(rbox_status!=qh_ERRnone){
- return rbox_message;
- }
- if(isEmpty()){
- return "rbox warning: no points generated\n";
- }
- return "rbox: OK\n";
-}//rboxMessage
-
-int RboxPoints::
-rboxStatus() const
-{
- return rbox_status;
-}
-
-bool RboxPoints::
-hasRboxMessage() const
-{
- return (rbox_status!=qh_ERRnone);
-}
-
-#//Modify
-
-void RboxPoints::
-appendPoints(const char *rboxCommand)
-{
- string s("rbox ");
- s += rboxCommand;
- char *command= const_cast<char*>(s.c_str());
- if(rbox_output){
- throw QhullError(10001, "Qhull error: Two simultaneous calls to RboxPoints::appendPoints(). Prevent two processes calling appendPoints() at the same time. Other RboxPoints '%s'", 0, 0, 0, rbox_output->comment().c_str());
- }
- if(extraCoordinatesCount()!=0){
- throw QhullError(10067, "Qhull error: Extra coordinates (%d) prior to calling RboxPoints::appendPoints. Was %s", extraCoordinatesCount(), 0, 0.0, comment().c_str());
- }
- int previousCount= count();
- rbox_output= this; // set rbox_output for qh_fprintf()
- int status= ::qh_rboxpoints(0, 0, command);
- rbox_output= 0;
- if(rbox_status==qh_ERRnone){
- rbox_status= status;
- }
- if(rbox_status!=qh_ERRnone){
- throw QhullError(rbox_status, rbox_message);
- }
- if(extraCoordinatesCount()!=0){
- throw QhullError(10002, "Qhull error: extra coordinates (%d) for PointCoordinates (%x)", extraCoordinatesCount(), 0, 0.0, coordinates());
- }
- if(previousCount+newCount()!=count()){
- throw QhullError(10068, "Qhull error: rbox specified %d points but got %d points for command '%s'", newCount(), count()-previousCount, 0.0, comment().c_str());
- //! See discussion in Saylan, G., "Practical C++ error handling in hybrid environments," Dr. Dobb's Journal, p. 50-55, March 2007.
- //! He uses an auto_ptr to track a stringstream. It constructs a string on the fly. RoadError uses the copy constructor to transform RoadLogEvent into a string
- class RoadError;
-
-class RoadError : public std::exception {
-
-private:
-#//!\name Fields
- int error_code; //! Non-zero code (not logged), maybe returned as program status
- RoadLogEvent log_event; //! Format string w/ arguments
- mutable std::string error_message; //! Formated error message. Must be after log_event.
-
-#//!\name Class fields
- static const char * ROADtag;
- static std::ostringstream global_log; //! May be replaced with any ostream object
-
-public:
-#//!\name Constants
-
-#//!\name Constructors
- RoadError();
- RoadError(const RoadError &other); //! Called on throw, generates error_message
- QhullError e= checkRunId(); // Check for qhRunId after libqhull returns. For convenience, ought to be at end of libqhull try block
- if(e.isDefined()){
- e.logError();
- }
-}//maybeThrowQhullMessage
-
-#//Helpers
-
-//! Return QhullError for maybeThrowFromDestructor()
-QhullError UsingLibQhull::
-checkRunId() const
-{
- // Predeclaring QhullError results in four copy constructors, none used here
-#if qh_QHpointer
- if(qh_qh){ // 0 if ~Qhull
- if(my_qhull->qhull_run_id!=qh run_id){
- return QhullError(10047, "Qhull internal error: Global state (qh_qh, run_id %d) changed. Should be runId %d. Another thread?", qh run_id, my_qhull->qhull_run_id);
- return QhullError(10048, "Qhull internal error: Global state (qh_qh, run_id %d) changed. Should be runId %d. Another thread?", qh run_id, my_qhull->qhull_run_id);
- }
-#endif
- return QhullError();
-}//checkRunId
-
-//! Can not embed UsingLibQhull. Otherwise allocated a C++ object missed by qh_errexit
-void UsingLibQhull::
-checkUsingLibQhull() const
-{
- if(s_using_libqhull){
- if(s_qhull_output){
- throw QhullError(10049, "Qhull error: UsingLibQhull already in use by QhullQh.runId %d", s_qhull_output->qhull_run_id);
- }else{
- throw QhullError(10050, "Qhull error: UsingLibQhull already in use. No s_qhull_output");
- // ps2= q.otherPoints(); //disabled, would not copy the points
- QCOMPARE(q.facetCount(), 6);
- QCOMPARE(q.vertexCount(), 8);
- coordT *c= q.pointCoordinateBegin(); // of q.points()
- QVERIFY(*c==0.5 || *c==-0.5);
- coordT *c3= q.pointCoordinateEnd();
- QVERIFY(c3[-1]==0.5 || c3[-1]==-0.5);
- QCOMPARE(c3-c, 8*3);
- QCOMPARE(q.vertexList().count(), 8);
- }
-}//t_foreach
-
-void Qhull_test::
-t_modify()
-{
- //addPoint() tested in t_foreach
- RboxPoints diamond("d");
- Qhull q(diamond, "o");
- q.setOutputStream(&cout);
- cout << "Expecting vertexList and facetList of a 3-d diamond.\n";
- q.outputQhull();
- cout << "Expecting normals of a 3-d diamond.\n";
- q.outputQhull("n");
- // runQhull tested in t_attribute(), t_message(), etc.
-}//t_modify
-
-}//orgQhull
-
-// Redefine Qhull's usermem.c
-void qh_exit(int exitcode) {
- cout << "FAIL! : Qhull called qh_exit(). Qhull's error handling not available.\n.. See the corresponding Qhull:qhull_message or setErrorStream().\n";
- fprintf(stderr, "qhull internal warning (main): could not change stdio to fully buffered.\n");
- argc= ccommand(&argv);
-#endif
+ QHULL_LIB_CHECK_RBOX
if (argc == 1) {
printf(prompt, qh_DEFAULTbox, qh_DEFAULTzbox);
return 1;
}
+ if (argc == 2 && strcmp(argv[1], "D4")==0)
+ fprintf(stderr, "\nStarting the rbox smoketest for qhull. An immediate failure indicates\nthat non-reentrant rbox was linked to reentrant routines. An immediate\nfailure of qhull may indicate that qhull was linked to the wrong\nqhull library. Also try 'rbox D4 | qhull T1'\n");
rbox program for generating input points for qhull.
notes:
50 points generated for 'rbox D4'
*/
-#include "libqhull_r.h"
+#include "libqhull_r/libqhull_r.h"
#include <stdarg.h>
#include <stdio.h>
#include <stdlib.h>
+#include <string.h>
#ifdef _MSC_VER /* Microsoft Visual C++ -- warning level 4 */
#pragma warning( disable : 4706) /* assignment within conditional function */
#endif
char prompt[]= "\n\
-rbox- generate various point distributions. Default is random in cube.\n\
\n\
-args (any order, space separated): Version: 2001/06/24\n\
+args (any order, space separated): Version: 2015/08/30 r\n\
3000 number of random points in cube, lens, spiral, sphere or grid\n\
D3 dimension 3-d\n\
c add a unit cube to the output ('c G2.0' sets size)\n\
d add a unit diamond to the output ('d G2.0' sets size)\n\
l generate a regular 3-d spiral\n\
r generate a regular polygon, ('r s Z1 G0.1' makes a cone)\n\
s generate cospherical points\n\
x generate random points in simplex, may use 'r' or 'Wn'\n\
y same as 'x', plus simplex\n\
Pn,m,r add point [n,m,r] first, pads with 0\n\
\n\
Ln lens distribution of radius n. Also 's', 'r', 'G', 'W'.\n\
Mn,m,r lattice(Mesh) rotated by [n,-m,0], [m,n,0], [0,0,r], ...\n\
'27 M1,0,1' is {0,1,2} x {0,1,2} x {0,1,2}. Try 'M3,4 z'.\n\
W0.1 random distribution within 0.1 of the cube's or sphere's surface\n\
Z0.5 s random points in a 0.5 disk projected to a sphere\n\
Z0.5 s G0.6 same as Z0.5 within a 0.6 gap\n\
\n\
Bn bounding box coordinates, default %2.2g\n\
h output as homogeneous coordinates for cdd\n\
n remove command line from the first line of output\n\
On offset coordinates by n\n\
t use time as the random number seed(default is command line)\n\
tn use n as the random number seed\n\
z print integer coordinates, default 'Bn' is %2.2g\n\
";
/*--------------------------------------------
-rbox- main procedure of rbox application
*/
int main(int argc, char **argv) {
int return_status;
qhT qh_qh;
qhT *qh= &qh_qh;
+ QHULL_LIB_CHECK_RBOX
+
if (argc == 1) {
printf(prompt, qh_DEFAULTbox, qh_DEFAULTzbox);
return 1;
}
+ if (argc == 2 && strcmp(argv[1], "D4")==0)
+ fprintf(stderr, "\nStarting the rbox smoketest for qhull. An immediate failure indicates\nthat reentrant rbox was linked to non-reentrant routines. An immediate\nfailure of qhull may indicate that qhull was linked to the wrong\nqhull library. Also try 'rbox D4 | qhull T1'\n");
qh_fprintf(qh, stderr, 6309, "%s: SETaddr_(set, i2t) [%p] is not the same as SETfirst_(set) [%p]\n", name, SETaddr_(set, i2T), SETfirst_(set));
error_count++;
}
first= *(int *)SETfirst_(set);
if(SETfirst_(set)!=SETfirstt_(set, i2T)){
qh_fprintf(qh, stderr, 6308, "%s: SETfirst_(set) [%p] is not the same as SETfirstt_(set, i2T [%p]\n", name, SETfirst_(set), SETfirstt_(set, i2T));
error_count++;
}
if(qh_setsize(qh, set)>1){
second= *(int *)SETsecond_(set);
if(SETsecond_(set)!=SETsecondt_(set, i2T)){
qh_fprintf(qh, stderr, 6310, "%s: SETsecond_(set) [%p] is not the same as SETsecondt_(set, i2T) [%p]\n", name, SETsecond_(set), SETsecondt_(set, i2T));
error_count++;
}
}
}
/* Test first run of ints in set*/
i= 0;
FOREACHint_(set){
if(i2!=SETfirst_(set) && *i2!=prev+1){
break;
}
prev= *i2;
if(SETindex_(set, i2)!=i){
qh_fprintf(qh, stderr, 6311, "%s: Expecting SETindex_(set, pointer-to-%d) to be %d. Got %d\n", name, *i2, i, SETindex_(set, i2));
error_count++;;
}
if(i2!=SETref_(i2)){
qh_fprintf(qh, stderr, 6312, "%s: SETref_(i2) [%p] does not point to i2 (the %d'th element)\n", name, SETref_(i2), i);
error_count++;;
}
i++;
}
FOREACHint_i_(qh, set){
/* Must be first conditional, otherwise it trips up msvc 8 */
i2T **p= SETelemaddr_(set, i2_i, i2T);
if(i2!=*p){
qh_fprintf(qh, stderr, 6320, "%s: SETelemaddr_(set, %d, i2T) [%p] does not point to i2\n", name, i2_i, SETelemaddr_(set, i2_i, int));
error_count++;;
}
if(i2_i==0){
if(first!=*i2){
qh_fprintf(qh, stderr, 6314, "%s: First element is %d instead of SETfirst %d\n", name, *i2, first);
error_count++;;
}
if(rangeA!=*i2){
qh_fprintf(qh, stderr, 6315, "%s: starts with %d instead of rangeA %d\n", name, *i2, rangeA);
error_count++;;
}
prev= rangeA;
}else{
if(i2_i==1 && second!=*i2){
qh_fprintf(qh, stderr, 6316, "%s: Second element is %d instead of SETsecond %d\n", name, *i2, second);
error_count++;;
}
if(prev+1==*i2){
prev++;
}else{
if(*i2==rangeB){
prev= rangeB;
rangeB= -1;
rangeCount++;
}else if(rangeB==-1 && *i2==rangeC){
prev= rangeC;
rangeC= -1;
rangeCount++;
}else{
prev++;
qh_fprintf(qh, stderr, 6317, "%s: Expecting %d'th element to be %d. Got %d\n", name, i2_i, prev, *i2);
error_count++;
}
}
}
if(i2!=SETelem_(set, i2_i)){
qh_fprintf(qh, stderr, 6318, "%s: SETelem_(set, %d) [%p] is not i2 [%p] (the %d'th element)\n", name, i2_i, SETelem_(set, i2_i), i2, i2_i);
error_count++;;
}
if(SETelemt_(set, i2_i, i2T)!=SETelem_(set, i2_i)){ /* Normally SETelemt_ is used for generic sets */
qh_fprintf(qh, stderr, 6319, "%s: SETelemt_(set, %d, i2T) [%p] is not SETelem_(set, %d) [%p] (the %d'th element)\n", name, i2_i, SETelemt_(set, i2_i, int), i2_i, SETelem_(set, i2_i), i2_i);
error_count++;;
}
}
if(error_count>=MAXerrorCount){
qh_fprintf(qh, stderr, 8011, "testqset: Stop testing after %d errors\n", error_count);