Homec4science

Make buildWhereClause() a method of AphrontCursorPagedPolicyAwareQuery

Authored by epriestley <git@epriestley.com> on Apr 18 2015, 16:08.

Description

Make buildWhereClause() a method of AphrontCursorPagedPolicyAwareQuery

Summary:
Ref T4100. Ref T5595.

To support a unified "Projects:" query across all applications, a future diff is going to add a set of "Edge Logic" capabilities to PolicyAwareQuery which write the required SELECT, JOIN, WHERE, HAVING and GROUP clauses for you.

With the addition of "Edge Logic", we'll have three systems which may need to build components of query claues: ordering/paging, customfields/applicationsearch, and edge logic.

For most clauses, queries don't currently call into the parent explicitly to get default components. I want to move more query construction logic up the class tree so it can be shared.

For most methods, this isn't a problem, but many subclasses define a buildWhereClause(). Make all such definitions protected and consistent.

This causes no behavioral changes.

Test Plan: Ran arc unit --everything, which does a pretty through job of verifying this statically.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: yelirekim, hach-que, epriestley

Maniphest Tasks: T4100, T5595

Differential Revision: https://secure.phabricator.com/D12453

Details

Committed
epriestley <git@epriestley.com>Apr 20 2015, 19:06
Pushed
aubortJan 31 2017, 17:16
Parents
rPH01c99335fdd7: Give Phortune carts a proper `isInvoice` flag
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPHf5580c7a083e: Make buildWhereClause() a method of AphrontCursorPagedPolicyAwareQuery (authored by epriestley <git@epriestley.com>).Apr 20 2015, 19:06