Diffusion Phabricator (feature/testing) Browse

testing

DifferentialRevisionQuery.php
View Options

			<?php

			/*
			* Copyright 2012 Facebook, Inc.
			*
			* Licensed under the Apache License, Version 2.0 (the "License");
			* you may not use this file except in compliance with the License.
			* You may obtain a copy of the License at
			*
			* http://www.apache.org/licenses/LICENSE-2.0
			*
			* Unless required by applicable law or agreed to in writing, software
			* distributed under the License is distributed on an "AS IS" BASIS,
			* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
			* See the License for the specific language governing permissions and
			* limitations under the License.
			*/

			/**
			* Flexible query API for Differential revisions. Example:
			*
			* // Load open revisions
			* $revisions = id(new DifferentialRevisionQuery())
			* ->withStatus(DifferentialRevisionQuery::STATUS_OPEN)
			* ->execute();
			*
			* @task config Query Configuration
			* @task exec Query Execution
			* @task internal Internals
			*/
			final class DifferentialRevisionQuery {

			// TODO: Replace DifferentialRevisionListData with this class.

			private $pathIDs = array();

			private $status = 'status-any';
			const STATUS_ANY = 'status-any';
			const STATUS_OPEN = 'status-open';
			const STATUS_ACCEPTED = 'status-accepted';
			const STATUS_COMMITTED = 'status-committed';
			const STATUS_ABANDONED = 'status-abandoned';

			private $authors = array();
			private $ccs = array();
			private $reviewers = array();
			private $revIDs = array();
			private $commitHashes = array();
			private $phids = array();
			private $subscribers = array();
			private $responsibles = array();
			private $branches = array();

			private $order = 'order-modified';
			const ORDER_MODIFIED = 'order-modified';
			const ORDER_CREATED = 'order-created';
			/**
			* This is essentially a denormalized copy of the revision modified time that
			* should perform better for path queries with a LIMIT. Critically, when you
			* browse "/", every revision in that repository for all time will match so
			* the query benefits from being able to stop before fully materializing the
			* result set.
			*/
			const ORDER_PATH_MODIFIED = 'order-path-modified';

			private $limit = 1000;
			private $offset = 0;

			private $needRelationships = false;
			private $needActiveDiffs = false;
			private $needDiffIDs = false;
			private $needCommitPHIDs = false;


			/* -( Query Configuration )------------------------------------------------ */


			/**
			* Filter results to revisions which affect a Diffusion path ID in a given
			* repository. You can call this multiple times to select revisions for
			* several paths.
			*
			* @param int Diffusion repository ID.
			* @param int Diffusion path ID.
			* @return this
			* @task config
			*/
			public function withPath($repository_id, $path_id) {
			$this->pathIDs[] = array(
			'repositoryID' => $repository_id,
			'pathID' => $path_id,
			);
			return $this;
			}

			/**
			* Filter results to revisions authored by one of the given PHIDs. Calling
			* this function will clear anything set by previous calls to
			* @{method:withAuthors}.
			*
			* @param array List of PHIDs of authors
			* @return this
			* @task config
			*/
			public function withAuthors(array $author_phids) {
			$this->authors = $author_phids;
			return $this;
			}

			/**
			* Filter results to revisions which CC one of the listed people. Calling this
			* function will clear anything set by previous calls to @{method:withCCs}.
			*
			* @param array List of PHIDs of subscribers
			* @return this
			* @task config
			*/
			public function withCCs(array $cc_phids) {
			$this->ccs = $cc_phids;
			return $this;
			}

			/**
			* Filter results to revisions that have one of the provided PHIDs as
			* reviewers. Calling this function will clear anything set by previous calls
			* to @{method:withReviewers}.
			*
			* @param array List of PHIDs of reviewers
			* @return this
			* @task config
			*/
			public function withReviewers(array $reviewer_phids) {
			$this->reviewers = $reviewer_phids;
			return $this;
			}

			/**
			* Filter results to revisions that have one of the provided commit hashes.
			* Calling this function will clear anything set by previous calls to
			* @{method:withCommitHashes}.
			*
			* @param array List of pairs <Class
			* ArcanistDifferentialRevisionHash::HASH_$type constant,
			* hash>
			* @return this
			* @task config
			*/
			public function withCommitHashes(array $commit_hashes) {
			$this->commitHashes = $commit_hashes;
			return $this;
			}

			/**
			* Filter results to revisions with a given status. Provide a class constant,
			* such as ##DifferentialRevisionQuery::STATUS_OPEN##.
			*
			* @param const Class STATUS constant, like STATUS_OPEN.
			* @return this
			* @task config
			*/
			public function withStatus($status_constant) {
			$this->status = $status_constant;
			return $this;
			}


			/**
			* Filter results to revisions on given branches.
			*
			* @param list List of branch names.
			* @return this
			* @task config
			*/
			public function withBranches(array $branches) {
			$this->branches = $branches;
			return $this;
			}


			/**
			* Filter results to only return revisions whose ids are in the given set.
			*
			* @param array List of revision ids
			* @return this
			* @task config
			*/
			public function withIDs(array $ids) {
			$this->revIDs = $ids;
			return $this;
			}


			/**
			* Filter results to only return revisions whose PHIDs are in the given set.
			*
			* @param array List of revision PHIDs
			* @return this
			* @task config
			*/
			public function withPHIDs(array $phids) {
			$this->phids = $phids;
			return $this;
			}


			/**
			* Given a set of users, filter results to return only revisions they are
			* responsible for (i.e., they are either authors or reviewers).
			*
			* @param array List of user PHIDs.
			* @return this
			* @task config
			*/
			public function withResponsibleUsers(array $responsible_phids) {
			$this->responsibles = $responsible_phids;
			return $this;
			}


			/**
			* Filter results to only return revisions with a given set of subscribers
			* (i.e., they are authors, reviewers or CC'd).
			*
			* @param array List of user PHIDs.
			* @return this
			* @task config
			*/
			public function withSubscribers(array $subscriber_phids) {
			$this->subscribers = $subscriber_phids;
			return $this;
			}


			/**
			* Set result ordering. Provide a class constant, such as
			* ##DifferentialRevisionQuery::ORDER_CREATED##.
			*
			* @task config
			*/
			public function setOrder($order_constant) {
			$this->order = $order_constant;
			return $this;
			}


			/**
			* Set result limit. If unspecified, defaults to 1000.
			*
			* @param int Result limit.
			* @return this
			* @task config
			*/
			public function setLimit($limit) {
			$this->limit = $limit;
			return $this;
			}


			/**
			* Set result offset. If unspecified, defaults to 0.
			*
			* @param int Result offset.
			* @return this
			* @task config
			*/
			public function setOffset($offset) {
			$this->offset = $offset;
			return $this;
			}


			/**
			* Set whether or not the query will load and attach relationships.
			*
			* @param bool True to load and attach relationships.
			* @return this
			* @task config
			*/
			public function needRelationships($need_relationships) {
			$this->needRelationships = $need_relationships;
			return $this;
			}


			/**
			* Set whether or not the query should load the active diff for each
			* revision.
			*
			* @param bool True to load and attach diffs.
			* @return this
			* @task config
			*/
			public function needActiveDiffs($need_active_diffs) {
			$this->needActiveDiffs = $need_active_diffs;
			return $this;
			}


			/**
			* Set whether or not the query should load the associated commit PHIDs for
			* each revision.
			*
			* @param bool True to load and attach diffs.
			* @return this
			* @task config
			*/
			public function needCommitPHIDs($need_commit_phids) {
			$this->needCommitPHIDs = $need_commit_phids;
			return $this;
			}


			/**
			* Set whether or not the query should load associated diff IDs for each
			* revision.
			*
			* @param bool True to load and attach diff IDs.
			* @return this
			* @task config
			*/
			public function needDiffIDs($need_diff_ids) {
			$this->needDiffIDs = $need_diff_ids;
			return $this;
			}


			/* -( Query Execution )---------------------------------------------------- */


			/**
			* Execute the query as configured, returning matching
			* @{class:DifferentialRevision} objects.
			*
			* @return list List of matching DifferentialRevision objects.
			* @task exec
			*/
			public function execute() {
			$table = new DifferentialRevision();
			$conn_r = $table->establishConnection('r');

			if ($this->shouldUseResponsibleFastPath()) {
			$data = $this->loadDataUsingResponsibleFastPath();
			} else {
			$data = $this->loadData();
			}

			$revisions = $table->loadAllFromArray($data);

			if ($revisions) {
			if ($this->needRelationships) {
			$this->loadRelationships($conn_r, $revisions);
			}

			if ($this->needCommitPHIDs) {
			$this->loadCommitPHIDs($conn_r, $revisions);
			}

			$need_active = $this->needActiveDiffs \|\|
			$this->branches;

			$need_ids = $need_active \|\|
			$this->needDiffIDs;


			if ($need_ids) {
			$this->loadDiffIDs($conn_r, $revisions);
			}

			if ($need_active) {
			$this->loadActiveDiffs($conn_r, $revisions);
			}

			if ($this->branches) {

			// TODO: We could filter this in SQL instead and might get better
			// performance in some cases.

			$branch_map = array_fill_keys($this->branches, true);
			foreach ($revisions as $key => $revision) {
			$diff = $revision->getActiveDiff();
			if (!$diff) {
			unset($revisions[$key]);
			continue;
			}

			// TODO: Old arc uploaded the wrong branch name for Mercurial (i.e.,
			// with a trailing "\n"). Once the arc version gets bumped, do a
			// migration and remove this.
			$branch = trim($diff->getBranch());

			if (!$diff \|\| empty($branch_map[$branch])) {
			unset($revisions[$key]);
			continue;
			}
			}
			}
			}

			return $revisions;
			}


			/**
			* Determine if we should execute an optimized, fast-path query to fetch
			* open revisions for one responsible user. This is used by the Differential
			* dashboard and much faster when executed as a UNION ALL than with JOIN
			* and WHERE, which is why we special case it.
			*/
			private function shouldUseResponsibleFastPath() {
			if ((count($this->responsibles) == 1) &&
			($this->status == self::STATUS_OPEN) &&
			($this->order == self::ORDER_MODIFIED) &&
			!$this->offset &&
			!$this->limit &&
			!$this->subscribers &&
			!$this->reviewers &&
			!$this->ccs &&
			!$this->authors &&
			!$this->revIDs &&
			!$this->commitHashes &&
			!$this->phids) {
			return true;
			}
			return false;
			}


			private function loadDataUsingResponsibleFastPath() {
			$table = new DifferentialRevision();
			$conn_r = $table->establishConnection('r');

			$responsible_phid = reset($this->responsibles);
			$open_statuses = array(
			ArcanistDifferentialRevisionStatus::NEEDS_REVIEW,
			ArcanistDifferentialRevisionStatus::NEEDS_REVISION,
			ArcanistDifferentialRevisionStatus::ACCEPTED,
			);

			return queryfx_all(
			$conn_r,
			'SELECT * FROM %T WHERE authorPHID = %s AND status IN (%Ld)
			UNION ALL
			SELECT r.* FROM %T r JOIN %T rel
			ON rel.revisionID = r.id
			AND rel.relation = %s
			AND rel.objectPHID = %s
			WHERE r.status IN (%Ld) ORDER BY dateModified DESC',
			$table->getTableName(),
			$responsible_phid,
			$open_statuses,

			$table->getTableName(),
			DifferentialRevision::RELATIONSHIP_TABLE,
			DifferentialRevision::RELATION_REVIEWER,
			$responsible_phid,
			$open_statuses);
			}

			private function loadData() {
			$table = new DifferentialRevision();
			$conn_r = $table->establishConnection('r');

			$select = qsprintf(
			$conn_r,
			'SELECT r.* FROM %T r',
			$table->getTableName());

			$joins = $this->buildJoinsClause($conn_r);
			$where = $this->buildWhereClause($conn_r);
			$group_by = $this->buildGroupByClause($conn_r);
			$order_by = $this->buildOrderByClause($conn_r);

			$limit = '';
			if ($this->offset \|\| $this->limit) {
			$limit = qsprintf(
			$conn_r,
			'LIMIT %d, %d',
			(int)$this->offset,
			$this->limit);
			}

			return queryfx_all(
			$conn_r,
			'%Q %Q %Q %Q %Q %Q',
			$select,
			$joins,
			$where,
			$group_by,
			$order_by,
			$limit);
			}


			/* -( Internals )---------------------------------------------------------- */


			/**
			* @task internal
			*/
			private function buildJoinsClause($conn_r) {
			$joins = array();
			if ($this->pathIDs) {
			$path_table = new DifferentialAffectedPath();
			$joins[] = qsprintf(
			$conn_r,
			'JOIN %T p ON p.revisionID = r.id',
			$path_table->getTableName());
			}

			if ($this->commitHashes) {
			$joins[] = qsprintf(
			$conn_r,
			'JOIN %T hash_rel ON hash_rel.revisionID = r.id',
			ArcanistDifferentialRevisionHash::TABLE_NAME);
			}

			if ($this->ccs) {
			$joins[] = qsprintf(
			$conn_r,
			'JOIN %T cc_rel ON cc_rel.revisionID = r.id '.
			'AND cc_rel.relation = %s '.
			'AND cc_rel.objectPHID in (%Ls)',
			DifferentialRevision::RELATIONSHIP_TABLE,
			DifferentialRevision::RELATION_SUBSCRIBED,
			$this->ccs);
			}

			if ($this->reviewers) {
			$joins[] = qsprintf(
			$conn_r,
			'JOIN %T reviewer_rel ON reviewer_rel.revisionID = r.id '.
			'AND reviewer_rel.relation = %s '.
			'AND reviewer_rel.objectPHID in (%Ls)',
			DifferentialRevision::RELATIONSHIP_TABLE,
			DifferentialRevision::RELATION_REVIEWER,
			$this->reviewers);
			}

			if ($this->subscribers) {
			$joins[] = qsprintf(
			$conn_r,
			'JOIN %T sub_rel ON sub_rel.revisionID = r.id '.
			'AND sub_rel.relation IN (%Ls) '.
			'AND sub_rel.objectPHID in (%Ls)',
			DifferentialRevision::RELATIONSHIP_TABLE,
			array(
			DifferentialRevision::RELATION_SUBSCRIBED,
			DifferentialRevision::RELATION_REVIEWER,
			),
			$this->subscribers);
			}

			if ($this->responsibles) {
			$joins[] = qsprintf(
			$conn_r,
			'LEFT JOIN %T responsibles_rel ON responsibles_rel.revisionID = r.id '.
			'AND responsibles_rel.relation = %s '.
			'AND responsibles_rel.objectPHID in (%Ls)',
			DifferentialRevision::RELATIONSHIP_TABLE,
			DifferentialRevision::RELATION_REVIEWER,
			$this->responsibles);
			}

			$joins = implode(' ', $joins);

			return $joins;
			}


			/**
			* @task internal
			*/
			private function buildWhereClause($conn_r) {
			$where = array();

			if ($this->pathIDs) {
			$path_clauses = array();
			$repo_info = igroup($this->pathIDs, 'repositoryID');
			foreach ($repo_info as $repository_id => $paths) {
			$path_clauses[] = qsprintf(
			$conn_r,
			'(repositoryID = %d AND pathID IN (%Ld))',
			$repository_id,
			ipull($paths, 'pathID'));
			}
			$path_clauses = '('.implode(' OR ', $path_clauses).')';
			$where[] = $path_clauses;
			}

			if ($this->authors) {
			$where[] = qsprintf(
			$conn_r,
			'authorPHID IN (%Ls)',
			$this->authors);
			}

			if ($this->revIDs) {
			$where[] = qsprintf(
			$conn_r,
			'id IN (%Ld)',
			$this->revIDs);
			}

			if ($this->commitHashes) {
			$hash_clauses = array();
			foreach ($this->commitHashes as $info) {
			list($type, $hash) = $info;
			$hash_clauses[] = qsprintf(
			$conn_r,
			'(hash_rel.type = %s AND hash_rel.hash = %s)',
			$type,
			$hash);
			}
			$hash_clauses = '('.implode(' OR ', $hash_clauses).')';
			$where[] = $hash_clauses;
			}

			if ($this->phids) {
			$where[] = qsprintf(
			$conn_r,
			'phid IN (%Ls)',
			$this->phids);
			}

			if ($this->responsibles) {
			$where[] = qsprintf(
			$conn_r,
			'(responsibles_rel.objectPHID IS NOT NULL OR r.authorPHID IN (%Ls))',
			$this->responsibles);
			}

			switch ($this->status) {
			case self::STATUS_ANY:
			break;
			case self::STATUS_OPEN:
			$where[] = qsprintf(
			$conn_r,
			'status IN (%Ld)',
			array(
			ArcanistDifferentialRevisionStatus::NEEDS_REVIEW,
			ArcanistDifferentialRevisionStatus::NEEDS_REVISION,
			ArcanistDifferentialRevisionStatus::ACCEPTED,
			));
			break;
			case self::STATUS_ACCEPTED:
			$where[] = qsprintf(
			$conn_r,
			'status IN (%Ld)',
			array(
			ArcanistDifferentialRevisionStatus::ACCEPTED,
			));
			break;
			case self::STATUS_COMMITTED:
			$where[] = qsprintf(
			$conn_r,
			'status IN (%Ld)',
			array(
			ArcanistDifferentialRevisionStatus::COMMITTED,
			));
			break;
			case self::STATUS_ABANDONED:
			$where[] = qsprintf(
			$conn_r,
			'status IN (%Ld)',
			array(
			ArcanistDifferentialRevisionStatus::ABANDONED,
			));
			break;
			default:
			throw new Exception(
			"Unknown revision status filter constant '{$this->status}'!");
			}

			if ($where) {
			$where = 'WHERE '.implode(' AND ', $where);
			} else {
			$where = '';
			}

			return $where;
			}


			/**
			* @task internal
			*/
			private function buildGroupByClause($conn_r) {
			$join_triggers = array_merge(
			$this->pathIDs,
			$this->ccs,
			$this->reviewers,
			$this->subscribers,
			$this->responsibles);

			$needs_distinct = (count($join_triggers) > 1);

			if ($needs_distinct) {
			return 'GROUP BY r.id';
			} else {
			return '';
			}
			}


			/**
			* @task internal
			*/
			private function buildOrderByClause($conn_r) {
			switch ($this->order) {
			case self::ORDER_MODIFIED:
			return 'ORDER BY r.dateModified DESC';
			case self::ORDER_CREATED:
			return 'ORDER BY r.dateCreated DESC';
			case self::ORDER_PATH_MODIFIED:
			if (!$this->pathIDs) {
			throw new Exception(
			"To use ORDER_PATH_MODIFIED, you must specify withPath().");
			}
			return 'ORDER BY p.epoch DESC';
			default:
			throw new Exception("Unknown query order constant '{$this->order}'.");
			}
			}

			private function loadRelationships($conn_r, array $revisions) {
			$relationships = queryfx_all(
			$conn_r,
			'SELECT * FROM %T WHERE revisionID in (%Ld) ORDER BY sequence',
			DifferentialRevision::RELATIONSHIP_TABLE,
			mpull($revisions, 'getID'));
			$relationships = igroup($relationships, 'revisionID');
			foreach ($revisions as $revision) {
			$revision->attachRelationships(
			idx(
			$relationships,
			$revision->getID(),
			array()));
			}
			}

			private function loadCommitPHIDs($conn_r, array $revisions) {
			$commit_phids = queryfx_all(
			$conn_r,
			'SELECT * FROM %T WHERE revisionID IN (%Ld)',
			DifferentialRevision::TABLE_COMMIT,
			mpull($revisions, 'getID'));
			$commit_phids = igroup($commit_phids, 'revisionID');
			foreach ($revisions as $revision) {
			$phids = idx($commit_phids, $revision->getID(), array());
			$phids = ipull($phids, 'commitPHID');
			$revision->attachCommitPHIDs($phids);
			}
			}

			private function loadDiffIDs($conn_r, array $revisions) {
			$diff_table = new DifferentialDiff();

			$diff_ids = queryfx_all(
			$conn_r,
			'SELECT revisionID, id FROM %T WHERE revisionID IN (%Ld)
			ORDER BY id DESC',
			$diff_table->getTableName(),
			mpull($revisions, 'getID'));
			$diff_ids = igroup($diff_ids, 'revisionID');

			foreach ($revisions as $revision) {
			$ids = idx($diff_ids, $revision->getID(), array());
			$ids = ipull($ids, 'id');
			$revision->attachDiffIDs($ids);
			}
			}

			private function loadActiveDiffs($conn_r, array $revisions) {
			$diff_table = new DifferentialDiff();

			$load_ids = array();
			foreach ($revisions as $revision) {
			$diffs = $revision->getDiffIDs();
			if ($diffs) {
			$load_ids[] = max($diffs);
			}
			}

			$active_diffs = array();
			if ($load_ids) {
			$active_diffs = $diff_table->loadAllWhere(
			'id IN (%Ld)',
			$load_ids);
			}

			$active_diffs = mpull($active_diffs, null, 'getRevisionID');
			foreach ($revisions as $revision) {
			$revision->attachActiveDiff(idx($active_diffs, $revision->getID()));
			}
			}

			public static function splitResponsible(array $revisions, $user_phid) {
			$active = array();
			$waiting = array();
			$status_review = ArcanistDifferentialRevisionStatus::NEEDS_REVIEW;

			// Bucket revisions into $active (revisions you need to do something
			// about) and $waiting (revisions you're waiting on someone else to do
			// something about).
			foreach ($revisions as $revision) {
			$needs_review = ($revision->getStatus() == $status_review);
			$filter_is_author = ($revision->getAuthorPHID() == $user_phid);

			// If exactly one of "needs review" and "the user is the author" is
			// true, the user needs to act on it. Otherwise, they're waiting on
			// it.
			if ($needs_review ^ $filter_is_author) {
			$active[] = $revision;
			} else {
			$waiting[] = $revision;
			}
			}

			return array($active, $waiting);
			}


			}

phab/src/applications/differential/query/revision/DifferentialRevisionQuery.php11cccb98c2befeature/testing

DifferentialRevisionQuery.phpView Options

phab/src/applications/differential/query/revision/DifferentialRevisionQuery.php
11cccb98c2befeature/testing

DifferentialRevisionQuery.php
View Options