Homec4science

Merge pull request #19 in SHRINE/shrine from feature/SHRINE-2145-add-an…

Authored by David Walend <david_walend@hms.harvard.edu> on Aug 17 2017, 15:04.

Description

Merge pull request #19 in SHRINE/shrine from feature/SHRINE-2145-add-an-optional-changes-since to develop

  • commit 'eac4b3a8a8a573ecf7016c77c3103be3f20a61c7': (25 commits) Added some debug logging in case we need to diagnose in the field. Some improved error messages for SHRINE-2145 Added some logic to be sure that (if everything is working) spray won't give up on the request before the timeout response goes out for SHRINE-2145 Added a scheduled cleanup of the notification Map every 5 minutes. SHRINE-2145 Extracted QepQueryDbChangeNotifier into a singleton where other parts of SHRINE can trigger changes for SHRINE-2145 Added version and isComplete fields to ResultsRow for SHRINE-2145 Yifan is right. map...getOrElse does put all the error bits in the same spot. Got rid of Unit vs method name warning for SHRINE-2145 Switched to timeoutSeconds for SHRINE-2145 Changed Promises to be Promise[Unit] for identifying requests for SHRINE-2145 Switched to UUIDs for identifying requests for SHRINE-2145 Test of trigger to change data for SHRINE-2145 Allow trigger to change data, plus some updated comments for SHRINE-2145 Making the right Promises, and fulfilling one of them. SHRINE-2145 A little code rearranging for SHRINE-2145 Got the delayed-to-timeout path working for SHRINE-2145 Added a test to make sure a result came back eventually for SHRINE-2145 Concurrent structures for SHRINE-2145 Notes for for SHRINE-2145 Added a detatch() for SHRINE-2145 ...

Event Timeline

David Walend <david_walend@hms.harvard.edu> committed R2664:1f26074be1d1: Merge pull request #19 in SHRINE/shrine from feature/SHRINE-2145-add-an… (authored by David Walend <david_walend@hms.harvard.edu>).Aug 17 2017, 15:04

Merged Changes

CommitAuthorDetailsCommitted
eac4b3a8a8a5David Walend
Merging for SHRINE-2145 
Aug 14 2017
6c63fbebc7b6David Walend
Added some debug logging in case we need to diagnose in the field. 
Aug 14 2017
ddea3cda4c1bDavid Walend
Some improved error messages for SHRINE-2145 
Aug 14 2017
c9971aae2852David Walend
Added some logic to be sure that (if everything is working) spray won't give up… 
Aug 14 2017
49e53dfd49a9David Walend
Added a scheduled cleanup of the notification Map every 5 minutes. SHRINE-2145 
Aug 14 2017
b1977c6de01aDavid Walend
Extracted QepQueryDbChangeNotifier into a singleton where other parts of SHRINE… 
Aug 13 2017
83caf38d2e93David Walend
Added version and isComplete fields to ResultsRow for SHRINE-2145 
Aug 13 2017
c014fca3081fDavid Walend
Yifan is right. map...getOrElse does put all the error bits in the same spot. 
Aug 12 2017
5cbe1020a737David Walend
Got rid of Unit vs method name warning for SHRINE-2145 
Aug 12 2017
91657c900fafDavid Walend
Switched to timeoutSeconds for SHRINE-2145 
Aug 12 2017
dff4c1dc168fDavid Walend
Changed Promises to be Promise[Unit] for identifying requests for SHRINE-2145 
Aug 12 2017
5040afd83a24David Walend
Switched to UUIDs for identifying requests for SHRINE-2145 
Aug 12 2017
e3dff6497d0bDavid Walend
Test of trigger to change data for SHRINE-2145 
Aug 12 2017
f413d3a49da9David Walend
Allow trigger to change data, plus some updated comments for SHRINE-2145 
Aug 12 2017
7d20a4514aa4David Walend
Making the right Promises, and fulfilling one of them. SHRINE-2145 
Aug 11 2017
dd75262b2677David Walend
A little code rearranging for SHRINE-2145 
Aug 11 2017
8f5edb5081b0David Walend
Got the delayed-to-timeout path working for SHRINE-2145 
Aug 11 2017
ede3d6f8636cDavid Walend
Added a test to make sure a result came back eventually for SHRINE-2145 
Aug 11 2017
7f4c8d21988aDavid Walend
Concurrent structures for SHRINE-2145 
Aug 10 2017
3a4f43aa31c5David Walend
Notes for for SHRINE-2145 
Aug 10 2017
47f7e6d0bcafDavid Walend
Added a detatch() for SHRINE-2145 
Aug 10 2017
81859ca9c0e1David Walend
Factored out respondOrWait for SHRINE-2145 
Aug 10 2017
32b569f11895David Walend
Separated out the logical decision about if it should respond right now or wait… 
Aug 9 2017
ecc5950fa3d5David Walend
Isolating the ResultsRow for SHRINE-2145 
Aug 9 2017
df6bc6f04a9dDavid Walend
Data version and timeout parameters for SHRINE-2145 
Aug 8 2017
6c6484d7666eDavid Walend
Merge branch 'develop' into feature/SHRINE-2145-add-an-optional-changes-since 
Aug 7 2017
15a29e918027David Walend
Todos for SHRINE-2145 
Aug 7 2017