Homec4science
Diffusion SHRINE MedCo Fork f3d6d1faf56f

Merge pull request #23 in SHRINE/shrine from ~YXING/shrine:config to develop
f3d6d1faf56f
Actions

Authored by Yifan Xing <yifan_xing@hms.harvard.edu> on Aug 30 2017, 20:40.

Description

Merge pull request #23 in SHRINE/shrine from ~YXING/shrine:config to develop

  • commit '987290cd937e327dd5e5f0e8c68731d389daad62': changed default config to be false and modified tests to pass, added ProblemHandler in test config file to avoid exception clean up implemented code reviews: created and logged a Problem used if/else instead of require, implemented unit test for configuration implemented momRoute configuration requirement, haven't found a good way to test added enable property implementing config momRoute added default hornetqmomwebapi config

Details

Committed
Yifan Xing <yifan_xing@hms.harvard.edu>Aug 30 2017, 20:40
Pushed
mickmisOct 25 2017, 14:31
Parents
R2664:987290cd937e: changed default config to be false and modified tests to pass, added…
R2664:dc40ff5cc2ba: Merge pull request #28 in SHRINE/shrine from ~YXING/shrine:detach to develop
Branches
Unknown
Tags
Unknown

Event Timeline

Yifan Xing <yifan_xing@hms.harvard.edu> committed R2664:f3d6d1faf56f: Merge pull request #23 in SHRINE/shrine from ~YXING/shrine:config to develop (authored by Yifan Xing <yifan_xing@hms.harvard.edu>).Aug 30 2017, 20:40

Merged Changes

CommitAuthorDetailsCommitted
987290cd937eyifan xing
changed default config to be false and modified tests to pass, added… 
Aug 30 2017
47bf21236373yifan xing
clean up 
Aug 30 2017
aa151983081cyifan xing
implemented code reviews: created and logged a Problem 
Aug 30 2017
95eddaa02760yifan xing
used if/else instead of require, implemented unit test for configuration 
Aug 30 2017
85175be6ee1fyifan xing
implemented momRoute configuration requirement, haven't found a good way to test 
Aug 30 2017
51135cbe8727yifan xing
added enable property 
Aug 30 2017
0a2c1a6679ccyifan xing
implementing config momRoute 
Aug 30 2017
b54ac2a7f936yifan xing
added default hornetqmomwebapi config 
Aug 30 2017

Changes (6)

Path
Mmessagequeue/hornetqmom/src/main/resources/reference.conf
Mmessagequeue/hornetqmom/src/main/scala/net/shrine/hornetqmom/HornetQMomWebApi.scala
Mmessagequeue/hornetqmom/src/test/resources/shrine.conf
Mmessagequeue/hornetqmom/src/test/scala/net/shrine/hornetqmom/HornetQMomWebApiTest.scala
Mmessagequeue/messagequeueservice/src/main/scala/net/shrine/messagequeueservice/MessageQueueService.scala
Mshrine-setup/src/main/resources/shrine.conf

R2664:f3d6d1faf56f

View Options

messagequeue/hornetqmom/src/main/resources/reference.conf

Loading...
View Options

messagequeue/hornetqmom/src/main/scala/net/shrine/hornetqmom/HornetQMomWebApi.scala

Loading...
View Options

messagequeue/hornetqmom/src/test/resources/shrine.conf

Loading...
View Options

messagequeue/hornetqmom/src/test/scala/net/shrine/hornetqmom/HornetQMomWebApiTest.scala

Loading...
View Options

messagequeue/messagequeueservice/src/main/scala/net/shrine/messagequeueservice/MessageQueueService.scala

Loading...
View Options

shrine-setup/src/main/resources/shrine.conf

Loading...
c4science · Help