Diffusion invenio-infoscience 30e459c69afd

Merge branch 'badzil/code-quality'
30e459c69afd
Actions

Authored by Tibor Simko <tibor.simko@cern.ch> on Aug 17 2010, 19:34.

Description

Merge branch 'badzil/code-quality'

Merged branch 'badzil/code-quality' while:

(i) leaving away some commits: badzil/0f0215 WebSearch: Fix MySQL warning badzil/891ddb BibConvert: Add test with regular expression badzil/6356a2 BibConvert: More test cases for regular expressions badzil/b7b0cf Miscutil: Ignore kwalitee default score

(ii) in-situ retro fixing some WebComment imports at: badzil/09b337 Removal of unused imports

as discussed on ticket #205.

Also, fixed bibtask.py logging handler import, fixed bibrank misdeleted imports.

Details

Committed

Tibor Simko <tibor.simko@cern.ch>

Aug 17 2010, 22:01

Parents

R3600:56061343ac61: WebSubmit: Fixes for the real errors
R3600:f3ab0fe65e1e: WebStat: remember query options in UI

Branches

Unknown

Tags

Unknown

Event Timeline

Tibor Simko <tibor.simko@cern.ch> committed R3600:30e459c69afd: Merge branch 'badzil/code-quality' (authored by Tibor Simko <tibor.simko@cern.ch>).Aug 17 2010, 22:01

Merged Changes

Commit	Author	Details	Committed
56061343ac61	Benoit Thiell/Tibor Simko	WebSubmit: Fixes for the real errors	Aug 17 2010
f242cf6fed60	Benoit Thiell/Tibor Simko	WebSession: Bug fix	Aug 17 2010
4d27f1df5e0b	Benoit Thiell/Tibor Simko	WebStyle: Document hacks	Aug 17 2010
fb91b71390e3	Benoit Thiell/Tibor Simko	WebStat: Simple bug fix	Aug 17 2010
76395c2b0ac3	Benoit Thiell/Tibor Simko	WebJournal: Simple bug fixes	Aug 17 2010
4ef88656f588	Benoit Thiell/Tibor Simko	Miscutil: Document hack	Aug 17 2010
54111e08c698	Benoit Thiell/Tibor Simko	BibFormat: Simple bug fix	Aug 17 2010
34a4cb375046	Benoit Thiell/Tibor Simko	BibExport: Fix Pylint errors	Aug 17 2010
39b37db2c991	Benoit Thiell/Tibor Simko	Miscutil: kwalitee: Add webstat to the list of modules	Aug 17 2010
539fc74527bf	Benoit Thiell/Tibor Simko	BibSched: Document code hack	Aug 17 2010
aa287fea6cd0	Benoit Thiell/Tibor Simko	elmsubmit: Fix my poor knowledge of English	Aug 17 2010
d6832dfc8847	Benoit Thiell/Tibor Simko	WebSearch: Remove dusty old methods containing Python errors	Aug 17 2010
db05a904ca2c	Benoit Thiell/Tibor Simko	WebSearch: Make initialization code more readable.	Aug 17 2010
f319e9895df7	Benoit Thiell/Tibor Simko	BibIndex: Fix indentation	Aug 17 2010
d3adea7c2338	Benoit Thiell/Tibor Simko	BibConvert: Simple bug fix	Aug 17 2010
932e210e9611	Benoit Thiell/Tibor Simko	WebSession: Simple bug fix	Aug 17 2010
83193f482681	Benoit Thiell/Tibor Simko	BibIndex: Simple bug fix	Aug 17 2010
3e99fec0a055	Benoit Thiell/Tibor Simko	elmsubmit: Simple bug fixes	Aug 17 2010
c5ace02b4977	Benoit Thiell/Tibor Simko	BibFormat: Simple bug fixes + documentation	Aug 17 2010
4b2e9bf2ce7e	Benoit Thiell/Tibor Simko	BibClassify: Simple bug fix	Aug 17 2010
9a4ea5f5f2ee	Benoit Thiell/Tibor Simko	Add missing imports	Aug 17 2010
ccaad1b67b93	Benoit Thiell/Tibor Simko	BibHarvest: Simple bug fix	Aug 17 2010
5c425ab4fa07	Benoit Thiell/Tibor Simko	Remove duplicate imports	Aug 17 2010
d277958c9e4d	Benoit Thiell/Tibor Simko	Removal of unused imports	Aug 17 2010
9a07062b3286	Benoit Thiell/Tibor Simko	Replace tabulations with spaces	Aug 17 2010
fa050a506c28	Benoit Thiell/Tibor Simko	Use dbquery serialization methods	Aug 17 2010

Changes (162)
Show All Changes

Very Large Commit

This commit is very large. Load each file individually.

				Path
	M			modules/bibcheck/web/admin/bibcheckadmin.py
	M			modules/bibcirculation/lib/bibcirculation_dblayer.py
	M			modules/bibcirculation/lib/bibcirculation_templates.py
	M			modules/bibcirculation/web/admin/bibcirculationadmin.py
	M			modules/bibclassify/lib/bibclassify_daemon.py
	M			modules/bibclassify/lib/bibclassify_regression_tests.py
	M			modules/bibclassify/lib/bibclassify_text_normalizer.py
	M			modules/bibclassify/lib/bibclassify_webinterface.py
	M			modules/bibconvert/lib/bibconvert.py
	M			modules/bibconvert/lib/bibconvert_regression_tests.py
	M			modules/bibedit/lib/bibedit_engine.py
	M			modules/bibedit/lib/bibedit_templates.py
	M			modules/bibedit/lib/bibeditmulti_engine.py
	M			modules/bibedit/lib/refextract_config.py
	M			modules/bibexport/lib/bibexport.py
	M			modules/bibexport/lib/bibexport_method_fieldexporter_tests.py
	M			modules/bibexport/lib/bibexport_method_sitemap.py
	M			modules/bibformat/lib/bibformat_engine_tests.py
	M			modules/bibformat/lib/bibformat_templates.py
	M			modules/bibformat/lib/bibformat_utils.py
	M			modules/bibformat/lib/bibformatadminlib.py
	M			modules/bibformat/lib/elements/bfe_edit_files.py
	M			modules/bibformat/lib/elements/bfe_server_info.py
	M			modules/bibformat/lib/elements/bfe_test_4.py
	M			modules/bibformat/web/admin/bibformatadmin.py
	M			modules/bibharvest/lib/oai_harvest_admin.py
	M			modules/bibharvest/lib/oai_harvest_daemon.py
	M			modules/bibharvest/lib/oai_harvest_dblayer.py
	M			modules/bibharvest/lib/oai_repository_server.py
	M			modules/bibharvest/lib/oai_repository_updater.py
	M			modules/bibharvest/web/admin/oaiharvestadmin.py
	M			modules/bibharvest/web/admin/oairepositoryadmin.py
	M			modules/bibindex/lib/bibindex_engine.py
	M			modules/bibindex/lib/bibindex_engine_config.py
	M			modules/bibindex/lib/bibindex_engine_stemmer_greek.py
	M			modules/bibindex/lib/bibindex_engine_tokenizer.py
	M			modules/bibindex/lib/bibindexadminlib.py
	M			modules/bibindex/web/admin/bibindexadmin.py
	M			modules/bibknowledge/lib/bibknowledge.py
	M			modules/bibknowledge/lib/bibknowledge_templates.py
	M			modules/bibknowledge/lib/bibknowledgeadmin.py
	M			modules/bibmatch/lib/bibmatch_regression_tests.py
	M			modules/bibmerge/lib/bibmerge_engine.py
	M			modules/bibrank/lib/bibrank.py
	M			modules/bibrank/lib/bibrank_citation_grapher.py
	M			modules/bibrank/lib/bibrank_citation_indexer.py
	M			modules/bibrank/lib/bibrank_citation_searcher.py
	M			modules/bibrank/lib/bibrank_citation_searcher_tests.py
	M			modules/bibrank/lib/bibrank_citerank_indexer.py
	M			modules/bibrank/lib/bibrank_citerank_indexer_tests.py
	M			modules/bibrank/lib/bibrank_downloads_grapher.py
	M			modules/bibrank/lib/bibrank_grapher.py
	M			modules/bibrank/lib/bibrank_record_sorter.py
	M			modules/bibrank/lib/bibrankadminlib.py
	M			modules/bibrank/web/admin/bibrankadmin.py
	M			modules/bibsched/lib/bibsched.py
	M			modules/bibsched/lib/bibtask.py
	M			modules/bibupload/lib/bibupload.py
	M			modules/elmsubmit/lib/elmsubmit.py
	M			modules/elmsubmit/lib/elmsubmit_EZArchive.py
	M			modules/elmsubmit/lib/elmsubmit_EZEmail.py
	M			modules/elmsubmit/lib/elmsubmit_filename_generator.py
	M			modules/elmsubmit/lib/elmsubmit_generate_marc.py
	M			modules/elmsubmit/lib/elmsubmit_misc.py
	M			modules/elmsubmit/lib/elmsubmit_tests.py
	M			modules/miscutil/lib/dbquery.py
	M			modules/miscutil/lib/errorlib_regression_tests.py
	M			modules/miscutil/lib/htmlutils_tests.py
	M			modules/miscutil/lib/invenio_connector.py
	M			modules/miscutil/lib/inveniocfg.py
	M			modules/miscutil/lib/kwalitee.py
	M			modules/webaccess/lib/access_control_config.py
	M			modules/webaccess/lib/access_control_firerole.py
	M			modules/webaccess/lib/access_control_mailcookie.py
	M			modules/webaccess/lib/external_authentication_sso.py
	M			modules/webaccess/lib/webaccess_regression_tests.py
	M			modules/webaccess/lib/webaccessadmin_lib.py
	M			modules/webbasket/lib/webbasket_webinterface.py
	M			modules/webcomment/lib/webcomment.py
	M			modules/webcomment/lib/webcomment_templates.py
	M			modules/webcomment/lib/webcomment_washer.py
	M			modules/webcomment/lib/webcomment_webinterface.py
	M			modules/webjournal/lib/elements/bfe_webjournal_archive.py
	M			modules/webjournal/lib/elements/bfe_webjournal_articles_overview.py
	M			modules/webjournal/lib/elements/bfe_webjournal_imprint.py
	M			modules/webjournal/lib/elements/bfe_webjournal_info.py
	M			modules/webjournal/lib/elements/bfe_webjournal_sub_navigation.py
	M			modules/webjournal/lib/webjournal_regression_tests.py
	M			modules/webjournal/lib/webjournal_utils.py
	M			modules/webjournal/lib/webjournaladminlib.py
	M			modules/webjournal/lib/widgets/bfe_webjournal_widget_featureRecord.py
	M			modules/webjournal/lib/widgets/bfe_webjournal_widget_whatsNew.py
	M			modules/webjournal/web/admin/webjournaladmin.py
	M			modules/webmessage/lib/webmessage_dblayer.py
	M			modules/webmessage/lib/webmessage_regression_tests.py
	M			modules/webmessage/lib/webmessage_tests.py
	M			modules/websearch/lib/search_engine.py
	M			modules/websearch/lib/search_engine_summarizer.py
	M			modules/websearch/lib/search_engine_tests.py
	M			modules/websearch/lib/websearch_external_collections.py
	M			modules/websearch/lib/websearch_regression_tests.py
	M			modules/websearch/lib/websearch_templates.py
	M			modules/websearch/lib/websearch_webcoll.py
	M			modules/websearch/lib/websearch_webinterface.py
	M			modules/websearch/web/admin/websearchadmin.py
	M			modules/websession/lib/session.py
	M			modules/websession/lib/webgroup_dblayer.py
	M			modules/websession/lib/webgroup_regression_tests.py
	M			modules/websession/lib/websession_templates.py
	M			modules/websession/lib/websession_webinterface.py
	M			modules/websession/lib/webuser.py
	M			modules/websession/lib/webuser_regression_tests.py
	M			modules/webstat/lib/webstat.py
	M			modules/webstat/lib/webstat_engine.py
	M			modules/webstat/lib/webstat_templates.py
	M			modules/webstat/lib/webstat_webinterface.py
	M			modules/webstyle/lib/httptest_webinterface.py
	M			modules/webstyle/lib/webdoc_webinterface.py
	M			modules/webstyle/lib/webinterface_handler.py
	M			modules/webstyle/lib/webinterface_handler_wsgi.py
	M			modules/webstyle/lib/webinterface_handler_wsgi_utils.py
	M			modules/webstyle/lib/webinterface_tests.py
	M			modules/webstyle/lib/webstyle_regression_tests.py
	M			modules/webstyle/lib/webstyle_templates.py
	M			modules/websubmit/lib/bibdocfile.py
	M			modules/websubmit/lib/bibdocfilecli.py
	M			modules/websubmit/lib/functions/Add_Files.py
	M			modules/websubmit/lib/functions/Check_Group.py
	M			modules/websubmit/lib/functions/Create_Cplx_Approval.py
	M			modules/websubmit/lib/functions/Generate_Group_File.py
	M			modules/websubmit/lib/functions/Mail_Approval_Request_to_Committee_Chair.py
	M			modules/websubmit/lib/functions/Mail_Submitter.py
	M			modules/websubmit/lib/functions/Move_Files_to_Storage.py
	M			modules/websubmit/lib/functions/Move_Revised_Files_to_Storage.py
	M			modules/websubmit/lib/functions/Print_Success_APP.py
	M			modules/websubmit/lib/functions/Print_Success_CPLX.py
	M			modules/websubmit/lib/functions/Register_Approval_Request.py
	M			modules/websubmit/lib/functions/Retrieve_Data.py
	M			modules/websubmit/lib/functions/Second_Report_Number_Generation.py
	M			modules/websubmit/lib/functions/Send_APP_Mail.py
	M			modules/websubmit/lib/functions/Send_Approval_Request.py
	M			modules/websubmit/lib/functions/Send_Delete_Mail.py
	M			modules/websubmit/lib/functions/Send_Modify_Mail.py
	M			modules/websubmit/lib/functions/Send_Request_For_Direct_Approval.py
	M			modules/websubmit/lib/functions/Send_Request_For_Publication.py
	M			modules/websubmit/lib/functions/Send_Request_For_Refereeing_Process.py
	M			modules/websubmit/lib/functions/Send_SRV_Mail.py
	M			modules/websubmit/lib/functions/Shared_Functions.py
	M			modules/websubmit/lib/functions/Withdraw_Approval_Request.py
	M			modules/websubmit/lib/icon_migration_kit.py
	M			modules/websubmit/lib/unoconv.py
	M			modules/websubmit/lib/websubmit_engine.py
	M			modules/websubmit/lib/websubmit_templates.py
	M			modules/websubmit/lib/websubmit_webinterface.py
	M			modules/websubmit/lib/websubmitadmin_dblayer.py
	M			modules/websubmit/lib/websubmitadmin_engine.py
	M			modules/websubmit/web/admin/referees.py
	M			modules/websubmit/web/admin/websubmitadmin.py
	M			modules/websubmit/web/approve.py
	M			modules/websubmit/web/publiline.py
	M			modules/websubmit/web/yourapprovals.py
	M			modules/websubmit/web/yoursubmissions.py