Diffusion invenio-infoscience 4b8a4ddc693a

BibWorkflow: API updates
4b8a4ddc693a
Actions

Authored by Jan Aage Lavik <jan.age.lavik@cern.ch> on Jul 17 2013, 18:44.

Description

BibWorkflow: API updates

The way run a workflow in a task queue has changed from a task_queue parameter into seperate "delayed" functions, such as start_delayed() or continue_oai_delayed().

Adds custom kwargs to be passed to all workflow API functions that will be put into the workflow engine's extra_data column. This allows one to access this data from the workflow tasks.

Documentation improved and corrected overall. Especially in bibworkflow_api.

Updated worker plugins and unit tests to reflect these new changes.

Renames several functions from camelCase to underscore_case.

Renames Holding Pen template files from bibholdingpen_* to bibworkflow_* as well as other restructu.

Adds a custom exception in bibworkflow_worker_engine instead of raising ValueError.

Changes worker API names.

Removes references to external_save as it is no longer used.

Various fixes to the Holding Pen, improving PEP8 etc.

Fixes many kwalitee issues.

Adds Redis backend functionality, by Wojciech Ziolek.

Co-authored-by: Wojciech Ziolek <wojciech.ziolek@cern.ch>

Details

Committed

kuncar

Feb 7 2014, 10:07

Parents

R3600:7294c73c3b59: BibWorkflow: `Workflow` API prototype

Branches

Unknown

Tags

Unknown

Event Timeline

Jiri Kuncar <jiri.kuncar@cern.ch> committed R3600:4b8a4ddc693a: BibWorkflow: API updates (authored by Jan Aage Lavik <jan.age.lavik@cern.ch>).Feb 7 2014, 10:07

Changes (74)

		Path
M		configure.ac
M		modules/bibworkflow/etc/Makefile.am
V		modules/bibworkflow/{etc → lib/tasks}/__init__.py
D		modules/bibworkflow/etc/tasks
V		modules/bibworkflow/{etc → lib}/tasks/Makefile.am
V		modules/bibworkflow/{etc/tasks → lib/widgets}/__init__.py
V		modules/bibworkflow/{etc → lib}/tasks/marcxml_tasks.py
V		modules/bibworkflow/{etc → lib}/tasks/simplified_data_tasks.py
V		modules/bibworkflow/{etc → lib}/tasks/test_tasks.py
M		modules/bibworkflow/etc/templates/Makefile.am
D		modules/bibworkflow/etc/templates/bibholdingpen.js
V		modules/bibworkflow/etc/templates/{bibholdingpen_approval_widget.html → bibworkflow_hp_approval_widget.html}
V		modules/bibworkflow/{etc/templates/bibholdingpen_approval_widget.js → lib/widgets/approval_widget.js}
V		modules/bibworkflow/etc/templates/{bibholdingpen_bibmatch_widget.html → bibworkflow_hp_bibmatch_widget.html}
V		modules/bibworkflow/etc/templates/{bibholdingpen_details.html → bibworkflow_hp_details.html}
V		modules/bibworkflow/{etc/templates/bibholdingpen_details.js → lib/bibworkflow_hp_details.js}
V		modules/bibworkflow/etc/templates/{bibholdingpen_index.html → bibworkflow_hp_index.html}
V		modules/bibworkflow/etc/templates/{bibholdingpen_layout.html → bibworkflow_hp_layout.html}
V		modules/bibworkflow/etc/templates/{bibholdingpen_utils.html → bibworkflow_hp_utils.html}
M		modules/bibworkflow/etc/templates/bibworkflow_entry_details.html
V		modules/bibworkflow/etc/templates/{bibworkflow_hp_approval_widget.html ← bibholdingpen_approval_widget.html}
V		modules/bibworkflow/etc/templates/{bibworkflow_hp_bibmatch_widget.html ← bibholdingpen_bibmatch_widget.html}
V		modules/bibworkflow/etc/templates/{bibworkflow_hp_details.html ← bibholdingpen_details.html}
V		modules/bibworkflow/etc/templates/{bibworkflow_hp_index.html ← bibholdingpen_index.html}
V		modules/bibworkflow/etc/templates/{bibworkflow_hp_layout.html ← bibholdingpen_layout.html}
V		modules/bibworkflow/etc/templates/{bibworkflow_hp_utils.html ← bibholdingpen_utils.html}
D		modules/bibworkflow/etc/workflows
V		modules/bibworkflow/{etc → lib}/workflows/Makefile.am
V		modules/bibworkflow/{etc → lib}/workflows/__init__.py
V		modules/bibworkflow/{etc → lib}/workflows/marcxml_workflow.py
V		modules/bibworkflow/{etc → lib}/workflows/simplified_data_test_workflow.py
V		modules/bibworkflow/{etc → lib}/workflows/test_workflow.py
V		modules/bibworkflow/{etc → lib}/workflows/test_workflow_2.py
M		modules/bibworkflow/lib/Makefile.am
M		modules/bibworkflow/lib/bibworkflow_admin_blueprint.py
M		modules/bibworkflow/lib/bibworkflow_api.py
M		modules/bibworkflow/lib/bibworkflow_client.py
M		modules/bibworkflow/lib/bibworkflow_config.py
P		modules/bibworkflow/lib/bibworkflow_containers.py Copied from modules/webtag/lib/webtag_regression_tests.py
M		modules/bibworkflow/lib/bibworkflow_engine.py
M		modules/bibworkflow/lib/bibworkflow_hp_blueprint.py
M		modules/bibworkflow/lib/bibworkflow_hp_container.py
V		modules/bibworkflow/{lib/bibworkflow_hp_details.js ← etc/templates/bibholdingpen_details.js}
M		modules/bibworkflow/lib/bibworkflow_hp_field_widgets.py
A		modules/bibworkflow/lib/bibworkflow_hp_index.js
M		modules/bibworkflow/lib/bibworkflow_hp_load_widgets.py
M		modules/bibworkflow/lib/bibworkflow_model.py
M		modules/bibworkflow/lib/bibworkflow_unit_tests.py
M		modules/bibworkflow/lib/bibworkflow_utils.py
M		modules/bibworkflow/lib/bibworkflow_worker_engine.py
M		modules/bibworkflow/lib/bibworkflow_workflow_definition.py
M		modules/bibworkflow/lib/bibworkflow_workflows.js
A	(dir)	modules/bibworkflow/lib/tasks/
V		modules/bibworkflow/{lib ← etc}/tasks/Makefile.am
V		modules/bibworkflow/{lib/tasks ← etc}/__init__.py
V		modules/bibworkflow/{lib ← etc}/tasks/marcxml_tasks.py
P		modules/bibworkflow/lib/tasks/my_tasks.py Copied from modules/miscutil/lib/upgrades/invenio_2012_12_11_new_citation_errors_table.py
V		modules/bibworkflow/{lib ← etc}/tasks/simplified_data_tasks.py
V		modules/bibworkflow/{lib ← etc}/tasks/test_tasks.py
M		modules/bibworkflow/lib/widgets/Makefile.am
V		modules/bibworkflow/{lib/widgets ← etc/tasks}/__init__.py
V		modules/bibworkflow/{lib/widgets/approval_widget.js ← etc/templates/bibholdingpen_approval_widget.js}
M		modules/bibworkflow/lib/workers/Makefile.am
M		modules/bibworkflow/lib/workers/worker_celery.py
M		modules/bibworkflow/lib/workers/worker_redis.py
A	(dir)	modules/bibworkflow/lib/workflows/
V		modules/bibworkflow/{lib ← etc}/workflows/Makefile.am
V		modules/bibworkflow/{lib ← etc}/workflows/__init__.py
V		modules/bibworkflow/{lib ← etc}/workflows/marcxml_workflow.py
P		modules/bibworkflow/lib/workflows/my_workflow.py Copied from modules/miscutil/lib/jsonutils_unit_tests.py
V		modules/bibworkflow/{lib ← etc}/workflows/simplified_data_test_workflow.py
V		modules/bibworkflow/{lib ← etc}/workflows/test_workflow.py
V		modules/bibworkflow/{lib ← etc}/workflows/test_workflow_2.py
M		modules/miscutil/lib/celery_config.py