Homec4science

Wanted to add a new parameter "decision_file", because the function previously…

Authored by Nicholas Robinson <nicholas.robinson@cern.ch> on Mar 9 2008, 13:09.

Description

Wanted to add a new parameter "decision_file", because the function previously looked for the hard-coded filename "decision", which meant that any referee's decision field on the form had to be called "decision". Anyway, because the function was so short, and a mess, I decided to rewrite it. Sadly, it's still not perfect because it needs to make use of the global variable "rn" in the message. Although it now has some exception-registering, it still needs work in the situation where it wasn't possible to read from the referee's decision file at all, yet should still return a message to be deisplayed in the user's browser (I'd have liked to have raised an InvenioWebSubmitFunctionWarning there, but that would prevent the return of a string for the user. So, this needs to be touched-up at some point . . . )

Event Timeline

Nicholas Robinson <nicholas.robinson@cern.ch> committed R3600:6c093bac4e48: Wanted to add a new parameter "decision_file", because the function previously… (authored by Nicholas Robinson <nicholas.robinson@cern.ch>).Mar 9 2008, 13:09