Homec4science

BibUpload: fixed provenance checking bug

Authored by Samuele Kaplun <samuele.kaplun@cern.ch> on Apr 28 2010, 18:30.

Description

BibUpload: fixed provenance checking bug

  • Fixed a bug in the provenance checking of find_records_from_extoaiid where if, for a given external ID and Provenance, there existed a record having multiple external IDs, with and without provenance and at least one of the IDs matched the given one (but not the Provenance), because of the ID with no provenance was wrongly matched with the given ID an error was raised.
  • If an incoming record has external ID with provenance and an existing record has the same ID but no provenance set, then a warning is printed but the record is not matched. (closes #12447)
  • Refactored BibUpload regression tests to always properly wipe out test records being created.
  • Removed unused functions from BibUpload. Moved wipe_out_record_from_all_tables function to bibupload_regression_tests.py.
  • Moved BibTask loggers initialization in a function in order for regression tests to be able to initialize BibTasks loggers without instantiating a BibTask.

Details

Committed
Tibor Simko <tibor.simko@cern.ch>Apr 30 2010, 11:18
Parents
R3600:d93b421fb1fb: WebStyle: no new error page when response sent
Branches
Unknown
Tags
Unknown

Event Timeline

Tibor Simko <tibor.simko@cern.ch> committed R3600:edf4d08e97b9: BibUpload: fixed provenance checking bug (authored by Samuele Kaplun <samuele.kaplun@cern.ch>).Apr 30 2010, 11:18