Homec4science

Don't hardcode the filename in `CxxExceptionDeathTest.

Authored by Enji Cooper <yaneurabeya@gmail.com> on Feb 21 2019, 21:01.

Description

Don't hardcode the filename in CxxExceptionDeathTest.PrintsMessageForStdException

Due to some caveats in the FreeBSD build system and the fact that the
source file is used to compile 2 different death tests with different
flags, I needed (as a shortterm workaround) to copy the test to 2
differently named files.

While this works for compiling the test, as I discovered, this doesn't
work with running CxxExceptionDeathTest.PrintsMessageForStdException,
as the testcase hardcodes googletest-death-test_ex_test.cc. Use __FILE__
when looking for failures, as opposed to looking for the hardcoded name
as it can vary depending on how the test was built.

Signed-off-by: Enji Cooper <yaneurabeya@gmail.com>

Details

Committed
Enji Cooper <yaneurabeya@gmail.com>Feb 21 2019, 21:10
Pushed
trottetDec 4 2019, 13:52
Parents
R9484:7203f37f57e4: Merge pull request #2137 from ngie-eign:clang-ignore-sign-conversion
Branches
Unknown
Tags
Unknown

Event Timeline

Enji Cooper <yaneurabeya@gmail.com> committed R9484:cd09534deccd: Don't hardcode the filename in `CxxExceptionDeathTest. (authored by Enji Cooper <yaneurabeya@gmail.com>).Feb 21 2019, 21:10