Homec4science

Googlemock has some tuples containing lvalue refs in its unit tests. These…

Authored by Billy Donahue <billydonahue@google.com> on Sep 8 2015, 04:32.

Description

Googlemock has some tuples containing lvalue refs in its unit tests. These tuples are created with make_tuple, which is given temporaries. The make_tuple is in a function argument list.

A possibly overzealous static_assert in libc++'s std::tuple ctor
is firing in our 'Perform(make_tuple("hi"))' calls, so
we can't use its make_tuple here. Instead we will use
explicitly-constructed tuples constructed from non-temporary strings.

Workaround for llvm bug:

https://llvm.org/bugs/show_bug.cgi?id=20855

An alternative to https://github.com/google/googletest/pull/580 .

Details

Committed
Billy Donahue <billydonahue@google.com>Sep 8 2015, 04:32
Pushed
trottetDec 4 2019, 13:52
Parents
R9484:99166db7545b: Merge pull request #579 from daus-salar/patch-1
Branches
Unknown
Tags
Unknown

Event Timeline

Billy Donahue <billydonahue@google.com> committed R9484:f19b060075e8: Googlemock has some tuples containing lvalue refs in its unit tests. These… (authored by Billy Donahue <billydonahue@google.com>).Sep 8 2015, 04:32