Homec4science

Conpherence - move crumb-based room edit to widget; other cleanup

Authored by Bob Trahan <btrahan@phacility.com> on Jun 26 2015, 00:59.

Description

Conpherence - move crumb-based room edit to widget; other cleanup

Summary:
We use a non-standard way to invoke the edit dialogue (title, picture, etc) via the crumb. Stop doing that and instead use the widget technology to invoke the dialogue.

This requires making the widget handling code a bit more nuanced as nothing has wanted to pop a dialogue before. I plan to clean this up as I add the action to "Mark as Favorite" to the UI. In particular, I want to stop rendering the un-used DOM and make a workflow-based widget action a property as opposed to something hardcoded. This may be too ambitious depending on how similar these workflows are....

This also updates the ThreadSearchEngine to be a bit more modern. Additionally, go through making some user-facing strings a bit more sensical.

Test Plan: changed settings from conpherence full and durable column successfully.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D13449

Details

Committed
Bob Trahan <btrahan@phacility.com>Jun 26 2015, 00:59
Pushed
aubortJan 31 2017, 17:16
Parents
rPH14229042a200: Do all push mail in a bunch at the end, too
Branches
Unknown
Tags
Unknown

Event Timeline

Bob Trahan <btrahan@phacility.com> committed rPH0094343556c2: Conpherence - move crumb-based room edit to widget; other cleanup (authored by Bob Trahan <btrahan@phacility.com>).Jun 26 2015, 00:59