Homec4science

Improve organization of Diffusion browse controllers

Authored by epriestley <git@epriestley.com> on Sep 20 2013, 01:01.

Description

Improve organization of Diffusion browse controllers

Summary:
Currently we have this:

  • DiffusionController (abstract, has some random shared browse code)
    • DiffusionBrowseController (concrete, Handles routing, directories, and search)
    • DiffusionBrowseFileController (concrete, handles files)

Instead, do this:

  • DiffusionController (no browse-related code)
    • DiffusionBrowseController (abstract, shared browse code)
      • DiffusionBrowseMainController (concrete, handles routing)
      • DiffusionBrowseDirectoryController (concrete, handles directories)
      • DiffusionBrowseFileController (concrete, handles files)
      • DiffusionBrowseSearchController (concrete, handles search)

Feels a lot cleaner.

Test Plan: Looked at directories, searches, and files.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Differential Revision: https://secure.phabricator.com/D7045

Details

Committed
epriestley <git@epriestley.com>Sep 20 2013, 01:01
Pushed
aubortJan 31 2017, 17:16
Parents
rPH1ec021bf8c51: Modernize file browse controller
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH0139fb9178a7: Improve organization of Diffusion browse controllers (authored by epriestley <git@epriestley.com>).Sep 20 2013, 01:01