Improve implementation of ManiphestTaskQuery
030726b144de
Actions

Authored by epriestley <git@epriestley.com> on Oct 5 2012, 00:30.

Description

Improve implementation of ManiphestTaskQuery

Summary:
Currently, we have a single projectPHIDs field, and a separate flag which makes it act like AND or OR.

This is silly. Make two separate methods for setting AND vs OR projects. This also simplifies the implmentation.

This doesn't change the UI or any behavior (yet), it just makes the API more usable.

Test Plan: Loaded homepage, "All Projects" task view, verified queries made sense and returned correct results. Grepped for changed method name.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T1610

Committed

epriestley <git@epriestley.com>

Oct 5 2012, 00:30

Pushed

aubort

Jan 31 2017, 17:16

Parents

Branches

Unknown

Tags

Unknown

epriestley <git@epriestley.com> committed rPH030726b144de: Improve implementation of ManiphestTaskQuery (authored by epriestley <git@epriestley.com>).Oct 5 2012, 00:30

				Path
	M			src/applications/directory/controller/PhabricatorDirectoryMainController.php
	M			src/applications/maniphest/ManiphestTaskQuery.php
	M			src/applications/maniphest/controller/ManiphestTaskListController.php
	M			src/applications/project/controller/PhabricatorProjectListController.php