Homec4science

Remove hard-coding of diff line height

Authored by Chad Little <chad@chadsdomain.com> on May 16 2016, 18:57.

Description

Remove hard-coding of diff line height

Summary: Fixes T10959. This is the smallest/simplest fix that I could come up with, and I wasn't able to break it. Basically, I removed "line-height" and then adjusted other rules until the defaults looked reasonable again.

Test Plan:
Here's 24px / 48px impact or something like it:

{F1310445}

{F1310446}

Here's normal stuff working properly without weird artifacts on the highlighting:

{F1310447}

Also tested Firefox and Chrome and got similar results.

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: wxm20073527, Korvin

Maniphest Tasks: T10959

Differential Revision: https://secure.phabricator.com/D15905

Details

Committed
Chad Little <chad@chadsdomain.com>May 16 2016, 19:21
Pushed
aubortJan 31 2017, 17:16
Parents
rPH1567f07e3cc1: Fix some broken links in the cluster documentation
Branches
Unknown
Tags
Unknown

Event Timeline

Chad Little <chad@chadsdomain.com> committed rPH03a1deba23f6: Remove hard-coding of diff line height (authored by Chad Little <chad@chadsdomain.com>).May 16 2016, 19:21