Homec4science

Restore image proxying to Remarkup

Authored by epriestley <git@epriestley.com> on May 2 2011, 23:20.

Description

Restore image proxying to Remarkup

Summary:
Previously, Remarkup allowed you to paste in an image URI and get an inline
image. However, it did this by hotlinking the image which isn't so hot in an
open source product.

Restore this feature, but use image proxying instead. The existing image macro
code does most of the work.

There is a mild security risk depending on the network setup so I've left this
default-disabled and made a note about it. It should be safe to enable for
Facebook.

Test Plan:
Pasted in image and non-image links, got reasonable behavior. Verified proxying
appears to work. Verified that file:// shenanigans produce 400.

Reviewed By: tuomaspelkonen
Reviewers: aran, jungejason, tuomaspelkonen
Commenters: cpiro
CC: aran, cpiro, tuomaspelkonen
Differential Revision: 214

Details

Committed
epriestley <git@epriestley.com>May 4 2011, 03:49
Pushed
aubortJan 31 2017, 17:16
Parents
rPHb75960c5783a: Web editor/browser for image macros
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH03ebbccbc99f: Restore image proxying to Remarkup (authored by epriestley <git@epriestley.com>).May 4 2011, 03:49