Homec4science

Fix file URI perf regression

Authored by epriestley <git@epriestley.com> on Sep 13 2011, 17:08.

Description

Fix file URI perf regression

Summary:
The CSRF changes meant that we can't generate a file URI with just its PHID
anymore, and converted a mathematical function into a service call.
Unfortunately, this caused massive perf problems in some parts of the
application, critically handles, where loading N users became N single gets.
Derp derp derp. Remedy this by doing a single multiget. This substantially
improves performance of many interfaces, particularly the Maniphest task list.

I need to go through the rest of the PhabricatorFileURI callsites and get rid of
them, but I think this is the most substantive one.

Test Plan: Profiled Maniphest task list, queries went from >100 to a handful.
Explosion of multiderp. :/ Looked at some views with profile photos to verify
they still render accurately.

Reviewers: jungejason, nh, tuomaspelkonen, aran

Reviewed By: aran

CC: aran

Differential Revision: 921

Details

Committed
epriestley <git@epriestley.com>Sep 13 2011, 19:33
Pushed
aubortJan 31 2017, 17:16
Parents
rPH888af7309a97: Add a simple symbol lookup interface for cross-references
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH03fb1887d301: Fix file URI perf regression (authored by epriestley <git@epriestley.com>).Sep 13 2011, 19:33