Homec4science

Conpherence - make show older messages work correctly in durable column

Authored by Bob Trahan <btrahan@phacility.com> on May 12 2015, 23:44.

Description

Conpherence - make show older messages work correctly in durable column

Summary:
Fixes T8009. This was basically moving the behavior from conpherence full behavior menu into the ConpherenceThreadManager so it could be re used in the durable column.

The durable column bit has no special styles - its just a link - but it seems to work well enough. I think it could be removed altogether if / when we add some automagical scrolling back into history stuff.

Test Plan: loaded up a conpherence in a durable column and used 'show older messages' successfully. loaded up a conpherence in regular view mid transaction and used show older and show newer successfully

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T8009

Differential Revision: https://secure.phabricator.com/D12816

Details

Committed
Bob Trahan <btrahan@phacility.com>May 12 2015, 23:44
Pushed
aubortJan 31 2017, 17:16
Parents
rPH8e9ee8635792: Calendar month view "today" indicator should be a blue bar across the bottom of…
Branches
Unknown
Tags
Unknown

Event Timeline

Bob Trahan <btrahan@phacility.com> committed rPH048eb6cf61f6: Conpherence - make show older messages work correctly in durable column (authored by Bob Trahan <btrahan@phacility.com>).May 12 2015, 23:44