Homec4science

Fatal during setup for "mbstring.func_overload"

Authored by epriestley <git@epriestley.com> on Jul 4 2014, 16:59.

Description

Fatal during setup for "mbstring.func_overload"

Summary:
Fixes T5545. We assume strlen() returns the number of bytes in a string, which is the normal behavior (and the documented behavior).

There's a config option, mbstring.func_overload, which silently calls mb_strlen() instead. This may return some other result, might fail, etc., and there's no way to get the byte length of a string if this option is set.

If this option is set, fatal immediately. Nothing good can ever come of it.

Test Plan: {F173990}

Reviewers: btrahan, chad

Reviewed By: chad

Subscribers: epriestley

Maniphest Tasks: T5545

Differential Revision: https://secure.phabricator.com/D9811

Details

Committed
epriestley <git@epriestley.com>Jul 4 2014, 16:59
Pushed
aubortJan 31 2017, 17:16
Parents
rPH7baa0941b956: Inlines for custom herald actions
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH04d5402e2fdd: Fatal during setup for "mbstring.func_overload" (authored by epriestley <git@epriestley.com>).Jul 4 2014, 16:59