Homec4science

Add hard stops on empty batch edit sets

Authored by epriestley <git@epriestley.com> on Jun 22 2015, 20:47.

Description

Add hard stops on empty batch edit sets

Summary:
Ref T8637. If a user tries to batch edit a list of tasks which can't be edited, we fall through to withIDs(array()), which can affect everything.

Explicitly stop batch editing if we don't have valid IDs or valid tasks.

The UI sort-of warns you that something is wrong, but this is ultimately a pretty severe UX issue. I'll fix the underlying Query in the next diff.

Test Plan: Tried to batch edit a list of tasks I didn't have permission to edit.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: lloyd.oliver, epriestley

Maniphest Tasks: T8637

Differential Revision: https://secure.phabricator.com/D13388

Details

Committed
epriestley <git@epriestley.com>Jun 22 2015, 20:47
Pushed
aubortJan 31 2017, 17:16
Parents
rPHd1983560a6bc: Show when objects have a non-default policy
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH0597aba33ec1: Add hard stops on empty batch edit sets (authored by epriestley <git@epriestley.com>).Jun 22 2015, 20:47