Homec4science

Always pass handles to tokenizers, not `<phid -> name>` maps

Authored by epriestley <git@epriestley.com> on Oct 7 2013, 21:51.

Description

Always pass handles to tokenizers, not <phid -> name> maps

Summary: Ref T1279. Prerequisite for adding icons or other type information to tokenizers, since we don't currently have enough information to prefill them when rendering things from the server side. By passing handles in, the tokenizer can extract type information.

Test Plan:

  • Searched by user in Audit.
  • Sent Conpherence from profile page.
  • Tried to send an empty conpherence.
  • Searched Countdown by user.
  • Edited CCs in Differential.
  • Edited reviewers in Differential.
  • Edited a commit's projects.
  • Searched lint by owner.
  • Searched feed by owner/project.
  • Searched files by owner.
  • Searched Herald by owner.
  • Searched Legalpad by owner.
  • Searched Macro by owner.
  • Filtered Maniphest reports by project.
  • Edited CCs in Maniphest.
  • Searched Owners by owner.
  • Edited an Owners package.
  • Searched Paste by owner.
  • Searched activity logs by owner.
  • Searched for mocks by owner.
  • Edited a mock's CCs.
  • Searched Ponder by owner.
  • Searched projects by owner.
  • Edited a Releeph project's pushers.
  • Searched Releeph by requestor.
  • Edited "Uses Symbols" for an Arcanist project.
  • Edited all tokenizers in main search.
  • Searched Slowvote by user.

Reviewers: chad, btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T1279

Differential Revision: https://secure.phabricator.com/D7248

Details

Committed
epriestley <git@epriestley.com>Oct 7 2013, 21:51
Pushed
aubortJan 31 2017, 17:16
Parents
rPH2abbd518684a: Don't raise a policy exception if a user can't see the parent revision of a new…
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH059860047615: Always pass handles to tokenizers, not `<phid -> name>` maps (authored by epriestley <git@epriestley.com>).Oct 7 2013, 21:51