Homec4science

Converted the pinned applications selector to a typeahead.

Authored by Josh Cox <joshcox@uberatc.com> on Aug 26 2016, 02:53.

Description

Converted the pinned applications selector to a typeahead.

Summary: Fixes T11513. Previously the selector was just a giant dropdown which was just... just too much. Now there's a handy typeahead.

Test Plan:
Happy Path:
Go to Settings -> Home Page -> Pin Application, start typing in the form then select one of the options. Click on "Pin Application". The application should now be in the list.

Other paths:

  • Type nothing into the box and submit, nothing should happen.
  • Choose an application that is already pinned. The list should stay the same.
  • Type nonsense into the box and submit, nothing should happen.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: chad, Korvin, epriestley, yelirekim

Maniphest Tasks: T11513

Differential Revision: https://secure.phabricator.com/D16459

Details

Committed
Josh Cox <joshcox@uberatc.com>Aug 26 2016, 20:24
Pushed
aubortJan 31 2017, 17:16
Parents
rPH90294713e850: Use phutil_json_encode() in AphrontResponse to raise better errors
Branches
Unknown
Tags
Unknown

Event Timeline

Josh Cox <joshcox@uberatc.com> committed rPH067d12d7168a: Converted the pinned applications selector to a typeahead. (authored by Josh Cox <joshcox@uberatc.com>).Aug 26 2016, 20:24