Homec4science

Mark reviewers as "commented" when they leave a comment

Authored by epriestley <git@epriestley.com> on Feb 25 2014, 21:37.

Description

Mark reviewers as "commented" when they leave a comment

Summary:
Ref T2222. This requires one new trick:

  • When merging edge transactions which both add/update an edge, the Editor gets to control how the edge data is merged.

Specifically, we pick the "strongest" state to keep, so "accept + comment" leaves you with an accept instead of a comment.

Test Plan: Accepted, commented on, and comment + accepted revisions. Added some debugging dumps to verify that the merging was getting hit and working correctly.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2222

Differential Revision: https://secure.phabricator.com/D8340

Details

Committed
epriestley <git@epriestley.com>Feb 25 2014, 21:37
Pushed
aubortJan 31 2017, 17:16
Parents
rPHa69cca9fbb15: Update overall revision status after reviewers change
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH06fc82a3eeff: Mark reviewers as "commented" when they leave a comment (authored by epriestley <git@epriestley.com>).Feb 25 2014, 21:37