Use direct inclusion, not submodules, to bring Javelin into Phabricator
07767fda00ab
Actions

Authored by epriestley <git@epriestley.com> on Jan 22 2013, 19:32.

Description

Use direct inclusion, not submodules, to bring Javelin into Phabricator

Summary:
Submoduling is slightly convenient for developers but hellishly difficult for many users. Since we make about a dozen updates to Javelin per year, just include the source directly.

Even if we run git submodule status more often, this creates additional problems for users with PATH misconfigured.

Fixes T2062 by nuking it from orbit.

Test Plan: Loaded site, browsed around. Grepped for references to submodules.

Reviewers: btrahan, vrana

CC: aran

Maniphest Tasks: T2062

Differential Revision: https://secure.phabricator.com/D4581

Details

Committed

epriestley <git@epriestley.com>

Jan 22 2013, 21:43

Pushed

aubort

Jan 31 2017, 17:16

Parents

rPH22c64c67ffca: Fix performance problem for large task queues

Branches

Unknown

Tags

Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH07767fda00ab: Use direct inclusion, not submodules, to bring Javelin into Phabricator (authored by epriestley <git@epriestley.com>).Jan 22 2013, 21:43

Changes (90)

		Path
D		.gitmodules
D		externals/javelin
A	(dir)	externals/javelinjs/
A		externals/javelinjs/.gitignore
A		externals/javelinjs/LICENSE
A		externals/javelinjs/README
A	(dir)	externals/javelinjs/src/
A	(dir)	externals/javelinjs/src/core/
A		externals/javelinjs/src/core/Event.js
A		externals/javelinjs/src/core/Stratcom.js
A	(dir)	externals/javelinjs/src/core/__tests__/
A		externals/javelinjs/src/core/__tests__/event-stop-and-kill.js
A		externals/javelinjs/src/core/__tests__/install.js
A		externals/javelinjs/src/core/__tests__/stratcom.js
A		externals/javelinjs/src/core/__tests__/util.js
A		externals/javelinjs/src/core/init.js
A		externals/javelinjs/src/core/install.js
A		externals/javelinjs/src/core/util.js
A	(dir)	externals/javelinjs/src/docs/
A		externals/javelinjs/src/docs/Base.js
A	(dir)	externals/javelinjs/src/docs/concepts/
A		externals/javelinjs/src/docs/concepts/behaviors.diviner
A		externals/javelinjs/src/docs/concepts/event_delegation.diviner
A		externals/javelinjs/src/docs/concepts/sigils_metadata.diviner
A		externals/javelinjs/src/docs/facebook.diviner
A		externals/javelinjs/src/docs/onload.js
A	(dir)	externals/javelinjs/src/ext/
A	(dir)	externals/javelinjs/src/ext/fx/
A		externals/javelinjs/src/ext/fx/Color.js
A		externals/javelinjs/src/ext/fx/FX.js
A	(dir)	externals/javelinjs/src/ext/reactor/
A	(dir)	externals/javelinjs/src/ext/reactor/core/
A		externals/javelinjs/src/ext/reactor/core/DynVal.js
A		externals/javelinjs/src/ext/reactor/core/Reactor.js
A		externals/javelinjs/src/ext/reactor/core/ReactorNode.js
A		externals/javelinjs/src/ext/reactor/core/ReactorNodeCalmer.js
A	(dir)	externals/javelinjs/src/ext/reactor/dom/
A		externals/javelinjs/src/ext/reactor/dom/RDOM.js
A	(dir)	externals/javelinjs/src/ext/view/
A		externals/javelinjs/src/ext/view/HTMLView.js
A		externals/javelinjs/src/ext/view/View.js
A		externals/javelinjs/src/ext/view/ViewInterpreter.js
A		externals/javelinjs/src/ext/view/ViewPlaceholder.js
A		externals/javelinjs/src/ext/view/ViewRenderer.js
A		externals/javelinjs/src/ext/view/ViewVisitor.js
A	(dir)	externals/javelinjs/src/ext/view/__tests__/
A		externals/javelinjs/src/ext/view/__tests__/HTMLView.js
A		externals/javelinjs/src/ext/view/__tests__/View.js
A		externals/javelinjs/src/ext/view/__tests__/ViewInterpreter.js
A		externals/javelinjs/src/ext/view/__tests__/ViewRenderer.js
A	(dir)	externals/javelinjs/src/lib/
A		externals/javelinjs/src/lib/Cookie.js
A		externals/javelinjs/src/lib/DOM.js
A		externals/javelinjs/src/lib/History.js
A		externals/javelinjs/src/lib/JSON.js
A		externals/javelinjs/src/lib/Mask.js
A		externals/javelinjs/src/lib/Request.js
A		externals/javelinjs/src/lib/Resource.js
A		externals/javelinjs/src/lib/URI.js
A		externals/javelinjs/src/lib/Vector.js
A		externals/javelinjs/src/lib/Workflow.js
A	(dir)	externals/javelinjs/src/lib/__tests__/
A		externals/javelinjs/src/lib/__tests__/Cookie.js
A		externals/javelinjs/src/lib/__tests__/DOM.js
A		externals/javelinjs/src/lib/__tests__/JSON.js
A		externals/javelinjs/src/lib/__tests__/URI.js
A		externals/javelinjs/src/lib/__tests__/behavior.js
A		externals/javelinjs/src/lib/behavior.js
A	(dir)	externals/javelinjs/src/lib/control/
A	(dir)	externals/javelinjs/src/lib/control/tokenizer/
A		externals/javelinjs/src/lib/control/tokenizer/Tokenizer.js
A	(dir)	externals/javelinjs/src/lib/control/typeahead/
A		externals/javelinjs/src/lib/control/typeahead/Typeahead.js
A	(dir)	externals/javelinjs/src/lib/control/typeahead/normalizer/
A		externals/javelinjs/src/lib/control/typeahead/normalizer/TypeaheadNormalizer.js
A	(dir)	externals/javelinjs/src/lib/control/typeahead/source/
A		externals/javelinjs/src/lib/control/typeahead/source/TypeaheadCompositeSource.js
A		externals/javelinjs/src/lib/control/typeahead/source/TypeaheadOnDemandSource.js
A		externals/javelinjs/src/lib/control/typeahead/source/TypeaheadPreloadedSource.js
A		externals/javelinjs/src/lib/control/typeahead/source/TypeaheadSource.js
A		externals/javelinjs/src/lib/control/typeahead/source/TypeaheadStaticSource.js
M		scripts/install/install_rhel-derivs.sh
M		scripts/install/install_ubuntu.sh
M		scripts/install/update_phabricator.sh
M		src/__celerity_resource_map__.php
M		src/applications/cache/PhabricatorCaches.php
M		src/docs/installation_guide.diviner
M		src/infrastructure/PhabricatorSetup.php
M		src/infrastructure/lint/linter/PhabricatorJavelinLinter.php
M	(sym)	webroot/rsrc/js/javelin