Homec4science

Make Cmd+Enter work to submit a form

Authored by Ben Alpert <spicyjalapeno@gmail.com> on Apr 4 2014, 04:00.

Description

Make Cmd+Enter work to submit a form

Summary:
Fixes T3010.

keydown is what you're supposed to use for special keys like Enter; keypress didn't work for me for Cmd+Enter on Chrome.

Test Plan: Submitted a Differential field with Cmd+Enter on Chrome Mac. Also made sure Ctrl+Enter still works and Opt+Enter does not.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: epriestley, Korvin

Maniphest Tasks: T3010

Differential Revision: https://secure.phabricator.com/D8699

Details

Committed
epriestley <git@epriestley.com>Apr 4 2014, 04:00
Pushed
aubortJan 31 2017, 17:16
Parents
rPHe3b5737d02fb: Support CustomField in Herald, mostly
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH077f57f06dee: Make Cmd+Enter work to submit a form (authored by Ben Alpert <spicyjalapeno@gmail.com>).Apr 4 2014, 04:00