Homec4science

In Maniphest tasks, only move old owner to CC if owner changed

Authored by epriestley <git@epriestley.com> on Feb 23 2016, 18:58.

Description

In Maniphest tasks, only move old owner to CC if owner changed

Summary:
Fixes T10426. When the owner of a task changes, we try to add the old owner to CC so they're kept in the loop.

Currently, we do this unconditionally. This can add the owner as a subscriber when someone didn't change anything, which is confusing.

Instead, only do this if the owner actually changed.

Test Plan:

  • With "A" as owner, edited task and saved.
    • Before patch, A was added as subscriber.
    • After patch, A not added.
  • With "A" as owner, changed owner to "B" and saved.
    • Both before and after patch, "A" is added as a subscriber.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10426

Differential Revision: https://secure.phabricator.com/D15333

Details

Committed
epriestley <git@epriestley.com>Feb 23 2016, 19:10
Pushed
aubortJan 31 2017, 17:16
Parents
rPH2cdc40eb004a: Fix description variable on Blog manage page
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH0799c9182224: In Maniphest tasks, only move old owner to CC if owner changed (authored by epriestley <git@epriestley.com>).Feb 23 2016, 19:10