Homec4science

Modernize some Harbormaster Controller/Policy infrastructure

Authored by epriestley <git@epriestley.com> on Jun 21 2015, 18:02.

Description

Modernize some Harbormaster Controller/Policy infrastructure

Summary:
Ref T8095. This is just general groundwork for more exciting changes:

  • Use more modern conventions around controllers, UI elements, and dialogs.
  • Provide real CAN_EDIT policies and policy checks (they just don't do anything yet).

Test Plan:

  • Used all affected controllers.
  • Faked CAN_EDIT to POLICY_NOONE and verified everything was greyed out and unselectable.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T8095

Differential Revision: https://secure.phabricator.com/D13344

Details

Committed
epriestley <git@epriestley.com>Jun 21 2015, 18:02
Pushed
aubortJan 31 2017, 17:16
Parents
rPH7ad4c9c056d1: Replace Harbormaster "BuildItem" with Lint/Unit messages
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH081300c7f861: Modernize some Harbormaster Controller/Policy infrastructure (authored by epriestley <git@epriestley.com>).Jun 21 2015, 18:02