Explicitly track inline comment reply threading
082b7f95e6e6
Actions

Authored by epriestley <git@epriestley.com> on Mar 8 2015, 21:04.

Description

Explicitly track inline comment reply threading

Summary:
Ref T1460. Track and store which comments are threaded replies to other comments, vs merely appearing on the same lines.

This doesn't actually write hasReplies yet, since that needs to happen when we un-draft comments on submission.

Test Plan: Made inline comments in Differential and Diffusion, including replies. Replies were marked as "Is Reply".

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T1460

Committed

epriestley <git@epriestley.com>

Mar 9 2015, 18:26

Pushed

aubort

Jan 31 2017, 17:16

Parents

rPH7a9768fc795f: Respect unified view in Diffusion

Branches

Unknown

Tags

Unknown

epriestley <git@epriestley.com> committed rPH082b7f95e6e6: Explicitly track inline comment reply threading (authored by epriestley <git@epriestley.com>).Mar 9 2015, 18:26

				Path
	M			src/applications/audit/storage/PhabricatorAuditInlineComment.php
	M			src/applications/differential/controller/DifferentialInlineCommentEditController.php
	M			src/applications/differential/query/DifferentialInlineCommentQuery.php
	M			src/applications/differential/storage/DifferentialInlineComment.php
	M			src/applications/diffusion/controller/DiffusionInlineCommentController.php
	M			src/infrastructure/diff/PhabricatorInlineCommentController.php
	M			src/infrastructure/diff/interface/PhabricatorInlineCommentInterface.php
	M			src/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php
	M			src/infrastructure/diff/view/PHUIDiffInlineCommentEditView.php
	M			webroot/rsrc/js/application/differential/DifferentialInlineCommentEditor.js
	M			webroot/rsrc/js/application/differential/behavior-edit-inline-comments.js