Homec4science

Fix regenerate arcanist cert, setup stuff and avoid accept non valid image…

Authored by cadamo <cristian.adamo@gmail.com> on Jun 3 2011, 04:27.

Description

Fix regenerate arcanist cert, setup stuff and avoid accept non valid image files as profile picture.

Summary:
Well, since I couldn't regenerate my arcanist cert I figured out that this wass because "workflows" are unavailable there now. I really can not figure out why but it was.
I added in the setup script, the ability to check if is present the protocol of the host and if it has a trailing slash a the end of the line, since both are needed to generate the cert.

Users now only be able to upload valid image files with mimetype of jpg, jpeg,
png and gif.

Test Plan:
FIRST: DO NOT apply those changes! then
1- go to settings->arcanist certificate and the click on regenerate ... humm
2- On your config file, delete the trailing slash at the end and the protocol on "phabricator.base-uri", then go to setting->arcanist certificate. Here you
will see something like this "phabricator.example.comapi\/" instead of
"http:\/\/phabricator.example.com\/api\/".

SECOND: Now apply this changes:
1- Go to settings->arcanist certificate and the click on regenerate.
2- On your config file, delete the trailing slash at the end and the protocol
on "phabricator.base-uri", and setup "phabricator.setup" to true.
3- Then go to setting->arcanist certificate and you could see that this was successfully generated.

THIRD:
Go to settings->account and try to upload an invalid image file, and do the same on "youruserna"->edit profile.

Reviewed By: epriestley
Reviewers: epriestley jungejason
CC: epriestley jugesason cadamo aran
Differential Revision: 391

Details

Committed
cadamo <cristian.adamo@gmail.com>Jun 3 2011, 04:27
Pushed
aubortJan 31 2017, 17:16
Parents
rPHa63274289c89: Link macro thumbs and show an exact page count
Branches
Unknown
Tags
Unknown

Event Timeline

cadamo <cristian.adamo@gmail.com> committed rPH089d8327b3cc: Fix regenerate arcanist cert, setup stuff and avoid accept non valid image… (authored by cadamo <cristian.adamo@gmail.com>).Jun 3 2011, 04:27