Homec4science

Remove all hardcoded behaviors associated with task priorities

Authored by epriestley <git@epriestley.com> on Sep 13 2013, 19:24.

Description

Remove all hardcoded behaviors associated with task priorities

Summary:
Ref T3583. Currently, we have some hard-coded behaviors associated with the "Unbreak Now" and "Needs Triage" priorities. Remove them:

  • Users seem somewhat confused by these on occasion, and never seem to think they're cool/useful (that I've seen, at least).
  • I think they have low utility in general, see T3583.
  • Saves three queries on the home page, which can no longer use row counting since they must be policy filtered.
  • Primarily, this paves the way for allowing installs to customize priorities, which is an occasional request.

Also deletes a lot of code with no callsites.

Test Plan: Mostly grep. Loaded home page. Viewed reports and task list.

Reviewers: btrahan

Reviewed By: btrahan

CC: chad, aran

Maniphest Tasks: T3583

Differential Revision: https://secure.phabricator.com/D6981

Details

Committed
epriestley <git@epriestley.com>Sep 13 2013, 20:50
Pushed
aubortJan 31 2017, 17:16
Parents
rPH91880b5a5158: Rename `ManiphestTaskListControllerPro` to `ManiphestTaskListController`
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH092f540199b7: Remove all hardcoded behaviors associated with task priorities (authored by epriestley <git@epriestley.com>).Sep 13 2013, 20:50