Homec4science

Show users what's wrong when they try to edit an inline with an editor already…

Authored by epriestley <git@epriestley.com> on Sep 10 2015, 20:36.

Description

Show users what's wrong when they try to edit an inline with an editor already open

Summary: Fixes T8572. Ideally we would probably just permit this, but clean up the behavior until the day arrives when inline code is actually rewritten.

Test Plan:

  • Tried to launch editors in Differential and Diffusion while comments were already open.
  • Verified that "Jump to inline" works in both cases.

{F788008}

{F788009}

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T8572

Differential Revision: https://secure.phabricator.com/D14094

Details

Committed
epriestley <git@epriestley.com>Sep 10 2015, 20:36
Pushed
aubortJan 31 2017, 17:16
Parents
rPH738cb1fa7827: Fix Mercurial unable to authenticate with HTTP when pulling
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH093a6256984c: Show users what's wrong when they try to edit an inline with an editor already… (authored by epriestley <git@epriestley.com>).Sep 10 2015, 20:36