Homec4science

Support "only the first time" in Maniphest

Authored by epriestley <git@epriestley.com> on Feb 11 2014, 16:45.

Description

Support "only the first time" in Maniphest

Summary:
Ref T4403. Implements "only the first time" for Maniphest rules, and fixes the trigger itself.

The trigger would never fire and block rules because it was comparing a string (like "first") to an int (like 0).

The "only" vs "every" stuff is contributed and I should have pushed back harder on this toInt / toString stuff. Maybe I'll just get rid of it; it purely causes confusion and problems.

Test Plan: Wrote an "only the first time" rule, ran it twice, it applied once.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T4403

Differential Revision: https://secure.phabricator.com/D8193

Details

Committed
epriestley <git@epriestley.com>Feb 11 2014, 16:45
Pushed
aubortJan 31 2017, 17:16
Parents
rPHa3acf5fc4b94: Soft-launch project boards
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH094922bcb930: Support "only the first time" in Maniphest (authored by epriestley <git@epriestley.com>).Feb 11 2014, 16:45