Homec4science

Use libphutil script initializer to initialize scripts in Phabricator

Authored by epriestley <git@epriestley.com> on Mar 20 2012, 03:21.

Description

Use libphutil script initializer to initialize scripts in Phabricator

Summary:
libphutil has some basic environmental sanity checks that we should use when initializing scripts in Phabricator. Principally this:

https://secure.phabricator.com/diffusion/PHU/browse/master/scripts/__init_script__.php;db643ee9f5f524e7$26

Without this, the default ini may set CLI errors to go to some logfile, which means exceptions aren't shown on stderr.

See https://github.com/facebook/phabricator/issues/98/

Test Plan:

  • Ran "php -derror_log=/dev/null -f ./bin/phd debug adslkfnasdfnalks" prior to change; got confusing lack of output.
  • Ran "phd -derror_log=/dev/null -f ./bin/phd debug asdkflnaslfdnala" after change; got exception on stderr.

Reviewers: btrahan, killermonk

Reviewed By: btrahan

CC: aran, epriestley

Differential Revision: https://secure.phabricator.com/D1950

Details

Committed
epriestley <git@epriestley.com>Mar 20 2012, 03:21
Pushed
aubortJan 31 2017, 17:16
Parents
rPH1fc4dea55e91: Increase the click target area for the object selector
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH097e62b45c73: Use libphutil script initializer to initialize scripts in Phabricator (authored by epriestley <git@epriestley.com>).Mar 20 2012, 03:21