Homec4science

Ref T8989, Add a "Visit URL" link to Phurl items.

Authored by lkassianik <lyubakassianik@gmail.com> on Nov 2 2015, 17:40.

Description

Ref T8989, Add a "Visit URL" link to Phurl items.

Summary: Ref T8989, Add a "Visit URL" link to Phurl items and make it actionable if the URI has a valid protocol.

Test Plan:

  • Create a Phurl object with a URI of "google.com".
  • "Visit URL" action in action view should be greyed out.
  • Edit object to have URI "http://google.com" and save. "Visit URL" link should be available and should redirect to the intended URL.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: chad, Korvin

Maniphest Tasks: T8989

Differential Revision: https://secure.phabricator.com/D14379

Details

Committed
lpriestley <autocommitter@example.com>Nov 2 2015, 17:40
Pushed
aubortJan 31 2017, 17:16
Parents
rPH4e112537b255: Probable fix for ElasticSearch 2.0 type strictness
Branches
Unknown
Tags
Unknown

Event Timeline

lpriestley <autocommitter@example.com> committed rPH09d4ea884fe4: Ref T8989, Add a "Visit URL" link to Phurl items. (authored by lkassianik <lyubakassianik@gmail.com>).Nov 2 2015, 17:40