Homec4science

Purge readthrough caches before applying schema adjustments

Authored by epriestley <git@epriestley.com> on Oct 1 2014, 21:44.

Description

Purge readthrough caches before applying schema adjustments

Summary: Ref T1191. The bulk of the slowness in T1191 is copying tables. In some cases, we can't avoid this, but we have various readthrough caches which may be very large and are safe to drop, and dropping them is very quick (much less than 1 second). In particular, dropping the changeset_parse_cache made the process at least ~8 minutes faster on secure.phabricator.com (I killed it after 8 minutes, so I'm not sure what the real number is).

Test Plan: Ran bin/storage adjust and saw it drop caches before applying adjustments.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T1191

Differential Revision: https://secure.phabricator.com/D10616

Details

Committed
epriestley <git@epriestley.com>Oct 1 2014, 21:44
Pushed
aubortJan 31 2017, 17:16
Parents
rPH3a644cf6cc22: Truncate very old, overlong Maniphest mail keys
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH0a6473138fd6: Purge readthrough caches before applying schema adjustments (authored by epriestley <git@epriestley.com>).Oct 1 2014, 21:44