Allow commenting on non-viewable lightbox files
0aa3f8b86bff
Actions

Authored by Chad Little <chad@phacility.com> on Nov 22 2016, 20:25.

Description

Allow commenting on non-viewable lightbox files

Summary: Removes the viewable restriction on embedded files. Builds a basic lightbox UI for commenting.

Test Plan:
Add psd, pdf to Maniphest task, clicked on download, comment, left comment. Closed box.

{F1943726}

Reviewers: epriestley

Reviewed By: epriestley

Subscribers: Korvin

Maniphest Tasks: T3612

Committed

Chad Little <chad@phacility.com>

Nov 22 2016, 20:29

Pushed

aubort

Jan 31 2017, 17:16

Parents

rPH0ed767b967b3: Fix a couple of partition migration bugs

Branches

Unknown

Tags

Unknown

Chad Little <chad@phacility.com> committed rPH0aa3f8b86bff: Allow commenting on non-viewable lightbox files (authored by Chad Little <chad@phacility.com>).Nov 22 2016, 20:29

				Path
	M			resources/celerity/map.php
	M			src/applications/files/controller/PhabricatorFileLightboxController.php
	M			src/view/layout/PhabricatorFileLinkView.php
	M			src/view/page/PhabricatorStandardPageView.php
	M			webroot/rsrc/css/phui/phui-comment-panel.css
	M			webroot/rsrc/css/phui/phui-lightbox.css
	M			webroot/rsrc/js/core/behavior-lightbox-attachments.js