Further improve line grouping in unified views
0af80c1d90e9
Actions

Authored by epriestley <git@epriestley.com> on Mar 6 2015, 18:58.

Description

Further improve line grouping in unified views

Summary:
Ref T2009. This tweaks things a bit more to improve consecuitive groups of added and removed lines.

Generally, it gives us "old, old, old, new, new, new" intead of "old, new, old, new, old, new".

Feelin' real good about having unit tests for this stuff.

Test Plan: Unit tests, looked at diffs in web UI.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T2009

Committed

epriestley <git@epriestley.com>

Mar 6 2015, 18:58

Pushed

aubort

Jan 31 2017, 17:16

Parents

rPH85f4bdc2ac74: Update Conpherence Main UI

Branches

Unknown

Tags

Unknown

epriestley <git@epriestley.com> committed rPH0af80c1d90e9: Further improve line grouping in unified views (authored by epriestley <git@epriestley.com>).Mar 6 2015, 18:58

				Path
	M			src/applications/differential/__tests__/data/generated.diff.one.unshielded
	A			src/applications/differential/__tests__/data/groups.diff
	A			src/applications/differential/__tests__/data/groups.diff.one.expect
	A			src/applications/differential/__tests__/data/groups.diff.two.expect
	M			src/applications/differential/render/DifferentialChangesetRenderer.php