Homec4science

Fix dropdown for file whose diff is not displayable

Authored by Jason Ge <jungejason@fb.com> on Jun 20 2012, 00:56.

Description

Fix dropdown for file whose diff is not displayable

Summary: The current behavior is that, when the dropdown menu is clicked for a binary file, it navigates to the current revision page directly without showing the dropdown meu. The fix is to do nothing when there is no file displayed.

Test Plan:

  • checked a diff with binary file
  • checked a diff with normal files

Reviewers: vrana, epriestley

Reviewed By: epriestley

CC: epriestley, aran

Differential Revision: https://secure.phabricator.com/D2801

Details

Committed
Jason Ge <jungejason@fb.com>Jun 20 2012, 03:28
Pushed
aubortJan 31 2017, 17:16
Parents
rPHd27790884242: Minor, avoid branch loop nonsense for repositories not set to autoclose. See…
Branches
Unknown
Tags
Unknown

Event Timeline

Jason Ge <jungejason@fb.com> committed rPH0c088a695cfb: Fix dropdown for file whose diff is not displayable (authored by Jason Ge <jungejason@fb.com>).Jun 20 2012, 03:28