Homec4science

Pholio - render inline comments together in an email

Authored by Bob Trahan <bob.trahan@gmail.com> on Jun 21 2013, 02:13.

Description

Pholio - render inline comments together in an email

Summary: Used Differential emails as a formatting guide. This also includes "Image X: <inline comment>" similarly to how Differential has "<file path><line(s)>: <inline comment>" or what have you. Fixes T3138.

Test Plan: inserted some debugging code and verified the mail body format looked okay ish

Reviewers: epriestley, chad

Reviewed By: epriestley

CC: aran, Korvin

Maniphest Tasks: T3138

Differential Revision: https://secure.phabricator.com/D6258

Details

Committed
Bob Trahan <bob.trahan@gmail.com>Jun 21 2013, 02:13
Pushed
aubortJan 31 2017, 17:16
Parents
rPHa5ca96a5903d: ApplicationTransactions - reload subscribers if there's a transaction that…
Branches
Unknown
Tags
Unknown

Event Timeline

Bob Trahan <bob.trahan@gmail.com> committed rPH0d6e4e2799c5: Pholio - render inline comments together in an email (authored by Bob Trahan <bob.trahan@gmail.com>).Jun 21 2013, 02:13