Consolidate handling of SSH usernames
0db6eaca4173
Actions

Authored by epriestley <git@epriestley.com> on Apr 19 2016, 14:50.

Description

Consolidate handling of SSH usernames

Summary:
Ref T4292. This consolidates code for figuring out which user we should connect to hosts with.

Also narrows a lock window.

Test Plan: Browsed Diffusion, pulled and pushed through an SSH proxy.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T4292

Committed

epriestley <git@epriestley.com>

Apr 19 2016, 22:04

Pushed

aubort

Jan 31 2017, 17:16

Parents

rPHc9daa2b0ad1e: Consistently refer to 'Projects' as 'Tags'

Branches

Unknown

Tags

Unknown

epriestley <git@epriestley.com> committed rPH0db6eaca4173: Consolidate handling of SSH usernames (authored by epriestley <git@epriestley.com>).Apr 19 2016, 22:04

				Path
	M			src/applications/almanac/util/AlmanacKeys.php
	M			src/applications/diffusion/ssh/DiffusionSSHWorkflow.php
	M			src/applications/repository/storage/PhabricatorRepository.php
	M			src/applications/repository/storage/PhabricatorRepositoryURI.php