Homec4science

Improve Diffusion behavior for no-longer-existing commits

Authored by epriestley <git@epriestley.com> on Oct 3 2015, 01:11.

Description

Improve Diffusion behavior for no-longer-existing commits

Summary:
Ref T9028. When users push a commit, then later delete it (e.g., by deleting the branch which contained it) we currently explode when trying to view it.

Instead, degrade gradually if some information is not available.

Test Plan:

  • Looked at valid commits with parents, refs, branches and merges.
  • Looked at invalid commits.
  • Looked at a previously valid, now-deleted + gc'd commit:

{F859273}

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T9028

Differential Revision: https://secure.phabricator.com/D14227

Details

Committed
epriestley <git@epriestley.com>Oct 3 2015, 01:11
Pushed
aubortJan 31 2017, 17:16
Parents
rPH14d6325394bb: Acccept any HTTP 2xx status as success in Harbormaster
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH0db86cce7df7: Improve Diffusion behavior for no-longer-existing commits (authored by epriestley <git@epriestley.com>).Oct 3 2015, 01:11