Homec4science

Always provide a valid content source for DifferentialCommentEditor

Authored by epriestley <git@epriestley.com> on Feb 13 2014, 15:19.

Description

Always provide a valid content source for DifferentialCommentEditor

Summary: Ref T2222. On the tmp.differential branch, we're currently having
issues parsing commits which reference Differential revisions, because the
"user closed this revision (closed by commit xyz)" message is fataling:

[2014-02-13 14:12:36] EXCEPTION: (PhutilProxyException) Error while
executing task ID 345358 from queue. {>} (AphrontQueryException)
#1048: Column 'contentSource' cannot be null

Specifically, the MessageParser pathway for CommentEditor doesn't set a content
source. Make sure CommentEditor always sets a content source.

(This is also causing a buildup of diffs on D8212 and D8211.)

Auditors: btrahan

Details

Committed
epriestley <git@epriestley.com>Feb 13 2014, 15:19
Pushed
aubortJan 31 2017, 17:16
Parents
rPH18938b531071: Migrate Differential comments to ApplicationTransactions
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH0dc73d5d9357: Always provide a valid content source for DifferentialCommentEditor (authored by epriestley <git@epriestley.com>).Feb 13 2014, 15:19