Homec4science

Move XHProf sampling code out of index.php

Authored by epriestley <git@epriestley.com> on Feb 10 2013, 00:47.

Description

Move XHProf sampling code out of index.php

Summary:

  • Separate the ideas of "requested" (explicit user request) vs "started" (user request or sampling).
  • Move this code out of index.php into the XHProf stuff (general effort to make index.php smaller).

Test Plan:
Verified that profiling still works, and profiling extends to ajax requests.

Set sampling rate to 2, saw 50% samples.

Looked at database, saw sampling data populating properly.

Reviewers: vrana, nh

Reviewed By: vrana

CC: aran

Differential Revision: https://secure.phabricator.com/D4891

Details

Committed
epriestley <git@epriestley.com>Feb 10 2013, 00:47
Pushed
aubortJan 31 2017, 17:16
Parents
rPHb72e7969a1e0: Move Pygments handling to libphutil
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH0f8984f5a700: Move XHProf sampling code out of index.php (authored by epriestley <git@epriestley.com>).Feb 10 2013, 00:47