Homec4science

Tidy context displayed in gap

Authored by vrana <jakubv@fb.com> on Aug 30 2012, 01:34.

Description

Tidy context displayed in gap

Summary:
We have some complaints on this feature:

  • It's not clear that the displayed code is context from gap.
  • It would be better if the context would be displayed with its real indentation.
  • It's not clear how far the context is from the displayed code.
  • Links revealing gap aren't on consistent place.

This solves all these problems and introduces new one:
It now seems that the reveal links works only with the left side.
Anyway, I think that this is better overall.

I don't want to put the context on a separate line to not waste space.

Test Plan: Displayed various contexts, revealed context.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin, bh, jwatzman

Differential Revision: https://secure.phabricator.com/D3404

Details

Committed
vrana <jakubv@fb.com>Aug 30 2012, 02:25
Pushed
aubortJan 31 2017, 17:16
Parents
rPHcc0b74b01a2c: bin/accountadmin - allow creation of system accounts and create workflow for…
Branches
Unknown
Tags
Unknown

Event Timeline

vrana <jakubv@fb.com> committed rPH0f9f8b5f3058: Tidy context displayed in gap (authored by vrana <jakubv@fb.com>).Aug 30 2012, 02:25