Homec4science

Replace Differential Edit controller with EditEngine-driven EditPro controller

Authored by epriestley <git@epriestley.com> on Dec 14 2016, 00:39.

Description

Replace Differential Edit controller with EditEngine-driven EditPro controller

Summary:
Ref T11114. This replaces the old edit controller with a new one based entirely on EditEngine.

This removes the CustomFieldEditEngineExtension hack for Differential, since remaining field types are fairly straightforward and work with existing EditEngine support, as far as I can tell.

Test Plan:

  • Created a revision via web diffs.
  • Updated a revision via web diffs.
  • Edited a revision via web.
  • Edited nonstandard custom fields ("Blame Revision", "JIRA Issues").
  • Created a revision via CLI.
  • Updated a revision via CLI.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11114

Differential Revision: https://secure.phabricator.com/D17054

Details

Committed
epriestley <git@epriestley.com>Dec 14 2016, 16:27
Pushed
aubortJan 31 2017, 17:16
Parents
rPH32ce21a18197: Allow the new Differential EditEngine form to create/update diffs for revisions
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH102ea3cfa41d: Replace Differential Edit controller with EditEngine-driven EditPro controller (authored by epriestley <git@epriestley.com>).Dec 14 2016, 16:27