Homec4science

Make repository pulls testable

Authored by epriestley <git@epriestley.com> on May 13 2013, 04:05.

Description

Make repository pulls testable

Summary:
Ref T2784. This moves us toward being able to test the background and Conduit pipelines for repositories. In particular:

  • Separate the logic for pulling repositories (git pull, hg pull) out of PhabricatorRepositoryPullLocalDaemon and put it in PhabricatorRepositoryPullEngine. This allows repositories to be pulled directly without invoking the daemons.
  • Add tests for the engine, including a future-looking base test case.
  • Add basic PhutilDirectoryFixture-based repositories.

Next steps:

  1. Do the same for repo discovery.
  2. Then we can start writing tests against specific Conduit methods.

Test Plan: Ran unit tests. Ran bin/repository pull on SVN, Hg and Git repositories. Ran bin/phd debug pulllocal.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran, nh

Maniphest Tasks: T2784

Differential Revision: https://secure.phabricator.com/D5904

Details

Committed
epriestley <git@epriestley.com>May 13 2013, 04:05
Pushed
aubortJan 31 2017, 17:16
Parents
rPH98e2ad4ebc24: Add a space so that the feed doesn't say "the documentDocumentName"
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH105dd1899c35: Make repository pulls testable (authored by epriestley <git@epriestley.com>).May 13 2013, 04:05