Homec4science

Fix PhabricatorJavelinLinter regex issue caused by D2023

Authored by JeffMo <jeffmo@fb.com> on Mar 27 2012, 01:09.

Description

Fix PhabricatorJavelinLinter regex issue caused by D2023

Summary: D2023 adds a new '*' token to javelinsymbols (indicating that a behavior is 'installed'). This fixes a sanity-check regex in PhabricatorJavelinLinter that validates the output of javelinsymbols so that it is aware of this new token type.

Test Plan:
Patched javelinsymbols.cpp from D2023 to externals/javelin/support/javelinsymbols, build the new javelinsymbols binary, then ran

arc lint --lintall webroot/rsrc/js/application/core/behavior-drag-and-drop-textarea.js

(before this diff, that throws an error -- after it works with no lint)

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, epriestley

Differential Revision: https://secure.phabricator.com/D2025

Details

Committed
JeffMo <jeffmo@fb.com>Mar 27 2012, 01:10
Pushed
aubortJan 31 2017, 17:16
Parents
rPH3bacba7e9fe6: Show parent commits in Diffusion
Branches
Unknown
Tags
Unknown

Event Timeline

JeffMo <jeffmo@fb.com> committed rPH108f51d9b426: Fix PhabricatorJavelinLinter regex issue caused by D2023 (authored by JeffMo <jeffmo@fb.com>).Mar 27 2012, 01:10