Homec4science

Improve PhabricatorPropertyListView and add section headers

Authored by epriestley <git@epriestley.com> on Nov 21 2012, 03:01.

Description

Improve PhabricatorPropertyListView and add section headers

Summary:

  • For Drydock, I want to add section headers to separate user-defined attributes from global attributes.
  • Some day for Differential, I want to add "Summary" and "Test Plan" section headers.
  • Clean up some stuff a bit; drop the multiple APIs for setting text content. Explicitly disallow appendChild().
  • Build out the UIExample a bit.

Test Plan:
{F24821}

{F24822}

Reviewers: chad, btrahan

Reviewed By: chad

CC: aran

Maniphest Tasks: T2015

Differential Revision: https://secure.phabricator.com/D4000

Details

Committed
epriestley <git@epriestley.com>Nov 21 2012, 03:01
Pushed
aubortJan 31 2017, 17:16
Parents
rPHdf76ed9545f8: be careful of received mail object in error cases too
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH10a9f2a15f27: Improve PhabricatorPropertyListView and add section headers (authored by epriestley <git@epriestley.com>).Nov 21 2012, 03:01