Homec4science

(stable) Fix no-op transaction error on `paste.create` Conduit API method

Authored by epriestley <git@epriestley.com> on Nov 8 2015, 14:21.

Description

(stable) Fix no-op transaction error on paste.create Conduit API method

Summary:
Fixes T9735. I changed how the TYPE_LANGUAGE transction works a little but that accidentally tripped an error condition in paste.create.

  • Don't bail on no-effect transactions to paste.create (like not setting a language).
  • When a transaction type has no tailored UI message, make it easier to figure out which transaction is problematic.

Test Plan: Ran arc paste ... locally. Got an error before the patch, clean paste creation afterward.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T9735

Differential Revision: https://secure.phabricator.com/D14440

Details

Committed
epriestley <git@epriestley.com>Nov 8 2015, 16:10
Pushed
aubortJan 31 2017, 17:16
Parents
rPHe1642ada6ef1: (stable) Promote 2015 Week 45
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH111c48b21024: (stable) Fix no-op transaction error on `paste.create` Conduit API method (authored by epriestley <git@epriestley.com>).Nov 8 2015, 16:10