Homec4science

Fix exception in OAuthServerAuthController

Authored by Toby Hughes <hughes.toby@gmail.com> on Feb 6 2013, 17:59.

Description

Fix exception in OAuthServerAuthController

Summary:
We've been building a Jenkins plugin that allows you to use your Phabricator login details in Jenkins using the inbuilt OAuthServer. I noticed that when making a request to /oauthserver/auth/?client_id=&response_type=code I get an error back from the server.

I've traced this down to two bugs in PhabricatorOAuthServerAuthController, the first causes a null value error on $access_token_uri, and the second fails on userHasAuthorizedClient without a $scope array.

Test Plan: Go to /oauthserver/auth/?client_id=<client_id>&response_type=code and get a valid authorization code back

Reviewers: epriestley, btrahan

Reviewed By: btrahan

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D4808

Details

Committed
epriestley <git@epriestley.com>Feb 6 2013, 18:00
Pushed
aubortJan 31 2017, 17:16
Parents
rPHf912fa1ab799: Minor, fix celerity map.
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH1188876ea92f: Fix exception in OAuthServerAuthController (authored by Toby Hughes <hughes.toby@gmail.com>).Feb 6 2013, 18:00